| Message ID | 1384837639-9252-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Headers | show |
On 19 November 2013 10:37, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Silences the checkpatch warning introduced by > commit 94aa44090eda ("cpufreq: exynos: Add missing static"). > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Cc: Jonghwan Choi <jhbird.choi@samsung.com> > --- > drivers/cpufreq/exynos5250-cpufreq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Acked-by: Viresh Kumar <viresh.kumar@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, November 19, 2013 10:37:19 AM Sachin Kamat wrote: > Silences the checkpatch warning introduced by > commit 94aa44090eda ("cpufreq: exynos: Add missing static"). > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Cc: Jonghwan Choi <jhbird.choi@samsung.com> I'm not going to apply this and seriously if you care, please modify checkpatch.pl to stop emitting that warning. It is silly and useless in my opinion, so I won't take any patches "fixing" it. Thanks!
On 21 November 2013 06:24, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > On Tuesday, November 19, 2013 10:37:19 AM Sachin Kamat wrote: >> Silences the checkpatch warning introduced by >> commit 94aa44090eda ("cpufreq: exynos: Add missing static"). >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> Cc: Jonghwan Choi <jhbird.choi@samsung.com> > > I'm not going to apply this and seriously if you care, please modify > checkpatch.pl to stop emitting that warning. It is silly and useless in > my opinion, so I won't take any patches "fixing" it. Agreed. However, the cpufreq drivers are pretty clean already and this one just stands out. That was the only reason for doing this.
diff --git a/drivers/cpufreq/exynos5250-cpufreq.c b/drivers/cpufreq/exynos5250-cpufreq.c index 8feda86fe42c..ebbcbb7e1926 100644 --- a/drivers/cpufreq/exynos5250-cpufreq.c +++ b/drivers/cpufreq/exynos5250-cpufreq.c @@ -144,7 +144,8 @@ static void set_apll(unsigned int new_index, } -static bool exynos5250_pms_change(unsigned int old_index, unsigned int new_index) +static bool exynos5250_pms_change(unsigned int old_index, + unsigned int new_index) { unsigned int old_pm = apll_freq_5250[old_index].mps >> 8; unsigned int new_pm = apll_freq_5250[new_index].mps >> 8;
Silences the checkpatch warning introduced by commit 94aa44090eda ("cpufreq: exynos: Add missing static"). Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Cc: Jonghwan Choi <jhbird.choi@samsung.com> --- drivers/cpufreq/exynos5250-cpufreq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)