| Message ID | 200901170155.02757.elendil@planet.nl (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Headers | show |
Frans Pop wrote: > From: Frans Pop <elendil@planet.nl> > > hp-wmi: fix regressions caused by missing if statement > > Error was introduced in commit fe8e4e039dc3. > > Signed-off-by: Frans Pop <elendil@planet.nl> > --- >> On Saturday 17 January 2009, Frans Pop wrote: >>> When I first booted .29-rc2 my HP 2510p notebook hung while loading >>> hp-wmi, which I have listed in /etc/modules. Hard poweroff was >>> needed. > > And this obvious patch fixes the regression (tested). > > Andrew: I've added you as the broken patch also went via you. > Acked-by: Larry Finger <Larry.Finger@lwfinger.net> -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Jan 17, 2009 at 01:55:01AM +0100, Frans Pop wrote: > From: Frans Pop <elendil@planet.nl> > > hp-wmi: fix regressions caused by missing if statement > > Error was introduced in commit fe8e4e039dc3. > > Signed-off-by: Frans Pop <elendil@planet.nl> Signed-off-by: Matthew Garrett <mjg@redhat.com>
diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c index 7c789f0..6260420 100644 --- a/drivers/platform/x86/hp-wmi.c +++ b/drivers/platform/x86/hp-wmi.c @@ -441,6 +441,7 @@ static int __init hp_wmi_bios_setup(struct platform_device *device) bluetooth_rfkill->toggle_radio = hp_wmi_bluetooth_set; bluetooth_rfkill->user_claim_unsupported = 1; err = rfkill_register(bluetooth_rfkill); + if (err) goto register_bluetooth_error; }