diff mbox

Input: serio: remove unnecessary pci_set_drvdata()

Message ID 001b01cee983$f894c510$e9be4f30$%han@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jingoo Han Nov. 25, 2013, 2:13 a.m. UTC 
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/input/serio/pcips2.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Dmitry Torokhov Nov. 26, 2013, 2:11 a.m. UTC | #1 
On Mon, Nov 25, 2013 at 11:13:46AM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Applied, thank you.

> ---
>  drivers/input/serio/pcips2.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/serio/pcips2.c b/drivers/input/serio/pcips2.c
> index 76f8383..13062f6 100644
> --- a/drivers/input/serio/pcips2.c
> +++ b/drivers/input/serio/pcips2.c
> @@ -181,7 +181,6 @@ static void pcips2_remove(struct pci_dev *dev)
>  	struct pcips2_data *ps2if = pci_get_drvdata(dev);
>  
>  	serio_unregister_port(ps2if->io);
> -	pci_set_drvdata(dev, NULL);
>  	kfree(ps2if);
>  	pci_release_regions(dev);
>  	pci_disable_device(dev);
> -- 
> 1.7.10.4
> 
>
diff mbox

Patch

diff --git a/drivers/input/serio/pcips2.c b/drivers/input/serio/pcips2.c
index 76f8383..13062f6 100644
--- a/drivers/input/serio/pcips2.c
+++ b/drivers/input/serio/pcips2.c
@@ -181,7 +181,6 @@  static void pcips2_remove(struct pci_dev *dev)
 	struct pcips2_data *ps2if = pci_get_drvdata(dev);
 
 	serio_unregister_port(ps2if->io);
-	pci_set_drvdata(dev, NULL);
 	kfree(ps2if);
 	pci_release_regions(dev);
 	pci_disable_device(dev);