diff mbox

[2/2] pci-quirks: unhide 'Overflow' device on i828{6,7}5P/PE chipsets

Message ID 200905122108.n4CL8gDD011199@imap1.linux-foundation.org (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Andrew Morton May 12, 2009, 8:49 p.m. UTC 
Michal Miroslaw <mirq-linux@rere.qmqm.pl>

Some BIOSes hide 'overflow' device (dev #6) for i82875P/PE chipsets.
The same happens for i82865P/PE. Add a quirk to enable this device.
This allows i82875 EDAC driver to bind to chipset's dev #6 and not
dev #0 as the latter is used by AGP driver.

On my laptop (i82865P based) ACPI code is disabling this device
again in \_SB.PCI0._CRS method (called at least at PNP init time).
This can be easily worked around by patching DSDT.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Doug Thompson <norsk5@yahoo.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/pci/quirks.c |   22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

Comments

Jesse Barnes June 11, 2009, 6:45 p.m. UTC | #1 
On Tue, 12 May 2009 13:49:26 -0700
akpm@linux-foundation.org wrote:

> Michal Miroslaw <mirq-linux@rere.qmqm.pl>
> 
> Some BIOSes hide 'overflow' device (dev #6) for i82875P/PE chipsets.
> The same happens for i82865P/PE. Add a quirk to enable this device.
> This allows i82875 EDAC driver to bind to chipset's dev #6 and not
> dev #0 as the latter is used by AGP driver.
> 
> On my laptop (i82865P based) ACPI code is disabling this device
> again in \_SB.PCI0._CRS method (called at least at PNP init time).
> This can be easily worked around by patching DSDT.
> 
> [akpm@linux-foundation.org: coding-style fixes]
> Signed-off-by: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: Doug Thompson <norsk5@yahoo.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---

Ok this has been floating around for awhile, so I've applied it to
linux-next.  I'll revert if we get problem reports though.

Thanks,
diff mbox

Patch

diff -puN drivers/pci/quirks.c~pci-quirks-unhide-overflow-device-on-i828675p-pe-chipsets-v2 drivers/pci/quirks.c
--- a/drivers/pci/quirks.c~pci-quirks-unhide-overflow-device-on-i828675p-pe-chipsets-v2
+++ a/drivers/pci/quirks.c
@@ -2017,6 +2017,28 @@  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_BR
 			PCI_DEVICE_ID_NX2_5709S,
 			quirk_brcm_570x_limit_vpd);
 
+/* Originally in EDAC sources for i82875P:
+ * Intel tells BIOS developers to hide device 6 which
+ * configures the overflow device access containing
+ * the DRBs - this is where we expose device 6.
+ * http://www.x86-secret.com/articles/tweak/pat/patsecrets-2.htm
+ */
+static void __devinit quirk_unhide_mch_dev6(struct pci_dev *dev)
+{
+	u8 reg;
+
+	if (pci_read_config_byte(dev, 0xF4, &reg) == 0 && !(reg & 0x02)) {
+		dev_info(&dev->dev, "Enabling MCH 'Overflow' Device\n");
+		pci_write_config_byte(dev, 0xF4, reg | 0x02);
+	}
+}
+
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82865_HB,
+			quirk_unhide_mch_dev6);
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82875_HB,
+			quirk_unhide_mch_dev6);
+
+
 #ifdef CONFIG_PCI_MSI
 /* Some chipsets do not support MSI. We cannot easily rely on setting
  * PCI_BUS_FLAGS_NO_MSI in its bus flags because there are actually