| Message ID | 001b01ceebe0$82141940$863c4bc0$%han@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Nov 28, 2013 at 11:21:12AM +0900, Jingoo Han wrote: > This macro is used to create a struct pci_device_id array. Applied all 3, thank you. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/input/serio/pcips2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/serio/pcips2.c b/drivers/input/serio/pcips2.c > index 13062f6..2fff5d4 100644 > --- a/drivers/input/serio/pcips2.c > +++ b/drivers/input/serio/pcips2.c > @@ -186,7 +186,7 @@ static void pcips2_remove(struct pci_dev *dev) > pci_disable_device(dev); > } > > -static const struct pci_device_id pcips2_ids[] = { > +static DEFINE_PCI_DEVICE_TABLE(pcips2_ids) = { > { > .vendor = 0x14f2, /* MOBILITY */ > .device = 0x0123, /* Keyboard */ > -- > 1.7.10.4 > >
On Thursday, November 28, 2013 12:57 PM, Dmitry Torokhov wrote: > On Thu, Nov 28, 2013 at 11:21:12AM +0900, Jingoo Han wrote: > > This macro is used to create a struct pci_device_id array. > > Applied all 3, thank you. Please, drop these patches. According to the Greg Kroah-Hartman, "Yeah, and it's a horrid macro that deserves to be removed, please don't use it in more places. Actually, if you could just remove it, that would be best, sorry, I'm not going to take these patches." So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead. Sorry for annoying. :-) Best regards, Jingoo Han > > > > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > > --- > > drivers/input/serio/pcips2.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/input/serio/pcips2.c b/drivers/input/serio/pcips2.c > > index 13062f6..2fff5d4 100644 > > --- a/drivers/input/serio/pcips2.c > > +++ b/drivers/input/serio/pcips2.c > > @@ -186,7 +186,7 @@ static void pcips2_remove(struct pci_dev *dev) > > pci_disable_device(dev); > > } > > > > -static const struct pci_device_id pcips2_ids[] = { > > +static DEFINE_PCI_DEVICE_TABLE(pcips2_ids) = { > > { > > .vendor = 0x14f2, /* MOBILITY */ > > .device = 0x0123, /* Keyboard */ > > -- > > 1.7.10.4 > > > > > > -- > Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 28, 2013 at 01:32:31PM +0900, Jingoo Han wrote: > On Thursday, November 28, 2013 12:57 PM, Dmitry Torokhov wrote: > > On Thu, Nov 28, 2013 at 11:21:12AM +0900, Jingoo Han wrote: > > > This macro is used to create a struct pci_device_id array. > > > > Applied all 3, thank you. > > Please, drop these patches. > According to the Greg Kroah-Hartman, > > "Yeah, and it's a horrid macro that deserves to be removed, please don't > use it in more places. > > Actually, if you could just remove it, that would be best, sorry, I'm > not going to take these patches." > > So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead. > Sorry for annoying. :-) No worries, I dropped them. Thanks.
diff --git a/drivers/input/serio/pcips2.c b/drivers/input/serio/pcips2.c index 13062f6..2fff5d4 100644 --- a/drivers/input/serio/pcips2.c +++ b/drivers/input/serio/pcips2.c @@ -186,7 +186,7 @@ static void pcips2_remove(struct pci_dev *dev) pci_disable_device(dev); } -static const struct pci_device_id pcips2_ids[] = { +static DEFINE_PCI_DEVICE_TABLE(pcips2_ids) = { { .vendor = 0x14f2, /* MOBILITY */ .device = 0x0123, /* Keyboard */
This macro is used to create a struct pci_device_id array. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/input/serio/pcips2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)