| Message ID | 20131120000740.27032.66529.sendpatchset@w520 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Nov 20, 2013 at 09:07:40AM +0900, Magnus Damm wrote: > From: Magnus Damm <damm@opensource.se> > > Add "renesas,irqc-r8a7790" to the compatible string for IRQC > in case of r8a7790. This makes the IRQC follow the same style > as the other devices and also makes it more future proof. > > Signed-off-by: Magnus Damm <damm@opensource.se> > --- > > arch/arm/boot/dts/r8a7790.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, I will queue this up. Assuming all goes will I plan to push this and other updates today or tomorrow. > > --- 0003/arch/arm/boot/dts/r8a7790.dtsi > +++ work/arch/arm/boot/dts/r8a7790.dtsi 2013-11-20 08:20:30.000000000 +0900 > @@ -171,7 +171,7 @@ > }; > > irqc0: interrupt-controller@e61c0000 { > - compatible = "renesas,irqc"; > + compatible = "renesas,irqc-r8a7790", "renesas,irqc"; > #interrupt-cells = <2>; > interrupt-controller; > reg = <0 0xe61c0000 0 0x200>; > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Hi Magnus, Thank you for the patch. On Wednesday 20 November 2013 09:07:40 Magnus Damm wrote: > From: Magnus Damm <damm@opensource.se> > > Add "renesas,irqc-r8a7790" to the compatible string for IRQC > in case of r8a7790. This makes the IRQC follow the same style > as the other devices and also makes it more future proof. You should update the device tree bindings documentation as well. As there's no such documentation of the irqc, you should create it ;-) > Signed-off-by: Magnus Damm <damm@opensource.se> > --- > > arch/arm/boot/dts/r8a7790.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- 0003/arch/arm/boot/dts/r8a7790.dtsi > +++ work/arch/arm/boot/dts/r8a7790.dtsi 2013-11-20 08:20:30.000000000 +0900 > @@ -171,7 +171,7 @@ > }; > > irqc0: interrupt-controller@e61c0000 { > - compatible = "renesas,irqc"; > + compatible = "renesas,irqc-r8a7790", "renesas,irqc"; > #interrupt-cells = <2>; > interrupt-controller; > reg = <0 0xe61c0000 0 0x200>;
On Wed, Nov 27, 2013 at 11:11:47AM +0100, Laurent Pinchart wrote: > Hi Magnus, > > Thank you for the patch. > > On Wednesday 20 November 2013 09:07:40 Magnus Damm wrote: > > From: Magnus Damm <damm@opensource.se> > > > > Add "renesas,irqc-r8a7790" to the compatible string for IRQC > > in case of r8a7790. This makes the IRQC follow the same style > > as the other devices and also makes it more future proof. > > You should update the device tree bindings documentation as well. As there's > no such documentation of the irqc, you should create it ;-) I will submit a patch for this.
On Wed, Nov 20, 2013 at 09:07:40AM +0900, Magnus Damm wrote: > From: Magnus Damm <damm@opensource.se> > > Add "renesas,irqc-r8a7790" to the compatible string for IRQC > in case of r8a7790. This makes the IRQC follow the same style > as the other devices and also makes it more future proof. > > Signed-off-by: Magnus Damm <damm@opensource.se> Should I make a similar patch for the r8a73a4? > --- > > arch/arm/boot/dts/r8a7790.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- 0003/arch/arm/boot/dts/r8a7790.dtsi > +++ work/arch/arm/boot/dts/r8a7790.dtsi 2013-11-20 08:20:30.000000000 +0900 > @@ -171,7 +171,7 @@ > }; > > irqc0: interrupt-controller@e61c0000 { > - compatible = "renesas,irqc"; > + compatible = "renesas,irqc-r8a7790", "renesas,irqc"; > #interrupt-cells = <2>; > interrupt-controller; > reg = <0 0xe61c0000 0 0x200>; > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
--- 0003/arch/arm/boot/dts/r8a7790.dtsi +++ work/arch/arm/boot/dts/r8a7790.dtsi 2013-11-20 08:20:30.000000000 +0900 @@ -171,7 +171,7 @@ }; irqc0: interrupt-controller@e61c0000 { - compatible = "renesas,irqc"; + compatible = "renesas,irqc-r8a7790", "renesas,irqc"; #interrupt-cells = <2>; interrupt-controller; reg = <0 0xe61c0000 0 0x200>;