| Message ID | 1385590783-27604-1-git-send-email-srinivas.pandruvada@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On 11/27/13 22:19, Srinivas Pandruvada wrote: > Exporting logical minimum and maximum of HID fields as part of the > hid sensor attribute info. This can be used for range checking and > to calculate enumeration base for NAry fields of HID sensor hub. > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Hi, I would have preffred this being done in two patches, the first refactoring the function call and the second doing the min and max. Anyhow, I'll take it anyway. Applied to the togreg branch of iio.git. > --- > drivers/hid/hid-sensor-hub.c | 20 ++++++++------------ > include/linux/hid-sensor-hub.h | 2 ++ > 2 files changed, 10 insertions(+), 12 deletions(-) > > diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c > index a184e19..d87f7cb 100644 > --- a/drivers/hid/hid-sensor-hub.c > +++ b/drivers/hid/hid-sensor-hub.c > @@ -112,13 +112,15 @@ static int sensor_hub_get_physical_device_count( > > static void sensor_hub_fill_attr_info( > struct hid_sensor_hub_attribute_info *info, > - s32 index, s32 report_id, s32 units, s32 unit_expo, s32 size) > + s32 index, s32 report_id, struct hid_field *field) > { > info->index = index; > info->report_id = report_id; > - info->units = units; > - info->unit_expo = unit_expo; > - info->size = size/8; > + info->units = field->unit; > + info->unit_expo = field->unit_exponent; > + info->size = (field->report_size * field->report_count)/8; > + info->logical_minimum = field->logical_minimum; > + info->logical_maximum = field->logical_maximum; > } > > static struct hid_sensor_hub_callbacks *sensor_hub_get_callback( > @@ -325,9 +327,7 @@ int sensor_hub_input_get_attribute_info(struct hid_sensor_hub_device *hsdev, > if (field->physical == usage_id && > field->logical == attr_usage_id) { > sensor_hub_fill_attr_info(info, i, report->id, > - field->unit, field->unit_exponent, > - field->report_size * > - field->report_count); > + field); > ret = 0; > } else { > for (j = 0; j < field->maxusage; ++j) { > @@ -336,11 +336,7 @@ int sensor_hub_input_get_attribute_info(struct hid_sensor_hub_device *hsdev, > field->usage[j].collection_index == > collection_index) { > sensor_hub_fill_attr_info(info, > - i, report->id, > - field->unit, > - field->unit_exponent, > - field->report_size * > - field->report_count); > + i, report->id, field); > ret = 0; > break; > } > diff --git a/include/linux/hid-sensor-hub.h b/include/linux/hid-sensor-hub.h > index a265af2..fd66e45 100644 > --- a/include/linux/hid-sensor-hub.h > +++ b/include/linux/hid-sensor-hub.h > @@ -40,6 +40,8 @@ struct hid_sensor_hub_attribute_info { > s32 units; > s32 unit_expo; > s32 size; > + s32 logical_minimum; > + s32 logical_maximum; > }; > > /** > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 30 Nov 2013, Jonathan Cameron wrote: > On 11/27/13 22:19, Srinivas Pandruvada wrote: > > Exporting logical minimum and maximum of HID fields as part of the > > hid sensor attribute info. This can be used for range checking and > > to calculate enumeration base for NAry fields of HID sensor hub. > > > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Hi, I would have preffred this being done in two patches, the first > refactoring the function call and the second doing the min and max. > > Anyhow, I'll take it anyway. > > Applied to the togreg branch of iio.git. Where is that? I don't seem to see it in https://git.kernel.org/cgit/linux/kernel/git/jic23/iio.git/log/?h=togreg
Hi Jiri I tend to push a testing branch to catch any build issues before pushing to the real togreg branch. Normally there are only a few hours on between but sometimes it is a few days as here. I will move these to the fixes-togreg branch - hopefully this evening... Jiri Kosina <jkosina@suse.cz> wrote: >On Sat, 30 Nov 2013, Jonathan Cameron wrote: > >> On 11/27/13 22:19, Srinivas Pandruvada wrote: >> > Exporting logical minimum and maximum of HID fields as part of the >> > hid sensor attribute info. This can be used for range checking and >> > to calculate enumeration base for NAry fields of HID sensor hub. >> > >> > Signed-off-by: Srinivas Pandruvada ><srinivas.pandruvada@linux.intel.com> >> Hi, I would have preffred this being done in two patches, the first >> refactoring the function call and the second doing the min and max. >> >> Anyhow, I'll take it anyway. >> >> Applied to the togreg branch of iio.git. > >Where is that? I don't seem to see it in > > https://git.kernel.org/cgit/linux/kernel/git/jic23/iio.git/log/?h=togreg
On 12/02/13 17:14, Jonathan Cameron wrote: > Hi Jiri > > I tend to push a testing branch to catch any build issues before pushing to the real togreg branch. Normally there are only a few hours on between but sometimes it is a few days as here. I will move these to the fixes-togreg branch - hopefully this evening... Now applied to the fixes-togreg branch (this one does get pushed out to kernel.org directly!) > > Jiri Kosina <jkosina@suse.cz> wrote: >> On Sat, 30 Nov 2013, Jonathan Cameron wrote: >> >>> On 11/27/13 22:19, Srinivas Pandruvada wrote: >>>> Exporting logical minimum and maximum of HID fields as part of the >>>> hid sensor attribute info. This can be used for range checking and >>>> to calculate enumeration base for NAry fields of HID sensor hub. >>>> >>>> Signed-off-by: Srinivas Pandruvada >> <srinivas.pandruvada@linux.intel.com> >>> Hi, I would have preffred this being done in two patches, the first >>> refactoring the function call and the second doing the min and max. >>> >>> Anyhow, I'll take it anyway. >>> >>> Applied to the togreg branch of iio.git. >> Where is that? I don't seem to see it in >> >> https://git.kernel.org/cgit/linux/kernel/git/jic23/iio.git/log/?h=togreg -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index a184e19..d87f7cb 100644 --- a/drivers/hid/hid-sensor-hub.c +++ b/drivers/hid/hid-sensor-hub.c @@ -112,13 +112,15 @@ static int sensor_hub_get_physical_device_count( static void sensor_hub_fill_attr_info( struct hid_sensor_hub_attribute_info *info, - s32 index, s32 report_id, s32 units, s32 unit_expo, s32 size) + s32 index, s32 report_id, struct hid_field *field) { info->index = index; info->report_id = report_id; - info->units = units; - info->unit_expo = unit_expo; - info->size = size/8; + info->units = field->unit; + info->unit_expo = field->unit_exponent; + info->size = (field->report_size * field->report_count)/8; + info->logical_minimum = field->logical_minimum; + info->logical_maximum = field->logical_maximum; } static struct hid_sensor_hub_callbacks *sensor_hub_get_callback( @@ -325,9 +327,7 @@ int sensor_hub_input_get_attribute_info(struct hid_sensor_hub_device *hsdev, if (field->physical == usage_id && field->logical == attr_usage_id) { sensor_hub_fill_attr_info(info, i, report->id, - field->unit, field->unit_exponent, - field->report_size * - field->report_count); + field); ret = 0; } else { for (j = 0; j < field->maxusage; ++j) { @@ -336,11 +336,7 @@ int sensor_hub_input_get_attribute_info(struct hid_sensor_hub_device *hsdev, field->usage[j].collection_index == collection_index) { sensor_hub_fill_attr_info(info, - i, report->id, - field->unit, - field->unit_exponent, - field->report_size * - field->report_count); + i, report->id, field); ret = 0; break; } diff --git a/include/linux/hid-sensor-hub.h b/include/linux/hid-sensor-hub.h index a265af2..fd66e45 100644 --- a/include/linux/hid-sensor-hub.h +++ b/include/linux/hid-sensor-hub.h @@ -40,6 +40,8 @@ struct hid_sensor_hub_attribute_info { s32 units; s32 unit_expo; s32 size; + s32 logical_minimum; + s32 logical_maximum; }; /**
Exporting logical minimum and maximum of HID fields as part of the hid sensor attribute info. This can be used for range checking and to calculate enumeration base for NAry fields of HID sensor hub. Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> --- drivers/hid/hid-sensor-hub.c | 20 ++++++++------------ include/linux/hid-sensor-hub.h | 2 ++ 2 files changed, 10 insertions(+), 12 deletions(-)