| Message ID | 1386001475-20728-1-git-send-email-broonie@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Dec 02, 2013 at 04:24:35PM +0000, Mark Brown wrote: > From: Mark Hambleton <mahamble@broadcom.com> > > Describe the virtio device so we can mount disk images in the simulator. > > Signed-off-by: Mark Hambleton <mahamble@broadcom.com> > Signed-off-by: Mark Brown <broonie@linaro.org> > --- > arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi b/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi > index b45e5f39f577..b3460961038f 100644 > --- a/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi > +++ b/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi > @@ -183,6 +183,12 @@ > clocks = <&v2m_oscclk1>, <&v2m_clk24mhz>; > clock-names = "clcdclk", "apb_pclk"; > }; > + > + virtio_block@0130000 { > + compatible = "virtio,mmio"; > + reg = <0x130000 0x1000>; 4k? That seems pretty big to me... > + interrupts = <0x2a>; Any reason this is in hex? Will
On Tue, Dec 03, 2013 at 11:42:18AM +0000, Will Deacon wrote: > On Mon, Dec 02, 2013 at 04:24:35PM +0000, Mark Brown wrote: > > + virtio_block@0130000 { > > + compatible = "virtio,mmio"; > > + reg = <0x130000 0x1000>; > 4k? That seems pretty big to me... Yeah, it looks like a page size to me though it does also seem like the sort of nice round number devices tend to offer. The binding document is depressingly silent on the topic of the size of the region but the only existing in tree user (the ARMv8 foundation model DTS) also picks the same number. > > + interrupts = <0x2a>; > Any reason this is in hex? That's what it was in Mark's original patch, easy enough to update.
Will, This patch comes from the ATF: https://github.com/ARM-software/arm-trusted-firmware/blob/master/fdts/rtsm_ve-motherboard.dtsi I suspect Achin Gupta has the answers to the questions... Mark -----Original Message----- From: Will Deacon [mailto:will.deacon@arm.com] Sent: 03 December 2013 11:42 To: Mark Brown Cc: Catalin Marinas; linaro-kernel@lists.linaro.org; Mark Hambleton; linux-arm-kernel@lists.infradead.org; Mark Brown; mark.rutland@arm.com Subject: Re: [PATCH] arm64: dts: Add a virtio disk to the RTSM motherboard On Mon, Dec 02, 2013 at 04:24:35PM +0000, Mark Brown wrote: > From: Mark Hambleton <mahamble@broadcom.com> > > Describe the virtio device so we can mount disk images in the simulator. > > Signed-off-by: Mark Hambleton <mahamble@broadcom.com> > Signed-off-by: Mark Brown <broonie@linaro.org> > --- > arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi b/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi > index b45e5f39f577..b3460961038f 100644 > --- a/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi > +++ b/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi > @@ -183,6 +183,12 @@ > clocks = <&v2m_oscclk1>, <&v2m_clk24mhz>; > clock-names = "clcdclk", "apb_pclk"; > }; > + > + virtio_block@0130000 { > + compatible = "virtio,mmio"; > + reg = <0x130000 0x1000>; 4k? That seems pretty big to me... > + interrupts = <0x2a>; Any reason this is in hex? Will
diff --git a/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi b/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi index b45e5f39f577..b3460961038f 100644 --- a/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi +++ b/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi @@ -183,6 +183,12 @@ clocks = <&v2m_oscclk1>, <&v2m_clk24mhz>; clock-names = "clcdclk", "apb_pclk"; }; + + virtio_block@0130000 { + compatible = "virtio,mmio"; + reg = <0x130000 0x1000>; + interrupts = <0x2a>; + }; }; v2m_fixed_3v3: fixedregulator@0 {