diff mbox

[1/2] arm: mmp: build sram driver alone

Message ID 1386140747-16043-1-git-send-email-zhouqiao@marvell.com (mailing list archive)
State Changes Requested
Delegated to: Dan Williams
Headers show

Commit Message

Qiao Zhou Dec. 4, 2013, 7:05 a.m. UTC
sram driver can be used by many chips besides CPU_MMP2, and so build
it alone.

Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
---
 arch/arm/mach-mmp/Kconfig  |    5 +++++
 arch/arm/mach-mmp/Makefile |    3 ++-
 2 files changed, 7 insertions(+), 1 deletions(-)

Comments

Dan Williams Dec. 4, 2013, 7:56 a.m. UTC | #1
On Tue, Dec 3, 2013 at 11:05 PM, Qiao Zhou <zhouqiao@marvell.com> wrote:
> sram driver can be used by many chips besides CPU_MMP2, and so build
> it alone.
>
> Reported-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
> ---
>  arch/arm/mach-mmp/Kconfig  |    5 +++++
>  arch/arm/mach-mmp/Makefile |    3 ++-
>  2 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
> index ebdda83..6a6597c 100644
> --- a/arch/arm/mach-mmp/Kconfig
> +++ b/arch/arm/mach-mmp/Kconfig
> @@ -136,4 +136,9 @@ config USB_EHCI_MV_U2O
>         help
>           Enables support for OTG controller which can be switched to host mode.
>
> +config MMP_SRAM
> +       bool
> +       help
> +         Select code specific to sram.
> +

No need for help text for something that is selected, and might as
well squash this with patch 2.
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Qiao Zhou Dec. 4, 2013, 8:01 a.m. UTC | #2
On 12/04/2013 03:56 PM, Dan Williams wrote:
> On Tue, Dec 3, 2013 at 11:05 PM, Qiao Zhou <zhouqiao@marvell.com> wrote:
>> sram driver can be used by many chips besides CPU_MMP2, and so build
>> it alone.
>>
>> Reported-by: Dan Williams <dan.j.williams@intel.com>
>> Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
>> ---
>>   arch/arm/mach-mmp/Kconfig  |    5 +++++
>>   arch/arm/mach-mmp/Makefile |    3 ++-
>>   2 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
>> index ebdda83..6a6597c 100644
>> --- a/arch/arm/mach-mmp/Kconfig
>> +++ b/arch/arm/mach-mmp/Kconfig
>> @@ -136,4 +136,9 @@ config USB_EHCI_MV_U2O
>>          help
>>            Enables support for OTG controller which can be switched to host mode.
>>
>> +config MMP_SRAM
>> +       bool
>> +       help
>> +         Select code specific to sram.
>> +
>
> No need for help text for something that is selected, and might as
> well squash this with patch 2.
>
Dan, thanks. I'll update it.
diff mbox

Patch

diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
index ebdda83..6a6597c 100644
--- a/arch/arm/mach-mmp/Kconfig
+++ b/arch/arm/mach-mmp/Kconfig
@@ -136,4 +136,9 @@  config USB_EHCI_MV_U2O
 	help
 	  Enables support for OTG controller which can be switched to host mode.
 
+config MMP_SRAM
+	bool
+	help
+	  Select code specific to sram.
+
 endif
diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
index 9b702a1..98f0f63 100644
--- a/arch/arm/mach-mmp/Makefile
+++ b/arch/arm/mach-mmp/Makefile
@@ -7,7 +7,8 @@  obj-y				+= common.o devices.o time.o
 # SoC support
 obj-$(CONFIG_CPU_PXA168)	+= pxa168.o
 obj-$(CONFIG_CPU_PXA910)	+= pxa910.o
-obj-$(CONFIG_CPU_MMP2)		+= mmp2.o sram.o
+obj-$(CONFIG_CPU_MMP2)		+= mmp2.o
+obj-$(CONFIG_MMP_SRAM)		+= sram.o
 
 ifeq ($(CONFIG_COMMON_CLK), )
 obj-y				+= clock.o