| Message ID | 1385480210-9349-2-git-send-email-shc_work@mail.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Nov 26, 2013 at 07:36:50PM +0400, Alexander Shiyan wrote: > This adds i.MX51 as the next user of the usbmisc driver. > Functionality is similar to i.MX53, so at this stage simply > reuse existing i.MX53 calls. > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > --- > drivers/usb/chipidea/usbmisc_imx.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c > index 4381c5a6..cd061ab 100644 > --- a/drivers/usb/chipidea/usbmisc_imx.c > +++ b/drivers/usb/chipidea/usbmisc_imx.c > @@ -204,6 +204,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] = { > .data = &imx27_usbmisc_ops, > }, > { > + .compatible = "fsl,imx51-usbmisc", > + .data = &imx53_usbmisc_ops, If it simply uses imx53 ops, why do we need to introduce a new compatible? Shawn > + }, > + { > .compatible = "fsl,imx53-usbmisc", > .data = &imx53_usbmisc_ops, > }, > -- > 1.8.3.2 >
Hello. > On Tue, Nov 26, 2013 at 07:36:50PM +0400, Alexander Shiyan wrote: > > This adds i.MX51 as the next user of the usbmisc driver. > > Functionality is similar to i.MX53, so at this stage simply > > reuse existing i.MX53 calls. > > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > > --- > > drivers/usb/chipidea/usbmisc_imx.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c > > index 4381c5a6..cd061ab 100644 > > --- a/drivers/usb/chipidea/usbmisc_imx.c > > +++ b/drivers/usb/chipidea/usbmisc_imx.c > > @@ -204,6 +204,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] = { > > .data = &imx27_usbmisc_ops, > > }, > > { > > + .compatible = "fsl,imx51-usbmisc", > > + .data = &imx53_usbmisc_ops, > > If it simply uses imx53 ops, why do we need to introduce a new > compatible? This has been discussed here: http://www.spinics.net/lists/linux-usb/msg97502.html Additionally, "fsl,imx51-usbmisc" string already present in imx51.dtsi. Thanks. ---
> This adds i.MX51 as the next user of the usbmisc driver. > Functionality is similar to i.MX53, so at this stage simply > reuse existing i.MX53 calls. > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > --- > drivers/usb/chipidea/usbmisc_imx.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/chipidea/usbmisc_imx.c > b/drivers/usb/chipidea/usbmisc_imx.c > index 4381c5a6..cd061ab 100644 > --- a/drivers/usb/chipidea/usbmisc_imx.c > +++ b/drivers/usb/chipidea/usbmisc_imx.c > @@ -204,6 +204,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] > = { > .data = &imx27_usbmisc_ops, > }, > { > + .compatible = "fsl,imx51-usbmisc", > + .data = &imx53_usbmisc_ops, > + }, > + { > .compatible = "fsl,imx53-usbmisc", > .data = &imx53_usbmisc_ops, > }, > -- Acked-by: Peter Chen <peter.chen@freescale.com> Peter
On Tue, Nov 26, 2013 at 07:36:50PM +0400, Alexander Shiyan wrote: > This adds i.MX51 as the next user of the usbmisc driver. > Functionality is similar to i.MX53, so at this stage simply > reuse existing i.MX53 calls. > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > --- > drivers/usb/chipidea/usbmisc_imx.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c > index 4381c5a6..cd061ab 100644 > --- a/drivers/usb/chipidea/usbmisc_imx.c > +++ b/drivers/usb/chipidea/usbmisc_imx.c > @@ -204,6 +204,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] = { > .data = &imx27_usbmisc_ops, > }, > { > + .compatible = "fsl,imx51-usbmisc", > + .data = &imx53_usbmisc_ops, > + }, > + { > .compatible = "fsl,imx53-usbmisc", > .data = &imx53_usbmisc_ops, > }, > -- > 1.8.3.2 > > Applied, thanks.
diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c index 4381c5a6..cd061ab 100644 --- a/drivers/usb/chipidea/usbmisc_imx.c +++ b/drivers/usb/chipidea/usbmisc_imx.c @@ -204,6 +204,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] = { .data = &imx27_usbmisc_ops, }, { + .compatible = "fsl,imx51-usbmisc", + .data = &imx53_usbmisc_ops, + }, + { .compatible = "fsl,imx53-usbmisc", .data = &imx53_usbmisc_ops, },
This adds i.MX51 as the next user of the usbmisc driver. Functionality is similar to i.MX53, so at this stage simply reuse existing i.MX53 calls. Signed-off-by: Alexander Shiyan <shc_work@mail.ru> --- drivers/usb/chipidea/usbmisc_imx.c | 4 ++++ 1 file changed, 4 insertions(+)