| Message ID | aeeefe3537089f0d0a2f8f5662d50dfca2aadf29.1386752447.git.mohit.kumar@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wednesday 11 December 2013, Mohit Kumar wrote: > From: Pratyush Anand <pratyush.anand@st.com> > > Follow dt clock naming convention for PCIe clocks. > I think in the future, the spear clocks really need to get moved into DT representations, as we do for other platforms, which will get rid of a lot of code in drivers/clk, including all the clkdev registration. Arnd
Hello Arnd, > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Thursday, December 12, 2013 4:13 AM > To: linux-arm-kernel@lists.infradead.org > Cc: Mohit KUMAR DCG; linux-pci@vger.kernel.org; Pratyush ANAND; spear- > devel; Viresh Kumar > Subject: Re: [PATCH 05/12] clk: SPEAr13xx: Fix pcie clock name > > On Wednesday 11 December 2013, Mohit Kumar wrote: > > From: Pratyush Anand <pratyush.anand@st.com> > > > > Follow dt clock naming convention for PCIe clocks. > > > > I think in the future, the spear clocks really need to get moved into DT > representations, as we do for other platforms, which will get rid of a lot of > code in drivers/clk, including all the clkdev registration. - Let it be this way for now. May be we will improve it in next cycle. Thanks Mohit
On Thursday 12 December 2013, Mohit KUMAR DCG wrote: > > > > I think in the future, the spear clocks really need to get moved into DT > > representations, as we do for other platforms, which will get rid of a lot of > > code in drivers/clk, including all the clkdev registration. > > - Let it be this way for now. May be we will improve it in next cycle Fair enough. This will be a major change that doesn't have to delay the PCIe driver, just make sure you can address the other comments I made for now. The clock situation will have to be worked out though before the bindings can be considered stable, because you will have to add mandatory 'clocks' properties to a lot of them. Arnd
diff --git a/drivers/clk/spear/spear1310_clock.c b/drivers/clk/spear/spear1310_clock.c index 65894f7..4daa597 100644 --- a/drivers/clk/spear/spear1310_clock.c +++ b/drivers/clk/spear/spear1310_clock.c @@ -742,19 +742,19 @@ void __init spear1310_clk_init(void __iomem *misc_base, void __iomem *ras_base) clk = clk_register_gate(NULL, "pcie_sata_0_clk", "ahb_clk", 0, SPEAR1310_PERIP1_CLK_ENB, SPEAR1310_PCIE_SATA_0_CLK_ENB, 0, &_lock); - clk_register_clkdev(clk, NULL, "dw_pcie.0"); + clk_register_clkdev(clk, NULL, "b1000000.pcie"); clk_register_clkdev(clk, NULL, "b1000000.ahci"); clk = clk_register_gate(NULL, "pcie_sata_1_clk", "ahb_clk", 0, SPEAR1310_PERIP1_CLK_ENB, SPEAR1310_PCIE_SATA_1_CLK_ENB, 0, &_lock); - clk_register_clkdev(clk, NULL, "dw_pcie.1"); + clk_register_clkdev(clk, NULL, "b1800000.pcie"); clk_register_clkdev(clk, NULL, "b1800000.ahci"); clk = clk_register_gate(NULL, "pcie_sata_2_clk", "ahb_clk", 0, SPEAR1310_PERIP1_CLK_ENB, SPEAR1310_PCIE_SATA_2_CLK_ENB, 0, &_lock); - clk_register_clkdev(clk, NULL, "dw_pcie.2"); + clk_register_clkdev(clk, NULL, "b4000000.pcie"); clk_register_clkdev(clk, NULL, "b4000000.ahci"); clk = clk_register_gate(NULL, "sysram0_clk", "ahb_clk", 0, diff --git a/drivers/clk/spear/spear1340_clock.c b/drivers/clk/spear/spear1340_clock.c index fe835c1..5a5c664 100644 --- a/drivers/clk/spear/spear1340_clock.c +++ b/drivers/clk/spear/spear1340_clock.c @@ -839,7 +839,7 @@ void __init spear1340_clk_init(void __iomem *misc_base) clk = clk_register_gate(NULL, "pcie_sata_clk", "ahb_clk", 0, SPEAR1340_PERIP1_CLK_ENB, SPEAR1340_PCIE_SATA_CLK_ENB, 0, &_lock); - clk_register_clkdev(clk, NULL, "dw_pcie"); + clk_register_clkdev(clk, NULL, "b1000000.pcie"); clk_register_clkdev(clk, NULL, "b1000000.ahci"); clk = clk_register_gate(NULL, "sysram0_clk", "ahb_clk", 0,