| Message ID | 1386897825-6130-2-git-send-email-peter.chen@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, Peter Chen wrote: > Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add > "fsl,imx6sl-usbphy" for imx6sl. > > Signed-off-by: Peter Chen <peter.chen@freescale.com> > --- > Documentation/devicetree/bindings/usb/mxs-phy.txt | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt > index 5835b27..d850e55 100644 > --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt > +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt > @@ -1,7 +1,8 @@ > * Freescale MXS USB Phy Device > > Required properties: > -- compatible: Should be "fsl,imx23-usbphy" > +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q-usbphy" > +for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl > indentation? Lothar Waßmann
On Fri, Dec 13, 2013 at 3:15 PM, Lothar Waßmann <LW@karo-electronics.de> wrote: > Hi, > > Peter Chen wrote: >> Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add >> "fsl,imx6sl-usbphy" for imx6sl. >> >> Signed-off-by: Peter Chen <peter.chen@freescale.com> >> --- >> Documentation/devicetree/bindings/usb/mxs-phy.txt | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt >> index 5835b27..d850e55 100644 >> --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt >> +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt >> @@ -1,7 +1,8 @@ >> * Freescale MXS USB Phy Device >> >> Required properties: >> -- compatible: Should be "fsl,imx23-usbphy" >> +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q-usbphy" >> +for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl >> > indentation? > How many characters? 2 or 8? BR, Peter Chen
Hi, Peter Chen wrote: > On Fri, Dec 13, 2013 at 3:15 PM, Lothar Waßmann <LW@karo-electronics.de> wrote: > > Hi, > > > > Peter Chen wrote: > >> Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add > >> "fsl,imx6sl-usbphy" for imx6sl. > >> > >> Signed-off-by: Peter Chen <peter.chen@freescale.com> > >> --- > >> Documentation/devicetree/bindings/usb/mxs-phy.txt | 3 ++- > >> 1 files changed, 2 insertions(+), 1 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt > >> index 5835b27..d850e55 100644 > >> --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt > >> +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt > >> @@ -1,7 +1,8 @@ > >> * Freescale MXS USB Phy Device > >> > >> Required properties: > >> -- compatible: Should be "fsl,imx23-usbphy" > >> +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q-usbphy" > >> +for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl > >> > > indentation? > > > > How many characters? 2 or 8? > I would align the line with the first character in the previous line: - compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q-usbphy" for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl Lothar Waßmann
On Fri, Dec 13, 2013 at 3:38 PM, Lothar Waßmann <LW@karo-electronics.de> wrote: > Hi, > > Peter Chen wrote: >> On Fri, Dec 13, 2013 at 3:15 PM, Lothar Waßmann <LW@karo-electronics.de> wrote: >> > Hi, >> > >> > Peter Chen wrote: >> >> Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add >> >> "fsl,imx6sl-usbphy" for imx6sl. >> >> >> >> Signed-off-by: Peter Chen <peter.chen@freescale.com> >> >> --- >> >> Documentation/devicetree/bindings/usb/mxs-phy.txt | 3 ++- >> >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> >> >> diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt >> >> index 5835b27..d850e55 100644 >> >> --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt >> >> +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt >> >> @@ -1,7 +1,8 @@ >> >> * Freescale MXS USB Phy Device >> >> >> >> Required properties: >> >> -- compatible: Should be "fsl,imx23-usbphy" >> >> +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q-usbphy" >> >> +for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl >> >> >> > indentation? >> > >> >> How many characters? 2 or 8? >> > I would align the line with the first character in the previous line: > - compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q-usbphy" > for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl > Thanks, will change.
diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt index 5835b27..d850e55 100644 --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt @@ -1,7 +1,8 @@ * Freescale MXS USB Phy Device Required properties: -- compatible: Should be "fsl,imx23-usbphy" +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q-usbphy" +for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl - reg: Should contain registers location and length - interrupts: Should contain phy interrupt
Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add "fsl,imx6sl-usbphy" for imx6sl. Signed-off-by: Peter Chen <peter.chen@freescale.com> --- Documentation/devicetree/bindings/usb/mxs-phy.txt | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)