| Message ID | 1386943578-9962-1-git-send-email-ezequiel.garcia@free-electrons.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0e772c672686 |
| Delegated to: | Vinod Koul |
| Headers | show |
On Fri, Dec 13, 2013 at 6:06 AM, Ezequiel Garcia <ezequiel.garcia@free-electrons.com> wrote: > The channel allocated/released messages are very spammy and not really > interesting to users. Change them to "debug" level. > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > --- > Not sure if it's a valid reason, but I've hit this spam when a driver > re-tries to probe after a EPROBE_DEFER error condition. > Yes, it's a valid reason. We should not be spamming the logs with these kinds of messages. In general driver announce messages are discouraged. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 13, 2013 at 11:06:18AM -0300, Ezequiel Garcia wrote: > The channel allocated/released messages are very spammy and not really > interesting to users. Change them to "debug" level. > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > --- > Not sure if it's a valid reason, but I've hit this spam when a driver > re-tries to probe after a EPROBE_DEFER error condition. > > Matt, what do you say? Feel free to NACK this if you insist in seeing > this messages. Yes, I agree we need to be rid of this spam. Thanks. Acked-by: Matt Porter <mporter@linaro.org> > drivers/dma/edma.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c > index 2539ea0..cd8da45 100644 > --- a/drivers/dma/edma.c > +++ b/drivers/dma/edma.c > @@ -699,8 +699,8 @@ static int edma_alloc_chan_resources(struct dma_chan *chan) > echan->alloced = true; > echan->slot[0] = echan->ch_num; > > - dev_info(dev, "allocated channel for %u:%u\n", > - EDMA_CTLR(echan->ch_num), EDMA_CHAN_SLOT(echan->ch_num)); > + dev_dbg(dev, "allocated channel for %u:%u\n", > + EDMA_CTLR(echan->ch_num), EDMA_CHAN_SLOT(echan->ch_num)); > > return 0; > > @@ -736,7 +736,7 @@ static void edma_free_chan_resources(struct dma_chan *chan) > echan->alloced = false; > } > > - dev_info(dev, "freeing channel for %u\n", echan->ch_num); > + dev_dbg(dev, "freeing channel for %u\n", echan->ch_num); > } > > /* Send pending descriptor to hardware */ > -- > 1.8.1.5 > -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 13, 2013 at 11:06:18AM -0300, Ezequiel Garcia wrote: > The channel allocated/released messages are very spammy and not really > interesting to users. Change them to "debug" level. > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> Applied, thanks -- ~Vinod > --- > Not sure if it's a valid reason, but I've hit this spam when a driver > re-tries to probe after a EPROBE_DEFER error condition. > > Matt, what do you say? Feel free to NACK this if you insist in seeing > this messages. > > drivers/dma/edma.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c > index 2539ea0..cd8da45 100644 > --- a/drivers/dma/edma.c > +++ b/drivers/dma/edma.c > @@ -699,8 +699,8 @@ static int edma_alloc_chan_resources(struct dma_chan *chan) > echan->alloced = true; > echan->slot[0] = echan->ch_num; > > - dev_info(dev, "allocated channel for %u:%u\n", > - EDMA_CTLR(echan->ch_num), EDMA_CHAN_SLOT(echan->ch_num)); > + dev_dbg(dev, "allocated channel for %u:%u\n", > + EDMA_CTLR(echan->ch_num), EDMA_CHAN_SLOT(echan->ch_num)); > > return 0; > > @@ -736,7 +736,7 @@ static void edma_free_chan_resources(struct dma_chan *chan) > echan->alloced = false; > } > > - dev_info(dev, "freeing channel for %u\n", echan->ch_num); > + dev_dbg(dev, "freeing channel for %u\n", echan->ch_num); > } > > /* Send pending descriptor to hardware */ > -- > 1.8.1.5 >
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 2539ea0..cd8da45 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c @@ -699,8 +699,8 @@ static int edma_alloc_chan_resources(struct dma_chan *chan) echan->alloced = true; echan->slot[0] = echan->ch_num; - dev_info(dev, "allocated channel for %u:%u\n", - EDMA_CTLR(echan->ch_num), EDMA_CHAN_SLOT(echan->ch_num)); + dev_dbg(dev, "allocated channel for %u:%u\n", + EDMA_CTLR(echan->ch_num), EDMA_CHAN_SLOT(echan->ch_num)); return 0; @@ -736,7 +736,7 @@ static void edma_free_chan_resources(struct dma_chan *chan) echan->alloced = false; } - dev_info(dev, "freeing channel for %u\n", echan->ch_num); + dev_dbg(dev, "freeing channel for %u\n", echan->ch_num); } /* Send pending descriptor to hardware */
The channel allocated/released messages are very spammy and not really interesting to users. Change them to "debug" level. Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> --- Not sure if it's a valid reason, but I've hit this spam when a driver re-tries to probe after a EPROBE_DEFER error condition. Matt, what do you say? Feel free to NACK this if you insist in seeing this messages. drivers/dma/edma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)