| Message ID | 1383905648-23733-2-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sachin, Andrew, On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote: > From: Andrew Bresticker <abrestic@chromium.org> > > The gate clocks for the MFC sysmmus appear to be flipped, i.e. > GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. > Fix this so that the MFC will start up. Wow, this means that there is a mistake in the documentation. Not that I'm surprised, though. I guess you are sure about this, so: Reviewed-by: Tomasz Figa <t.figa@samsung.com> Best regards, Tomasz
Hi Tomasz, On 10 November 2013 22:38, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi Sachin, Andrew, > > On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote: >> From: Andrew Bresticker <abrestic@chromium.org> >> >> The gate clocks for the MFC sysmmus appear to be flipped, i.e. >> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. >> Fix this so that the MFC will start up. > > Wow, this means that there is a mistake in the documentation. Not that > I'm surprised, though. Yes, there is a mistake in the TRM in this case. > > I guess you are sure about this, so: > > Reviewed-by: Tomasz Figa <t.figa@samsung.com> Thanks.
Hi Tomasz, On 10 November 2013 22:38, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi Sachin, Andrew, > > On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote: >> From: Andrew Bresticker <abrestic@chromium.org> >> >> The gate clocks for the MFC sysmmus appear to be flipped, i.e. >> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. >> Fix this so that the MFC will start up. > > Wow, this means that there is a mistake in the documentation. Not that > I'm surprised, though. > > I guess you are sure about this, so: > > Reviewed-by: Tomasz Figa <t.figa@samsung.com> I believe you are going to take this through your tree along with a few others which you have already reviewed?
Hi Sachin, 2013/12/18 Sachin Kamat <sachin.kamat@linaro.org>: > Hi Tomasz, > > On 10 November 2013 22:38, Tomasz Figa <tomasz.figa@gmail.com> wrote: >> Hi Sachin, Andrew, >> >> On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote: >>> From: Andrew Bresticker <abrestic@chromium.org> >>> >>> The gate clocks for the MFC sysmmus appear to be flipped, i.e. >>> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. >>> Fix this so that the MFC will start up. >> >> Wow, this means that there is a mistake in the documentation. Not that >> I'm surprised, though. >> >> I guess you are sure about this, so: >> >> Reviewed-by: Tomasz Figa <t.figa@samsung.com> > > I believe you are going to take this through your tree along with a > few others which you have already reviewed? Thanks for reminding me about this patch. It's been quite a while since it was posted to the list. Yes, I will apply it to samsung-clk tree. Best regards, Tomasz
Quoting Tomasz Figa (2013-12-18 10:28:57) > Hi Sachin, > > 2013/12/18 Sachin Kamat <sachin.kamat@linaro.org>: > > Hi Tomasz, > > > > On 10 November 2013 22:38, Tomasz Figa <tomasz.figa@gmail.com> wrote: > >> Hi Sachin, Andrew, > >> > >> On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote: > >>> From: Andrew Bresticker <abrestic@chromium.org> > >>> > >>> The gate clocks for the MFC sysmmus appear to be flipped, i.e. > >>> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. > >>> Fix this so that the MFC will start up. > >> > >> Wow, this means that there is a mistake in the documentation. Not that > >> I'm surprised, though. > >> > >> I guess you are sure about this, so: > >> > >> Reviewed-by: Tomasz Figa <t.figa@samsung.com> > > > > I believe you are going to take this through your tree along with a > > few others which you have already reviewed? > > Thanks for reminding me about this patch. It's been quite a while > since it was posted > to the list. > > Yes, I will apply it to samsung-clk tree. Feel free to add my Ack when you apply it. Will these be sent later as a pull request for the clk tree? Regards, Mike > > Best regards, > Tomasz
On Wednesday 18 of December 2013 11:24:30 Mike Turquette wrote: > Quoting Tomasz Figa (2013-12-18 10:28:57) > > Hi Sachin, > > > > 2013/12/18 Sachin Kamat <sachin.kamat@linaro.org>: > > > Hi Tomasz, > > > > > > On 10 November 2013 22:38, Tomasz Figa <tomasz.figa@gmail.com> wrote: > > >> Hi Sachin, Andrew, > > >> > > >> On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote: > > >>> From: Andrew Bresticker <abrestic@chromium.org> > > >>> > > >>> The gate clocks for the MFC sysmmus appear to be flipped, i.e. > > >>> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. > > >>> Fix this so that the MFC will start up. > > >> > > >> Wow, this means that there is a mistake in the documentation. Not that > > >> I'm surprised, though. > > >> > > >> I guess you are sure about this, so: > > >> > > >> Reviewed-by: Tomasz Figa <t.figa@samsung.com> > > > > > > I believe you are going to take this through your tree along with a > > > few others which you have already reviewed? > > > > Thanks for reminding me about this patch. It's been quite a while > > since it was posted > > to the list. > > > > Yes, I will apply it to samsung-clk tree. > > Feel free to add my Ack when you apply it. Will these be sent later as a > pull request for the clk tree? Yes. That's the plan. :) Best regards, Tomasz
Hi Sachin, Andrew, On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote: > Hi Tomasz, > > On 10 November 2013 22:38, Tomasz Figa <tomasz.figa@gmail.com> wrote: > > Hi Sachin, Andrew, > > > > On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote: > >> From: Andrew Bresticker <abrestic@chromium.org> > >> > >> The gate clocks for the MFC sysmmus appear to be flipped, i.e. > >> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. > >> Fix this so that the MFC will start up. > > > > Wow, this means that there is a mistake in the documentation. Not that > > I'm surprised, though. > > > > I guess you are sure about this, so: > > > > Reviewed-by: Tomasz Figa <t.figa@samsung.com> > > I believe you are going to take this through your tree along with a > few others which you have already reviewed? This patch seems to depend on my Exynos 5250 clock clean-up series, which will be merged for 3.14. Are you okay with this patch being merged for 3.14 as well or this fix is needed for earlier kernel versions too? (It is not a regression introduced in 3.13, though.) Best regards, Tomasz
Hi Tomasz, On 19 December 2013 19:40, Tomasz Figa <t.figa@samsung.com> wrote: > Hi Sachin, Andrew, > > On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote: >> Hi Tomasz, >> >> On 10 November 2013 22:38, Tomasz Figa <tomasz.figa@gmail.com> wrote: >> > Hi Sachin, Andrew, >> > >> > On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote: >> >> From: Andrew Bresticker <abrestic@chromium.org> >> >> >> >> The gate clocks for the MFC sysmmus appear to be flipped, i.e. >> >> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr. >> >> Fix this so that the MFC will start up. >> > >> > Wow, this means that there is a mistake in the documentation. Not that >> > I'm surprised, though. >> > >> > I guess you are sure about this, so: >> > >> > Reviewed-by: Tomasz Figa <t.figa@samsung.com> >> >> I believe you are going to take this through your tree along with a >> few others which you have already reviewed? > > This patch seems to depend on my Exynos 5250 clock clean-up series, which > will be merged for 3.14. Are you okay with this patch being merged for > 3.14 as well or this fix is needed for earlier kernel versions too? > (It is not a regression introduced in 3.13, though.) Yes, I did rebase it on top of your series along with other patches. Though not a regression introduced in 3.13, I think it makes sense to have this sent as a fix during this release (3.13) itself. Let me know if you want me to base it on top of 3.13-rc4 and re-send.
diff --git a/drivers/clk/samsung/clk-exynos5250.c b/drivers/clk/samsung/clk-exynos5250.c index 6767635dc895..986464c2339a 100644 --- a/drivers/clk/samsung/clk-exynos5250.c +++ b/drivers/clk/samsung/clk-exynos5250.c @@ -562,8 +562,8 @@ static struct samsung_gate_clock exynos5250_gate_clks[] __initdata = { GATE(hdmi, "hdmi", "mout_aclk200_disp1_sub", GATE_IP_DISP1, 6, 0, 0), GATE(mfc, "mfc", "mout_aclk333_sub", GATE_IP_MFC, 0, 0, 0), - GATE(smmu_mfcl, "smmu_mfcl", "mout_aclk333_sub", GATE_IP_MFC, 1, 0, 0), - GATE(smmu_mfcr, "smmu_mfcr", "mout_aclk333_sub", GATE_IP_MFC, 2, 0, 0), + GATE(smmu_mfcl, "smmu_mfcl", "mout_aclk333_sub", GATE_IP_MFC, 2, 0, 0), + GATE(smmu_mfcr, "smmu_mfcr", "mout_aclk333_sub", GATE_IP_MFC, 1, 0, 0), GATE(rotator, "rotator", "div_aclk266", GATE_IP_GEN, 1, 0, 0), GATE(jpeg, "jpeg", "div_aclk166", GATE_IP_GEN, 2, 0, 0),