| Message ID | 1387284818-28739-7-git-send-email-florian.vaussard@epfl.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Florian, On 12/17/2013 06:53 AM, Florian Vaussard wrote: > The data are now passed using the devicetree. Patch is good by itself. A similar change is needed for the IVA MMU as well. regards Suman > > Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> > --- > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > index 0477131..6dccd46 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > @@ -2469,15 +2469,8 @@ static struct omap_hwmod_class omap3xxx_mmu_hwmod_class = { > > /* mmu isp */ > > -static struct omap_mmu_dev_attr mmu_isp_dev_attr = { > - .da_start = 0x0, > - .da_end = 0xfffff000, > - .nr_tlb_entries = 8, > -}; > - > static struct omap_hwmod omap3xxx_mmu_isp_hwmod; > > - > /* l4_core -> mmu isp */ > static struct omap_hwmod_ocp_if omap3xxx_l4_core__mmu_isp = { > .master = &omap3xxx_l4_core_hwmod, > @@ -2489,7 +2482,6 @@ static struct omap_hwmod omap3xxx_mmu_isp_hwmod = { > .name = "mmu_isp", > .class = &omap3xxx_mmu_hwmod_class, > .main_clk = "cam_ick", > - .dev_attr = &mmu_isp_dev_attr, > .flags = HWMOD_NO_IDLEST, > }; > >
Hi Suman, On 12/23/2013 08:08 PM, Anna, Suman wrote: > Hi Florian, > > On 12/17/2013 06:53 AM, Florian Vaussard wrote: >> The data are now passed using the devicetree. > > Patch is good by itself. A similar change is needed for the IVA > MMU as well. > As I understood, the IVA MMU is still not integrated into the iommu core, as its implementation lives under staging/tidspbridge/. But correct me if I am wrong. Regards, Florian
Hi Florian, >> >> On 12/17/2013 06:53 AM, Florian Vaussard wrote: >>> The data are now passed using the devicetree. >> >> Patch is good by itself. A similar change is needed for the IVA >> MMU as well. >> > > As I understood, the IVA MMU is still not integrated into the iommu > core, as its implementation lives under staging/tidspbridge/. But > correct me if I am wrong. > Yes, that is correct. That shouldn't stop us though from adding the IVA MMU node to the DT file and the associated cleanup. To begin with, we can have the DT node added with status=disabled. regards Suman
diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c index 0477131..6dccd46 100644 --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c @@ -2469,15 +2469,8 @@ static struct omap_hwmod_class omap3xxx_mmu_hwmod_class = { /* mmu isp */ -static struct omap_mmu_dev_attr mmu_isp_dev_attr = { - .da_start = 0x0, - .da_end = 0xfffff000, - .nr_tlb_entries = 8, -}; - static struct omap_hwmod omap3xxx_mmu_isp_hwmod; - /* l4_core -> mmu isp */ static struct omap_hwmod_ocp_if omap3xxx_l4_core__mmu_isp = { .master = &omap3xxx_l4_core_hwmod, @@ -2489,7 +2482,6 @@ static struct omap_hwmod omap3xxx_mmu_isp_hwmod = { .name = "mmu_isp", .class = &omap3xxx_mmu_hwmod_class, .main_clk = "cam_ick", - .dev_attr = &mmu_isp_dev_attr, .flags = HWMOD_NO_IDLEST, };
The data are now passed using the devicetree. Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch> --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 8 -------- 1 file changed, 8 deletions(-)