[2/3] clk: exynos5250: fix sysmmu_mfc{l,r} gate clocks

Commit Message

Sachin Kamat Nov. 8, 2013, 10:14 a.m. UTC

From: Andrew Bresticker <[e-mail]>

The gate clocks for the MFC sysmmus appear to be flipped, i.e.
GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
Fix this so that the MFC will start up.

Signed-off-by: Andrew Bresticker <[e-mail]>
Signed-off-by: Sachin Kamat <[e-mail]>
---
 drivers/clk/samsung/clk-exynos5250.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tomasz Figa Nov. 10, 2013, 5:08 p.m. UTC | #1

Hi Sachin, Andrew,

On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
> From: Andrew Bresticker <[e-mail]>
> 
> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
> Fix this so that the MFC will start up.

Wow, this means that there is a mistake in the documentation. Not that
I'm surprised, though.

I guess you are sure about this, so:

Reviewed-by: Tomasz Figa <[e-mail]>

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Sachin Kamat Nov. 11, 2013, 3:11 a.m. UTC | #2

Hi Tomasz,

On 10 November 2013 22:38, Tomasz Figa <[e-mail]> wrote:
> Hi Sachin, Andrew,
>
> On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
>> From: Andrew Bresticker <[e-mail]>
>>
>> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
>> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
>> Fix this so that the MFC will start up.
>
> Wow, this means that there is a mistake in the documentation. Not that
> I'm surprised, though.

Yes, there is a mistake in the TRM in this case.

>
> I guess you are sure about this, so:
>
> Reviewed-by: Tomasz Figa <[e-mail]>

Thanks.

Sachin Kamat Dec. 18, 2013, 6:09 p.m. UTC | #3

Hi Tomasz,

On 10 November 2013 22:38, Tomasz Figa <[e-mail]> wrote:
> Hi Sachin, Andrew,
>
> On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
>> From: Andrew Bresticker <[e-mail]>
>>
>> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
>> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
>> Fix this so that the MFC will start up.
>
> Wow, this means that there is a mistake in the documentation. Not that
> I'm surprised, though.
>
> I guess you are sure about this, so:
>
> Reviewed-by: Tomasz Figa <[e-mail]>

I believe you are going to take this through your tree along with a
few others which you have already reviewed?

Tomasz Figa Dec. 18, 2013, 6:28 p.m. UTC | #4

Hi Sachin,

2013/12/18 Sachin Kamat <[e-mail]>:
> Hi Tomasz,
>
> On 10 November 2013 22:38, Tomasz Figa <[e-mail]> wrote:
>> Hi Sachin, Andrew,
>>
>> On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
>>> From: Andrew Bresticker <[e-mail]>
>>>
>>> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
>>> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
>>> Fix this so that the MFC will start up.
>>
>> Wow, this means that there is a mistake in the documentation. Not that
>> I'm surprised, though.
>>
>> I guess you are sure about this, so:
>>
>> Reviewed-by: Tomasz Figa <[e-mail]>
>
> I believe you are going to take this through your tree along with a
> few others which you have already reviewed?

Thanks for reminding me about this patch. It's been quite a while
since it was posted
to the list.

Yes, I will apply it to samsung-clk tree.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Mike Turquette Dec. 18, 2013, 7:24 p.m. UTC | #5

Quoting Tomasz Figa (2013-12-18 10:28:57)
> Hi Sachin,
> 
> 2013/12/18 Sachin Kamat <[e-mail]>:
> > Hi Tomasz,
> >
> > On 10 November 2013 22:38, Tomasz Figa <[e-mail]> wrote:
> >> Hi Sachin, Andrew,
> >>
> >> On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
> >>> From: Andrew Bresticker <[e-mail]>
> >>>
> >>> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
> >>> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
> >>> Fix this so that the MFC will start up.
> >>
> >> Wow, this means that there is a mistake in the documentation. Not that
> >> I'm surprised, though.
> >>
> >> I guess you are sure about this, so:
> >>
> >> Reviewed-by: Tomasz Figa <[e-mail]>
> >
> > I believe you are going to take this through your tree along with a
> > few others which you have already reviewed?
> 
> Thanks for reminding me about this patch. It's been quite a while
> since it was posted
> to the list.
> 
> Yes, I will apply it to samsung-clk tree.

Feel free to add my Ack when you apply it. Will these be sent later as a
pull request for the clk tree?

Regards,
Mike

> 
> Best regards,
> Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Tomasz Figa Dec. 19, 2013, 12:36 a.m. UTC | #6

On Wednesday 18 of December 2013 11:24:30 Mike Turquette wrote:
> Quoting Tomasz Figa (2013-12-18 10:28:57)
> > Hi Sachin,
> > 
> > 2013/12/18 Sachin Kamat <[e-mail]>:
> > > Hi Tomasz,
> > >
> > > On 10 November 2013 22:38, Tomasz Figa <[e-mail]> wrote:
> > >> Hi Sachin, Andrew,
> > >>
> > >> On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
> > >>> From: Andrew Bresticker <[e-mail]>
> > >>>
> > >>> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
> > >>> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
> > >>> Fix this so that the MFC will start up.
> > >>
> > >> Wow, this means that there is a mistake in the documentation. Not that
> > >> I'm surprised, though.
> > >>
> > >> I guess you are sure about this, so:
> > >>
> > >> Reviewed-by: Tomasz Figa <[e-mail]>
> > >
> > > I believe you are going to take this through your tree along with a
> > > few others which you have already reviewed?
> > 
> > Thanks for reminding me about this patch. It's been quite a while
> > since it was posted
> > to the list.
> > 
> > Yes, I will apply it to samsung-clk tree.
> 
> Feel free to add my Ack when you apply it. Will these be sent later as a
> pull request for the clk tree?

Yes. That's the plan. :)

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Tomasz Figa Dec. 19, 2013, 2:10 p.m. UTC | #7

Hi Sachin, Andrew,

On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:
> Hi Tomasz,
> 
> On 10 November 2013 22:38, Tomasz Figa <[e-mail]> wrote:
> > Hi Sachin, Andrew,
> >
> > On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
> >> From: Andrew Bresticker <[e-mail]>
> >>
> >> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
> >> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
> >> Fix this so that the MFC will start up.
> >
> > Wow, this means that there is a mistake in the documentation. Not that
> > I'm surprised, though.
> >
> > I guess you are sure about this, so:
> >
> > Reviewed-by: Tomasz Figa <[e-mail]>
> 
> I believe you are going to take this through your tree along with a
> few others which you have already reviewed?

This patch seems to depend on my Exynos 5250 clock clean-up series, which
will be merged for 3.14. Are you okay with this patch being merged for
3.14 as well or this fix is needed for earlier kernel versions too?
(It is not a regression introduced in 3.13, though.)

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Sachin Kamat Dec. 19, 2013, 3:35 p.m. UTC | #8

Hi Tomasz,

On 19 December 2013 19:40, Tomasz Figa <[e-mail]> wrote:
> Hi Sachin, Andrew,
>
> On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:
>> Hi Tomasz,
>>
>> On 10 November 2013 22:38, Tomasz Figa <[e-mail]> wrote:
>> > Hi Sachin, Andrew,
>> >
>> > On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
>> >> From: Andrew Bresticker <[e-mail]>
>> >>
>> >> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
>> >> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
>> >> Fix this so that the MFC will start up.
>> >
>> > Wow, this means that there is a mistake in the documentation. Not that
>> > I'm surprised, though.
>> >
>> > I guess you are sure about this, so:
>> >
>> > Reviewed-by: Tomasz Figa <[e-mail]>
>>
>> I believe you are going to take this through your tree along with a
>> few others which you have already reviewed?
>
> This patch seems to depend on my Exynos 5250 clock clean-up series, which
> will be merged for 3.14. Are you okay with this patch being merged for
> 3.14 as well or this fix is needed for earlier kernel versions too?
> (It is not a regression introduced in 3.13, though.)

Yes, I did rebase it on top of your series along with other patches.
Though not a regression introduced in 3.13, I think it makes sense to have this
sent as a fix during this release (3.13) itself. Let me know if you
want me to base it
on top of 3.13-rc4 and re-send.

Tomasz Figa Dec. 20, 2013, 9:14 p.m. UTC | #9

On Thursday 19 of December 2013 21:05:09 Sachin Kamat wrote:
> Hi Tomasz,
> 
> On 19 December 2013 19:40, Tomasz Figa <[e-mail]> wrote:
> > Hi Sachin, Andrew,
> >
> > On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:
> >> Hi Tomasz,
> >>
> >> On 10 November 2013 22:38, Tomasz Figa <[e-mail]> wrote:
> >> > Hi Sachin, Andrew,
> >> >
> >> > On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
> >> >> From: Andrew Bresticker <[e-mail]>
> >> >>
> >> >> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
> >> >> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
> >> >> Fix this so that the MFC will start up.
> >> >
> >> > Wow, this means that there is a mistake in the documentation. Not that
> >> > I'm surprised, though.
> >> >
> >> > I guess you are sure about this, so:
> >> >
> >> > Reviewed-by: Tomasz Figa <[e-mail]>
> >>
> >> I believe you are going to take this through your tree along with a
> >> few others which you have already reviewed?
> >
> > This patch seems to depend on my Exynos 5250 clock clean-up series, which
> > will be merged for 3.14. Are you okay with this patch being merged for
> > 3.14 as well or this fix is needed for earlier kernel versions too?
> > (It is not a regression introduced in 3.13, though.)
> 
> Yes, I did rebase it on top of your series along with other patches.
> Though not a regression introduced in 3.13, I think it makes sense to have this
> sent as a fix during this release (3.13) itself. Let me know if you
> want me to base it
> on top of 3.13-rc4 and re-send.

Since this is just a trivial fix, let me do it myself when applying.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Sachin Kamat Dec. 21, 2013, 4:07 a.m. UTC | #10

On 21 December 2013 02:44, Tomasz Figa <[e-mail]> wrote:
> On Thursday 19 of December 2013 21:05:09 Sachin Kamat wrote:
>> Hi Tomasz,
>>
>> On 19 December 2013 19:40, Tomasz Figa <[e-mail]> wrote:
>> > Hi Sachin, Andrew,
>> >
>> > On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:
>> >> Hi Tomasz,
>> >>
>> >> On 10 November 2013 22:38, Tomasz Figa <[e-mail]> wrote:
>> >> > Hi Sachin, Andrew,
>> >> >
>> >> > On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
>> >> >> From: Andrew Bresticker <[e-mail]>
>> >> >>
>> >> >> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
>> >> >> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
>> >> >> Fix this so that the MFC will start up.
>> >> >
>> >> > Wow, this means that there is a mistake in the documentation. Not that
>> >> > I'm surprised, though.
>> >> >
>> >> > I guess you are sure about this, so:
>> >> >
>> >> > Reviewed-by: Tomasz Figa <[e-mail]>
>> >>
>> >> I believe you are going to take this through your tree along with a
>> >> few others which you have already reviewed?
>> >
>> > This patch seems to depend on my Exynos 5250 clock clean-up series, which
>> > will be merged for 3.14. Are you okay with this patch being merged for
>> > 3.14 as well or this fix is needed for earlier kernel versions too?
>> > (It is not a regression introduced in 3.13, though.)
>>
>> Yes, I did rebase it on top of your series along with other patches.
>> Though not a regression introduced in 3.13, I think it makes sense to have this
>> sent as a fix during this release (3.13) itself. Let me know if you
>> want me to base it
>> on top of 3.13-rc4 and re-send.
>
> Since this is just a trivial fix, let me do it myself when applying.
>

Thanks Tomasz.

Tomasz Figa Dec. 30, 2013, 5:52 p.m. UTC | #11

On Saturday 21 of December 2013 09:37:06 Sachin Kamat wrote:
> On 21 December 2013 02:44, Tomasz Figa <[e-mail]> wrote:
> > On Thursday 19 of December 2013 21:05:09 Sachin Kamat wrote:
> >> Hi Tomasz,
> >>
> >> On 19 December 2013 19:40, Tomasz Figa <[e-mail]> wrote:
> >> > Hi Sachin, Andrew,
> >> >
> >> > On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:
> >> >> Hi Tomasz,
> >> >>
> >> >> On 10 November 2013 22:38, Tomasz Figa <[e-mail]> wrote:
> >> >> > Hi Sachin, Andrew,
> >> >> >
> >> >> > On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
> >> >> >> From: Andrew Bresticker <[e-mail]>
> >> >> >>
> >> >> >> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
> >> >> >> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
> >> >> >> Fix this so that the MFC will start up.
> >> >> >
> >> >> > Wow, this means that there is a mistake in the documentation. Not that
> >> >> > I'm surprised, though.
> >> >> >
> >> >> > I guess you are sure about this, so:
> >> >> >
> >> >> > Reviewed-by: Tomasz Figa <[e-mail]>
> >> >>
> >> >> I believe you are going to take this through your tree along with a
> >> >> few others which you have already reviewed?
> >> >
> >> > This patch seems to depend on my Exynos 5250 clock clean-up series, which
> >> > will be merged for 3.14. Are you okay with this patch being merged for
> >> > 3.14 as well or this fix is needed for earlier kernel versions too?
> >> > (It is not a regression introduced in 3.13, though.)
> >>
> >> Yes, I did rebase it on top of your series along with other patches.
> >> Though not a regression introduced in 3.13, I think it makes sense to have this
> >> sent as a fix during this release (3.13) itself. Let me know if you
> >> want me to base it
> >> on top of 3.13-rc4 and re-send.
> >
> > Since this is just a trivial fix, let me do it myself when applying.
> >
> 
> Thanks Tomasz.

Applied onto fixes branch.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Sachin Kamat Dec. 31, 2013, 2:51 a.m. UTC | #12

On 30 December 2013 23:22, Tomasz Figa <[e-mail]> wrote:
> On Saturday 21 of December 2013 09:37:06 Sachin Kamat wrote:
>> On 21 December 2013 02:44, Tomasz Figa <[e-mail]> wrote:
>> > On Thursday 19 of December 2013 21:05:09 Sachin Kamat wrote:
>> >> Hi Tomasz,
>> >>
>> >> On 19 December 2013 19:40, Tomasz Figa <[e-mail]> wrote:
>> >> > Hi Sachin, Andrew,
>> >> >
>> >> > On Wednesday 18 of December 2013 23:39:58 Sachin Kamat wrote:
>> >> >> Hi Tomasz,
>> >> >>
>> >> >> On 10 November 2013 22:38, Tomasz Figa <[e-mail]> wrote:
>> >> >> > Hi Sachin, Andrew,
>> >> >> >
>> >> >> > On Friday 08 of November 2013 15:44:07 Sachin Kamat wrote:
>> >> >> >> From: Andrew Bresticker <[e-mail]>
>> >> >> >>
>> >> >> >> The gate clocks for the MFC sysmmus appear to be flipped, i.e.
>> >> >> >> GATE_IP_MFC[2] gates sysmmu_mfcl and GATE_IP_MFC[1] gates sysmmu_mfcr.
>> >> >> >> Fix this so that the MFC will start up.
>> >> >> >
>> >> >> > Wow, this means that there is a mistake in the documentation. Not that
>> >> >> > I'm surprised, though.
>> >> >> >
>> >> >> > I guess you are sure about this, so:
>> >> >> >
>> >> >> > Reviewed-by: Tomasz Figa <[e-mail]>
>> >> >>
>> >> >> I believe you are going to take this through your tree along with a
>> >> >> few others which you have already reviewed?
>> >> >
>> >> > This patch seems to depend on my Exynos 5250 clock clean-up series, which
>> >> > will be merged for 3.14. Are you okay with this patch being merged for
>> >> > 3.14 as well or this fix is needed for earlier kernel versions too?
>> >> > (It is not a regression introduced in 3.13, though.)
>> >>
>> >> Yes, I did rebase it on top of your series along with other patches.
>> >> Though not a regression introduced in 3.13, I think it makes sense to have this
>> >> sent as a fix during this release (3.13) itself. Let me know if you
>> >> want me to base it
>> >> on top of 3.13-rc4 and re-send.
>> >
>> > Since this is just a trivial fix, let me do it myself when applying.
>> >
>>
>> Thanks Tomasz.
>
> Applied onto fixes branch.

Thanks Tomasz. But did not find this on your fixes branch [1]. Not yet
pushed out, maybe?

[1] git://git.kernel.org/pub/scm/linux/kernel/git/tfiga/samsung-clk.git

Patch

diff --git a/drivers/clk/samsung/clk-exynos5250.c b/drivers/clk/samsung/clk-exynos5250.c
index 6767635dc895..986464c2339a 100644
--- a/drivers/clk/samsung/clk-exynos5250.c
+++ b/drivers/clk/samsung/clk-exynos5250.c
@@ -562,8 +562,8 @@  static struct samsung_gate_clock exynos5250_gate_clks[] __initdata = {
 	GATE(hdmi, "hdmi", "mout_aclk200_disp1_sub", GATE_IP_DISP1, 6, 0, 0),
 
 	GATE(mfc, "mfc", "mout_aclk333_sub", GATE_IP_MFC, 0, 0, 0),
-	GATE(smmu_mfcl, "smmu_mfcl", "mout_aclk333_sub", GATE_IP_MFC, 1, 0, 0),
-	GATE(smmu_mfcr, "smmu_mfcr", "mout_aclk333_sub", GATE_IP_MFC, 2, 0, 0),
+	GATE(smmu_mfcl, "smmu_mfcl", "mout_aclk333_sub", GATE_IP_MFC, 2, 0, 0),
+	GATE(smmu_mfcr, "smmu_mfcr", "mout_aclk333_sub", GATE_IP_MFC, 1, 0, 0),
 
 	GATE(rotator, "rotator", "div_aclk266", GATE_IP_GEN, 1, 0, 0),
 	GATE(jpeg, "jpeg", "div_aclk166", GATE_IP_GEN, 2, 0, 0),