| Message ID | 1388709460-19222-7-git-send-email-sboyd@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Stephen, On Thu, Jan 02, 2014 at 04:37:36PM -0800, Stephen Boyd wrote: > The driver is only supported on DT enabled platforms. Convert the > driver to DT so that it can probe properly. I do not see MFD_PM8XXX depending on OF, should it be added if it only supported on DT? Thanks. > > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > --- > drivers/input/misc/pm8xxx-vibrator.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/input/misc/pm8xxx-vibrator.c b/drivers/input/misc/pm8xxx-vibrator.c > index 28251560249d..458d51b88be5 100644 > --- a/drivers/input/misc/pm8xxx-vibrator.c > +++ b/drivers/input/misc/pm8xxx-vibrator.c > @@ -142,6 +142,13 @@ static int pm8xxx_vib_play_effect(struct input_dev *dev, void *data, > return 0; > } > > +static const struct of_device_id pm8xxx_vib_id_table[] = { > + { .compatible = "qcom,pm8058-vib" }, > + { .compatible = "qcom,pm8921-vib" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, pm8xxx_vib_id_table); > + > static int pm8xxx_vib_probe(struct platform_device *pdev) > > { > @@ -221,6 +228,7 @@ static struct platform_driver pm8xxx_vib_driver = { > .name = "pm8xxx-vib", > .owner = THIS_MODULE, > .pm = &pm8xxx_vib_pm_ops, > + .of_match_table = pm8xxx_vib_id_table, > }, > }; > module_platform_driver(pm8xxx_vib_driver); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation >
On 01/02/14 17:17, Dmitry Torokhov wrote: > Hi Stephen, > > On Thu, Jan 02, 2014 at 04:37:36PM -0800, Stephen Boyd wrote: >> The driver is only supported on DT enabled platforms. Convert the >> driver to DT so that it can probe properly. > I do not see MFD_PM8XXX depending on OF, should it be added if it only > supported on DT? No that would unnecessarily limit the compile coverage of this driver. This one is so simple that it doesn't even use any OF APIs because it is all hidden behind the platform bus.
diff --git a/drivers/input/misc/pm8xxx-vibrator.c b/drivers/input/misc/pm8xxx-vibrator.c index 28251560249d..458d51b88be5 100644 --- a/drivers/input/misc/pm8xxx-vibrator.c +++ b/drivers/input/misc/pm8xxx-vibrator.c @@ -142,6 +142,13 @@ static int pm8xxx_vib_play_effect(struct input_dev *dev, void *data, return 0; } +static const struct of_device_id pm8xxx_vib_id_table[] = { + { .compatible = "qcom,pm8058-vib" }, + { .compatible = "qcom,pm8921-vib" }, + { } +}; +MODULE_DEVICE_TABLE(of, pm8xxx_vib_id_table); + static int pm8xxx_vib_probe(struct platform_device *pdev) { @@ -221,6 +228,7 @@ static struct platform_driver pm8xxx_vib_driver = { .name = "pm8xxx-vib", .owner = THIS_MODULE, .pm = &pm8xxx_vib_pm_ops, + .of_match_table = pm8xxx_vib_id_table, }, }; module_platform_driver(pm8xxx_vib_driver);
The driver is only supported on DT enabled platforms. Convert the driver to DT so that it can probe properly. Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- drivers/input/misc/pm8xxx-vibrator.c | 8 ++++++++ 1 file changed, 8 insertions(+)