diff mbox

[2/3] cfg80211: fix processing world regdomain when non modular

Message ID 1387486399-4053-3-git-send-email-mcgrof@do-not-panic.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Luis R. Rodriguez Dec. 19, 2013, 8:53 p.m. UTC
This allows processing of the last regulatory request when
we determine its still pending. This fixes the issue reported
by Sander of when cfg80211 is built-in and no further regulatory
domain processing can happen. This occurred because if the
filesystem was not mounted upon kicking off the udev rule
to run CRDA then the last request will always be left
unprocessed.

Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
---
 net/wireless/reg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Johannes Berg Jan. 7, 2014, 3:35 p.m. UTC | #1
On Thu, 2013-12-19 at 12:53 -0800, Luis R. Rodriguez wrote:
> This allows processing of the last regulatory request when
> we determine its still pending. This fixes the issue reported
> by Sander of when cfg80211 is built-in and no further regulatory
> domain processing can happen. This occurred because if the
> filesystem was not mounted upon kicking off the udev rule
> to run CRDA then the last request will always be left
> unprocessed.

It'd be good to comment on what this actually changes and what happens,
in addition to discussing the user-visible effect?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Luis R. Rodriguez Feb. 19, 2014, 1:10 a.m. UTC | #2
On Tue, Jan 7, 2014 at 7:35 AM, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Thu, 2013-12-19 at 12:53 -0800, Luis R. Rodriguez wrote:
>> This allows processing of the last regulatory request when
>> we determine its still pending. This fixes the issue reported
>> by Sander of when cfg80211 is built-in and no further regulatory
>> domain processing can happen. This occurred because if the
>> filesystem was not mounted upon kicking off the udev rule
>> to run CRDA then the last request will always be left
>> unprocessed.
>
> It'd be good to comment on what this actually changes and what happens,
> in addition to discussing the user-visible effect?

Sure.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 5be2d7c..ecf364e 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -1737,7 +1737,7 @@  static void reg_process_pending_hints(void)
 
 	/* When last_request->processed becomes true this will be rescheduled */
 	if (lr && !lr->processed) {
-		REG_DBG_PRINT("Pending regulatory request, waiting for it to be processed...\n");
+		reg_process_hint(lr);
 		return;
 	}