Message ID | 1387885325-17639-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On 24 December 2013 17:12, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Fixes the following warnings: > drivers/media/i2c/s5k5baf.c: In function 's5k5baf_fw_parse': > drivers/media/i2c/s5k5baf.c:362:3: warning: > format '%d' expects argument of type 'int', but argument 3 has type 'size_t' [-Wformat=] > drivers/media/i2c/s5k5baf.c:383:4: warning: > format '%d' expects argument of type 'int', but argument 4 has type 'size_t' [-Wformat=] > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Reported-by: kbuild test robot <fengguang.wu@intel.com> > --- > drivers/media/i2c/s5k5baf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c > index e3b44a87460b..139bdd4f5dde 100644 > --- a/drivers/media/i2c/s5k5baf.c > +++ b/drivers/media/i2c/s5k5baf.c > @@ -359,7 +359,7 @@ static int s5k5baf_fw_parse(struct device *dev, struct s5k5baf_fw **fw, > int ret; > > if (count < S5K5BAG_FW_TAG_LEN + 1) { > - dev_err(dev, "firmware file too short (%d)\n", count); > + dev_err(dev, "firmware file too short (%zu)\n", count); > return -EINVAL; > } > > @@ -379,7 +379,7 @@ static int s5k5baf_fw_parse(struct device *dev, struct s5k5baf_fw **fw, > > f = (struct s5k5baf_fw *)d; > if (count < 1 + 2 * f->count) { > - dev_err(dev, "invalid firmware header (count=%d size=%d)\n", > + dev_err(dev, "invalid firmware header (count=%d size=%zu)\n", > f->count, 2 * (count + S5K5BAG_FW_TAG_LEN)); > return -EINVAL; > } > -- > 1.7.9.5 > Gentle ping on this series :)
On 01/06/2014 12:48 PM, Sachin Kamat wrote:
Hi Sachin,
Thanks for the fixes.
> Gentle ping on this series :)
Sorry for late reply, but it seems Mauro has merged them already.
Regards
Andrzej
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Andrzej, On 8 January 2014 16:30, Andrzej Hajda <a.hajda@samsung.com> wrote: > On 01/06/2014 12:48 PM, Sachin Kamat wrote: > Hi Sachin, > > Thanks for the fixes. > >> Gentle ping on this series :) > > Sorry for late reply, but it seems Mauro has merged them already. No worries. Yes, Mauro has queued them for 3.14.
diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c index e3b44a87460b..139bdd4f5dde 100644 --- a/drivers/media/i2c/s5k5baf.c +++ b/drivers/media/i2c/s5k5baf.c @@ -359,7 +359,7 @@ static int s5k5baf_fw_parse(struct device *dev, struct s5k5baf_fw **fw, int ret; if (count < S5K5BAG_FW_TAG_LEN + 1) { - dev_err(dev, "firmware file too short (%d)\n", count); + dev_err(dev, "firmware file too short (%zu)\n", count); return -EINVAL; } @@ -379,7 +379,7 @@ static int s5k5baf_fw_parse(struct device *dev, struct s5k5baf_fw **fw, f = (struct s5k5baf_fw *)d; if (count < 1 + 2 * f->count) { - dev_err(dev, "invalid firmware header (count=%d size=%d)\n", + dev_err(dev, "invalid firmware header (count=%d size=%zu)\n", f->count, 2 * (count + S5K5BAG_FW_TAG_LEN)); return -EINVAL; }
Fixes the following warnings: drivers/media/i2c/s5k5baf.c: In function 's5k5baf_fw_parse': drivers/media/i2c/s5k5baf.c:362:3: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t' [-Wformat=] drivers/media/i2c/s5k5baf.c:383:4: warning: format '%d' expects argument of type 'int', but argument 4 has type 'size_t' [-Wformat=] Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Reported-by: kbuild test robot <fengguang.wu@intel.com> --- drivers/media/i2c/s5k5baf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)