| Message ID | 1387839579-58292-1-git-send-email-s-anna@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Suman Anna <s-anna@ti.com> [131223 15:01]: > The irq data for rng module defined in hwmod data previously > missed the OMAP_INTC_START relative offset, so the interrupt > number is probably misconfigured during the DT node addition > adjusting for this OMAP_INTC_START. Interrupt #36 is associated > with a watchdog timer, so fix the rng module's interrupt to the > appropriate interrupt #52. Hmm indeed as the .dtsi files were generated from the hwmod data. Are the other interrupts fixed earlier OK? With earlier I mean your commit 6d4c8830479444 (ARM: OMAP2+: hwmod_data: fix missing OMAP_INTC_START in irq data). Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Tony, On 01/07/2014 06:28 PM, Tony Lindgren wrote: > * Suman Anna <s-anna@ti.com> [131223 15:01]: >> The irq data for rng module defined in hwmod data previously >> missed the OMAP_INTC_START relative offset, so the interrupt >> number is probably misconfigured during the DT node addition >> adjusting for this OMAP_INTC_START. Interrupt #36 is associated >> with a watchdog timer, so fix the rng module's interrupt to the >> appropriate interrupt #52. > > Hmm indeed as the .dtsi files were generated from the hwmod > data. Are the other interrupts fixed earlier OK? GPMC DT nodes are already configured properly, the ISP MMU one needs fixing. I left it out to be fixed as part of Florian's patch that corrects the ISP MMU DT node. There is no IVA MMU DT node yet, and will add the correct number when we add the DT node. regards Suman -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Anna, Suman <s-anna@ti.com> [140108 09:33]: > Tony, > > On 01/07/2014 06:28 PM, Tony Lindgren wrote: > >* Suman Anna <s-anna@ti.com> [131223 15:01]: > >>The irq data for rng module defined in hwmod data previously > >>missed the OMAP_INTC_START relative offset, so the interrupt > >>number is probably misconfigured during the DT node addition > >>adjusting for this OMAP_INTC_START. Interrupt #36 is associated > >>with a watchdog timer, so fix the rng module's interrupt to the > >>appropriate interrupt #52. > > > >Hmm indeed as the .dtsi files were generated from the hwmod > >data. Are the other interrupts fixed earlier OK? > > GPMC DT nodes are already configured properly, the ISP MMU one needs > fixing. I left it out to be fixed as part of Florian's patch that > corrects the ISP MMU DT node. There is no IVA MMU DT node yet, and > will add the correct number when we add the DT node. OK thanks, adding this into omap-for-v3.14/dt as it won't be needed earlier. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/omap2.dtsi b/arch/arm/boot/dts/omap2.dtsi index d0c5b37..5377ddf 100644 --- a/arch/arm/boot/dts/omap2.dtsi +++ b/arch/arm/boot/dts/omap2.dtsi @@ -145,7 +145,7 @@ compatible = "ti,omap2-rng"; ti,hwmods = "rng"; reg = <0x480a0000 0x50>; - interrupts = <36>; + interrupts = <52>; }; sham: sham@480a4000 {
The irq data for rng module defined in hwmod data previously missed the OMAP_INTC_START relative offset, so the interrupt number is probably misconfigured during the DT node addition adjusting for this OMAP_INTC_START. Interrupt #36 is associated with a watchdog timer, so fix the rng module's interrupt to the appropriate interrupt #52. Signed-off-by: Suman Anna <s-anna@ti.com> --- arch/arm/boot/dts/omap2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)