| Message ID | 1389321142-4073-1-git-send-email-pankaj.dubey@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01/10/2014 11:32 AM, Pankaj Dubey wrote: > This patch is inspired from following commit > aec0095653: (irqchip: gic: Call handle_bad_irq() directly) > > Also this will help in removing unwanted inclusion > of header file "asm/mach/irq.h" > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> This is single patch only. By mistake sent as Patch[1/3]. > --- > drivers/irqchip/exynos-combiner.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c > index 40e6440..f8636a6 100644 > --- a/drivers/irqchip/exynos-combiner.c > +++ b/drivers/irqchip/exynos-combiner.c > @@ -17,7 +17,6 @@ > #include <linux/irqchip/chained_irq.h> > #include <linux/of_address.h> > #include <linux/of_irq.h> > -#include <asm/mach/irq.h> > > #include "irqchip.h" > > @@ -81,7 +80,7 @@ static void combiner_handle_cascade_irq(unsigned int irq, struct irq_desc *desc) > cascade_irq = irq_find_mapping(combiner_irq_domain, combiner_irq); > > if (unlikely(!cascade_irq)) > - do_bad_IRQ(irq, desc); > + handle_bad_irq(irq, desc); > else > generic_handle_irq(cascade_irq); >
Hi Pankaj, On 10.01.2014 03:32, Pankaj Dubey wrote: > This patch is inspired from following commit > aec0095653: (irqchip: gic: Call handle_bad_irq() directly) > > Also this will help in removing unwanted inclusion > of header file "asm/mach/irq.h" > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > --- > drivers/irqchip/exynos-combiner.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Tomasz Figa <t.figa@samsung.com> Best regards, Tomasz
On 01/11/2014 01:19 AM, Tomasz Figa wrote: > Hi Pankaj, > > On 10.01.2014 03:32, Pankaj Dubey wrote: >> This patch is inspired from following commit >> aec0095653: (irqchip: gic: Call handle_bad_irq() directly) >> >> Also this will help in removing unwanted inclusion >> of header file "asm/mach/irq.h" >> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> >> --- >> drivers/irqchip/exynos-combiner.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) > > Reviewed-by: Tomasz Figa <t.figa@samsung.com> > > Best regards, > Tomasz > Ping. Thanks, Pankaj Dubey
On 01/11/14 01:19, Tomasz Figa wrote: > Hi Pankaj, > > On 10.01.2014 03:32, Pankaj Dubey wrote: >> This patch is inspired from following commit >> aec0095653: (irqchip: gic: Call handle_bad_irq() directly) >> >> Also this will help in removing unwanted inclusion >> of header file "asm/mach/irq.h" >> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> >> --- >> drivers/irqchip/exynos-combiner.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) > > Reviewed-by: Tomasz Figa <t.figa@samsung.com> > Applied, thanks. - Kukjin
diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c index 40e6440..f8636a6 100644 --- a/drivers/irqchip/exynos-combiner.c +++ b/drivers/irqchip/exynos-combiner.c @@ -17,7 +17,6 @@ #include <linux/irqchip/chained_irq.h> #include <linux/of_address.h> #include <linux/of_irq.h> -#include <asm/mach/irq.h> #include "irqchip.h" @@ -81,7 +80,7 @@ static void combiner_handle_cascade_irq(unsigned int irq, struct irq_desc *desc) cascade_irq = irq_find_mapping(combiner_irq_domain, combiner_irq); if (unlikely(!cascade_irq)) - do_bad_IRQ(irq, desc); + handle_bad_irq(irq, desc); else generic_handle_irq(cascade_irq);
This patch is inspired from following commit aec0095653: (irqchip: gic: Call handle_bad_irq() directly) Also this will help in removing unwanted inclusion of header file "asm/mach/irq.h" Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> --- drivers/irqchip/exynos-combiner.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)