| Message ID | 528074C2.9070707@gtsys.com.hk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. > >>>> On Sunday, November 10, 2013 03:18 PM, Alexander Shiyan wrote: > >>>>> This adds i.MX27 and i.MX31 as the next user of the usbmisc driver. > >>>>> > >>>>> Signed-off-by: Alexander Shiyan<shc_work@mail.ru> > >>>>> --- > >>>>> drivers/usb/chipidea/usbmisc_imx.c | 42 ++++++++++++++++++++++++++++++++++++++ > >>>>> 1 file changed, 42 insertions(+) ... > At this point might be good to patch the imx27.dtsi with the usb defines. ... I have a working configuration for i.MX27 USB, but I prefer to make a few more tests before the addition of definitions in DTS. This will be a next step. Thanks. ---
On Mon, Nov 11, 2013 at 11:09:16AM +0400, Alexander Shiyan wrote: > Hello. > > > >>>> On Sunday, November 10, 2013 03:18 PM, Alexander Shiyan wrote: > > >>>>> This adds i.MX27 and i.MX31 as the next user of the usbmisc driver. > > >>>>> > > >>>>> Signed-off-by: Alexander Shiyan<shc_work@mail.ru> > > >>>>> --- > > >>>>> drivers/usb/chipidea/usbmisc_imx.c | 42 ++++++++++++++++++++++++++++++++++++++ > > >>>>> 1 file changed, 42 insertions(+) > ... > > At this point might be good to patch the imx27.dtsi with the usb defines. > ... > > I have a working configuration for i.MX27 USB, but I prefer to make a few more > tests before the addition of definitions in DTS. This will be a next step. > Thanks. Any news here? Best regards Uwe
Hello, On Mon, Nov 11, 2013 at 02:10:10PM +0800, Chris Ruehl wrote: > On Monday, November 11, 2013 01:47 PM, Alexander Shiyan wrote: > >>On Monday, November 11, 2013 12:45 PM, Alexander Shiyan wrote: > >>>>Hi Alexander, > >>>> > >>>>On Sunday, November 10, 2013 03:18 PM, Alexander Shiyan wrote: > >>>>>This adds i.MX27 and i.MX31 as the next user of the usbmisc driver. > >>>>> > >>>>>Signed-off-by: Alexander Shiyan<shc_work@mail.ru> > >>>>>--- > >>>>> drivers/usb/chipidea/usbmisc_imx.c | 42 ++++++++++++++++++++++++++++++++++++++ > >>>>> 1 file changed, 42 insertions(+) > >>>>> > >>>>>diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c > >>>... > >>>>>+static int usbmisc_imx27_init(struct imx_usbmisc_data *data) > >>>>>+{ > >>>>>+ unsigned long flags; > >>>>>+ u32 val; > >>>>>+ > >>>>>+ switch (data->index) { > >>>>>+ case 0: > >>>>>+ val = MX27_OTG_PM_BIT; > >>>>>+ break; > >>>>>+ case 1: > >>>>>+ val = MX27_H1_PM_BIT; > >>>>>+ break; > >>>>>+ case 2: > >>>>>+ val = MX27_H2_PM_BIT; > >>>>>+ break; > >>>>>+ default: > >>>>>+ return -EINVAL; > >>>>>+ }; > >>>>>+ > >>>> > >>>> From my understanding this can not work, the usbmisc->base not point into the > >>>>usb control register (USB_CTRL). Reference manual 30.5.1.1 says > >>>>BASE + 0x600 > >>>>you must add the offset to the readl instruction. > >>> > >>>Why not work? > >>>usbotg: usb@10024000 > >>>usbh1: usb@10024200 > >>>usbh2: usb@10024400 > >>>usbmisc: usbmisc@10024600 > >>>So, offset to USB_CTRL should already be defined by DTS. > >> > >>in the usbmisc_imx_probe() the base pointer is loaded from > >> > >>res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >>data->base = devm_ioremap_resource(&pdev->dev, res); > >> > >>(and I did not see any of_ operations) > > > >Yes, and this is an address of usbmisc node, not otg. > > Sorry, you are right. I misunderstood because I didn't see any of > sample DTS files define usbmisc yet. > > At this point might be good to patch the imx27.dtsi with the usb defines. > > --- a/arch/arm/boot/dts/imx27.dtsi > +++ b/arch/arm/boot/dts/imx27.dtsi > @@ -30,6 +30,9 @@ > spi0 = &cspi1; > spi1 = &cspi2; > spi2 = &cspi3; > + usb0 = &usbotg; > + usb1 = &usbh1; > + usb2 = &usbh2; > }; > > @@ -404,6 +419,44 @@ > iram = <&iram>; > }; > > + usbotg: usb@10024000 { > + compatible = "fsl,imx27-usb"; > + reg = <0x10024000 0x200>; > + interrupts = <56>; > + clocks = <&clks 75>, <&clks 62>; > + clock-names = "ipg", "ahb"; > + dr_mode = "host"; > + phy_type = "ulpi"; > + status = "disabled"; > + }; > + > + usbh1: usb@10024200 { > + compatible = "fsl,imx27-usb"; > + reg = <0x10024200 0x200>; > + interrupts = <54>; > + clocks = <&clks 75>, <&clks 62>; > + clock-names = "ipg", "ahb"; > + dr_mode = "host"; > + phy_type = "serial"; > + status = "disabled"; > + }; > + > + usbh2: usb@10024400 { > + compatible = "fsl,imx27-usb"; > + reg = <0x10024400 0x200>; > + interrupts = <55>; > + clocks = <&clks 75>, <&clks 62>; > + clock-names = "ipg", "ahb"; > + dr_mode = "host"; > + phy_type = "ulpi"; > + status = "disabled"; > + }; > + > + usbmisc: usbmisc@10024600 { > + compatible = "fsl,imx27-usb"; > + reg = <0x10024600 0x4>; > + }; I didn't try to get this up yet, but I wonder if the last compatible here should better be fsl,imx27-usbmisc?! Best regards Uwe
???????, 11 ?????? 2014, 13:55 +01:00 ?? Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: > On Mon, Nov 11, 2013 at 11:09:16AM +0400, Alexander Shiyan wrote: > > Hello. > > > > > >>>> On Sunday, November 10, 2013 03:18 PM, Alexander Shiyan wrote: > > > >>>>> This adds i.MX27 and i.MX31 as the next user of the usbmisc driver. > > > >>>>> > > > >>>>> Signed-off-by: Alexander Shiyan<shc_work@mail.ru> > > > >>>>> --- > > > >>>>> drivers/usb/chipidea/usbmisc_imx.c | 42 ++++++++++++++++++++++++++++++++++++++ > > > >>>>> 1 file changed, 42 insertions(+) > > ... > > > At this point might be good to patch the imx27.dtsi with the usb defines. > > ... > > > > I have a working configuration for i.MX27 USB, but I prefer to make a few more > > tests before the addition of definitions in DTS. This will be a next step. > > Thanks. > Any news here? Not ready yet. ---
On Sat, Jan 11, 2014 at 06:01:48PM +0400, Alexander Shiyan wrote: > ???????, 11 ?????? 2014, 13:55 +01:00 ?? Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: > > On Mon, Nov 11, 2013 at 11:09:16AM +0400, Alexander Shiyan wrote: > > > Hello. > > > > > > > >>>> On Sunday, November 10, 2013 03:18 PM, Alexander Shiyan wrote: > > > > >>>>> This adds i.MX27 and i.MX31 as the next user of the usbmisc driver. > > > > >>>>> > > > > >>>>> Signed-off-by: Alexander Shiyan<shc_work@mail.ru> > > > > >>>>> --- > > > > >>>>> drivers/usb/chipidea/usbmisc_imx.c | 42 ++++++++++++++++++++++++++++++++++++++ > > > > >>>>> 1 file changed, 42 insertions(+) > > > ... > > > > At this point might be good to patch the imx27.dtsi with the usb defines. > > > ... > > > > > > I have a working configuration for i.MX27 USB, but I prefer to make a few more > > > tests before the addition of definitions in DTS. This will be a next step. > > > Thanks. > > Any news here? > > Not ready yet. Are you still working at it? Would you mind sharing more details, like your current tree/patch stack and what works/doesn't work for you? Thanks Uwe
???????????, 13 ?????? 2014, 22:31 +01:00 ?? Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: > On Sat, Jan 11, 2014 at 06:01:48PM +0400, Alexander Shiyan wrote: > > ???????, 11 ?????? 2014, 13:55 +01:00 ?? Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: > > > On Mon, Nov 11, 2013 at 11:09:16AM +0400, Alexander Shiyan wrote: > > > > Hello. > > > > > > > > > >>>> On Sunday, November 10, 2013 03:18 PM, Alexander Shiyan wrote: > > > > > >>>>> This adds i.MX27 and i.MX31 as the next user of the usbmisc driver. > > > > > >>>>> > > > > > >>>>> Signed-off-by: Alexander Shiyan<shc_work@mail.ru> > > > > > >>>>> --- > > > > > >>>>> drivers/usb/chipidea/usbmisc_imx.c | 42 ++++++++++++++++++++++++++++++++++++++ > > > > > >>>>> 1 file changed, 42 insertions(+) > > > > ... > > > > > At this point might be good to patch the imx27.dtsi with the usb defines. > > > > ... > > > > > > > > I have a working configuration for i.MX27 USB, but I prefer to make a few more > > > > tests before the addition of definitions in DTS. This will be a next step. > > > > Thanks. > > > Any news here? > > > > Not ready yet. > Are you still working at it? Would you mind sharing more details, like > your current tree/patch stack and what works/doesn't work for you? Now my work on this is suspended, but will continue later. I'll send you a personal letter with DT configuration. Ports (both Host & OTG) are detected by kernel, but works Host only. OTG not works nor as Host, nor as Device... ---
On Tuesday, January 14, 2014 11:30 AM, Alexander Shiyan wrote: > ???????????, 13 ?????? 2014, 22:31 +01:00 ?? Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: >> On Sat, Jan 11, 2014 at 06:01:48PM +0400, Alexander Shiyan wrote: >>> ???????, 11 ?????? 2014, 13:55 +01:00 ?? Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: >>>> On Mon, Nov 11, 2013 at 11:09:16AM +0400, Alexander Shiyan wrote: >>>>> Hello. >>>>> >>>>>>>>>> On Sunday, November 10, 2013 03:18 PM, Alexander Shiyan wrote: >>>>>>>>>>> This adds i.MX27 and i.MX31 as the next user of the usbmisc driver. >>>>>>>>>>> >>>>>>>>>>> Signed-off-by: Alexander Shiyan<shc_work@mail.ru> >>>>>>>>>>> --- >>>>>>>>>>> drivers/usb/chipidea/usbmisc_imx.c | 42 ++++++++++++++++++++++++++++++++++++++ >>>>>>>>>>> 1 file changed, 42 insertions(+) >>>>> ... >>>>>> At this point might be good to patch the imx27.dtsi with the usb defines. >>>>> ... >>>>> >>>>> I have a working configuration for i.MX27 USB, but I prefer to make a few more >>>>> tests before the addition of definitions in DTS. This will be a next step. >>>>> Thanks. >>>> Any news here? >>> Not ready yet. >> Are you still working at it? Would you mind sharing more details, like >> your current tree/patch stack and what works/doesn't work for you? > > Now my work on this is suspended, but will continue later. > I'll send you a personal letter with DT configuration. > Ports (both Host & OTG) are detected by kernel, but works Host only. > OTG not works nor as Host, nor as Device... > > --- hi, I'm still working on my patches for imx27 and ULPI integration. But have more urgent things in the queue. I have a running version but it cant make it in the kernel. Rework on platform device code needed. Just wait until the patches already accepted appears in the linux-next before commit new patches. Chris
Hello Alexander,
On Tue, Jan 14, 2014 at 07:30:46AM +0400, Alexander Shiyan wrote:
> I'll send you a personal letter with DT configuration.
That would be great. You didn't send it yet, did you?
Best regards
Uwe
Hello Chris, On Tue, Jan 14, 2014 at 11:53:47AM +0800, Chris Ruehl wrote: > On Tuesday, January 14, 2014 11:30 AM, Alexander Shiyan wrote: > >???????????, 13 ?????? 2014, 22:31 +01:00 ?? Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: > >>On Sat, Jan 11, 2014 at 06:01:48PM +0400, Alexander Shiyan wrote: > >>>???????, 11 ?????? 2014, 13:55 +01:00 ?? Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: > >>>>On Mon, Nov 11, 2013 at 11:09:16AM +0400, Alexander Shiyan wrote: > >>>>>Hello. > >>>>> > >>>>>>>>>>On Sunday, November 10, 2013 03:18 PM, Alexander Shiyan wrote: > >>>>>>>>>>>This adds i.MX27 and i.MX31 as the next user of the usbmisc driver. > >>>>>>>>>>> > >>>>>>>>>>>Signed-off-by: Alexander Shiyan<shc_work@mail.ru> > >>>>>>>>>>>--- > >>>>>>>>>>> drivers/usb/chipidea/usbmisc_imx.c | 42 ++++++++++++++++++++++++++++++++++++++ > >>>>>>>>>>> 1 file changed, 42 insertions(+) > >>>>>... > >>>>>>At this point might be good to patch the imx27.dtsi with the usb defines. > >>>>>... > >>>>> > >>>>>I have a working configuration for i.MX27 USB, but I prefer to make a few more > >>>>>tests before the addition of definitions in DTS. This will be a next step. > >>>>>Thanks. > >>>>Any news here? > >>>Not ready yet. > >>Are you still working at it? Would you mind sharing more details, like > >>your current tree/patch stack and what works/doesn't work for you? > > > >Now my work on this is suspended, but will continue later. > >I'll send you a personal letter with DT configuration. > >Ports (both Host & OTG) are detected by kernel, but works Host only. > >OTG not works nor as Host, nor as Device... > > > >--- > hi, > I'm still working on my patches for imx27 and ULPI integration. But > have more urgent things in the queue. Starting from here I'm not sure I understand you. > I have a running version but it cant make it in the kernel. Rework > on platform device code needed. > Just wait until the patches already accepted appears in the > linux-next before commit new patches. That means: USB works for you? What does "it cant make it in the kernel" mean? Problems to upstream it? Do you wait or should I? Best regards Uwe
Hello Alexander, On Tue, Jan 14, 2014 at 02:47:39PM +0100, Uwe Kleine-König wrote: > On Tue, Jan 14, 2014 at 07:30:46AM +0400, Alexander Shiyan wrote: > > I'll send you a personal letter with DT configuration. > That would be great. You didn't send it yet, did you? I take that back, just found it in my inbox. Don't know why I needed a reply on this mail to find it. Sorry. Uwe
On Tuesday, January 14, 2014 09:49 PM, Uwe Kleine-König wrote: > Hello Chris, > > On Tue, Jan 14, 2014 at 11:53:47AM +0800, Chris Ruehl wrote: >> On Tuesday, January 14, 2014 11:30 AM, Alexander Shiyan wrote: >>> ???????????, 13 ?????? 2014, 22:31 +01:00 ?? Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: >>>> On Sat, Jan 11, 2014 at 06:01:48PM +0400, Alexander Shiyan wrote: >>>>> ???????, 11 ?????? 2014, 13:55 +01:00 ?? Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: >>>>>> On Mon, Nov 11, 2013 at 11:09:16AM +0400, Alexander Shiyan wrote: >>>>>>> Hello. >>>>>>> >>>>>>>>>>>> On Sunday, November 10, 2013 03:18 PM, Alexander Shiyan wrote: >>>>>>>>>>>>> This adds i.MX27 and i.MX31 as the next user of the usbmisc driver. >>>>>>>>>>>>> >>>>>>>>>>>>> Signed-off-by: Alexander Shiyan<shc_work@mail.ru> >>>>>>>>>>>>> --- >>>>>>>>>>>>> drivers/usb/chipidea/usbmisc_imx.c | 42 ++++++++++++++++++++++++++++++++++++++ >>>>>>>>>>>>> 1 file changed, 42 insertions(+) >>>>>>> ... >>>>>>>> At this point might be good to patch the imx27.dtsi with the usb defines. >>>>>>> ... >>>>>>> >>>>>>> I have a working configuration for i.MX27 USB, but I prefer to make a few more >>>>>>> tests before the addition of definitions in DTS. This will be a next step. >>>>>>> Thanks. >>>>>> Any news here? >>>>> Not ready yet. >>>> Are you still working at it? Would you mind sharing more details, like >>>> your current tree/patch stack and what works/doesn't work for you? >>> >>> Now my work on this is suspended, but will continue later. >>> I'll send you a personal letter with DT configuration. >>> Ports (both Host & OTG) are detected by kernel, but works Host only. >>> OTG not works nor as Host, nor as Device... >>> >>> --- >> hi, >> I'm still working on my patches for imx27 and ULPI integration. But >> have more urgent things in the queue. > > Starting from here I'm not sure I understand you. >> I have a running version but it cant make it in the kernel. Rework >> on platform device code needed. I have a customized board running OTG/host and USB2/host (USB1 not connected) Both ports are connected to a ISP1504 ULPI a) I need a rs-gpio to reset in addition to the cs-gpio the ISP1504 (done) b) Implement UPLI viewport (IORESOURCE_MEM) and logic to set the external power supply. The code (b) was rejected and needs rework. >> Just wait until the patches already accepted appears in the >> linux-next before commit new patches. > > That means: USB works for you? What does "it cant make it in the kernel" > mean? Problems to upstream it? > Do you wait or should I? I will fix the problem with (b) and resend my patches. > > Best regards > Uwe >
--- a/arch/arm/boot/dts/imx27.dtsi +++ b/arch/arm/boot/dts/imx27.dtsi @@ -30,6 +30,9 @@ spi0 = &cspi1; spi1 = &cspi2; spi2 = &cspi3; + usb0 = &usbotg; + usb1 = &usbh1; + usb2 = &usbh2; }; @@ -404,6 +419,44 @@