| Message ID | 002001cf11fb$b7217380$25645a80$%jun@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 15 January 2014 15:11, Seungwon Jeon <tgih.jun@samsung.com> wrote: > Replaced UHS_DDR50 with MMC_DDR52. > > CC: Russell King <linux@arm.linux.org.uk> > Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> > --- > drivers/mmc/host/mmci.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c > index f320579..c348427 100644 > --- a/drivers/mmc/host/mmci.c > +++ b/drivers/mmc/host/mmci.c > @@ -299,7 +299,7 @@ static void mmci_set_clkreg(struct mmci_host *host, unsigned int desired) > if (host->mmc->ios.bus_width == MMC_BUS_WIDTH_8) > clk |= MCI_ST_8BIT_BUS; > > - if (host->mmc->ios.timing == MMC_TIMING_UHS_DDR50) > + if (host->mmc->ios.timing == MMC_TIMING_MMC_DDR52) This will break DDR mode for UHS SD-cards. > clk |= MCI_ST_UX500_NEG_EDGE; > > mmci_write_clkreg(host, clk); > @@ -784,7 +784,7 @@ static void mmci_start_data(struct mmci_host *host, struct mmc_data *data) > mmci_write_clkreg(host, clk); > } > > - if (host->mmc->ios.timing == MMC_TIMING_UHS_DDR50) > + if (host->mmc->ios.timing == MMC_TIMING_MMC_DDR52) > datactrl |= MCI_ST_DPSM_DDRMODE; This will break DDR mode for UHS SD-cards. Kind regards Ulf Hansson > > /* > -- > 1.7.0.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, January 16, 2014, Ulf Hansson wrote: > On 15 January 2014 15:11, Seungwon Jeon <tgih.jun@samsung.com> wrote: > > Replaced UHS_DDR50 with MMC_DDR52. > > > > CC: Russell King <linux@arm.linux.org.uk> > > Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> > > --- > > drivers/mmc/host/mmci.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c > > index f320579..c348427 100644 > > --- a/drivers/mmc/host/mmci.c > > +++ b/drivers/mmc/host/mmci.c > > @@ -299,7 +299,7 @@ static void mmci_set_clkreg(struct mmci_host *host, unsigned int desired) > > if (host->mmc->ios.bus_width == MMC_BUS_WIDTH_8) > > clk |= MCI_ST_8BIT_BUS; > > > > - if (host->mmc->ios.timing == MMC_TIMING_UHS_DDR50) > > + if (host->mmc->ios.timing == MMC_TIMING_MMC_DDR52) > > This will break DDR mode for UHS SD-cards. > > > clk |= MCI_ST_UX500_NEG_EDGE; > > > > mmci_write_clkreg(host, clk); > > @@ -784,7 +784,7 @@ static void mmci_start_data(struct mmci_host *host, struct mmc_data *data) > > mmci_write_clkreg(host, clk); > > } > > > > - if (host->mmc->ios.timing == MMC_TIMING_UHS_DDR50) > > + if (host->mmc->ios.timing == MMC_TIMING_MMC_DDR52) > > datactrl |= MCI_ST_DPSM_DDRMODE; > > This will break DDR mode for UHS SD-cards. Thank you for confirmation. Will keep UHS mode and just add MMC's DDR52 mode. Thanks, Seungwon Jeon -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index f320579..c348427 100644 --- a/drivers/mmc/host/mmci.c +++ b/drivers/mmc/host/mmci.c @@ -299,7 +299,7 @@ static void mmci_set_clkreg(struct mmci_host *host, unsigned int desired) if (host->mmc->ios.bus_width == MMC_BUS_WIDTH_8) clk |= MCI_ST_8BIT_BUS; - if (host->mmc->ios.timing == MMC_TIMING_UHS_DDR50) + if (host->mmc->ios.timing == MMC_TIMING_MMC_DDR52) clk |= MCI_ST_UX500_NEG_EDGE; mmci_write_clkreg(host, clk); @@ -784,7 +784,7 @@ static void mmci_start_data(struct mmci_host *host, struct mmc_data *data) mmci_write_clkreg(host, clk); } - if (host->mmc->ios.timing == MMC_TIMING_UHS_DDR50) + if (host->mmc->ios.timing == MMC_TIMING_MMC_DDR52) datactrl |= MCI_ST_DPSM_DDRMODE; /*
Replaced UHS_DDR50 with MMC_DDR52. CC: Russell King <linux@arm.linux.org.uk> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> --- drivers/mmc/host/mmci.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)