| Message ID | 1390688954-4940-1-git-send-email-richard@nod.at (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi Richard, Thank you for the patch. On Saturday 25 January 2014 23:29:14 Richard Weinberger wrote: > Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with > COMPILE_TEST) broke build on archs wihout io memory. > > On archs like S390 or um this driver cannot build nor work. > Make it depend on HAS_IOMEM to bypass build failures. > > drivers/thermal/rcar_thermal.c:404: undefined reference to > `devm_ioremap_resource' drivers/thermal/rcar_thermal.c:426: undefined > reference to `devm_ioremap_resource' > > Signed-off-by: Richard Weinberger <richard@nod.at> > --- > drivers/thermal/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 35c0664..88efa8f 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -136,6 +136,7 @@ config SPEAR_THERMAL > config RCAR_THERMAL > tristate "Renesas R-Car thermal driver" > depends on ARCH_SHMOBILE || COMPILE_TEST > + depends on HAS_IO_MEM Shouldn't that be HAS_IOMEM ? > help > Enable this to plug the R-Car thermal sensor driver into the Linux > thermal framework.
Am 27.01.2014 00:30, schrieb Laurent Pinchart: > Hi Richard, > > Thank you for the patch. > > On Saturday 25 January 2014 23:29:14 Richard Weinberger wrote: >> Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with >> COMPILE_TEST) broke build on archs wihout io memory. >> >> On archs like S390 or um this driver cannot build nor work. >> Make it depend on HAS_IOMEM to bypass build failures. >> >> drivers/thermal/rcar_thermal.c:404: undefined reference to >> `devm_ioremap_resource' drivers/thermal/rcar_thermal.c:426: undefined >> reference to `devm_ioremap_resource' >> >> Signed-off-by: Richard Weinberger <richard@nod.at> >> --- >> drivers/thermal/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig >> index 35c0664..88efa8f 100644 >> --- a/drivers/thermal/Kconfig >> +++ b/drivers/thermal/Kconfig >> @@ -136,6 +136,7 @@ config SPEAR_THERMAL >> config RCAR_THERMAL >> tristate "Renesas R-Car thermal driver" >> depends on ARCH_SHMOBILE || COMPILE_TEST >> + depends on HAS_IO_MEM > > Shouldn't that be HAS_IOMEM ? m( Of course...will resend tomorrow. >> help >> Enable this to plug the R-Car thermal sensor driver into the Linux >> thermal framework. > Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 2014-01-25 at 23:29 +0100, Richard Weinberger wrote: > Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST) > broke build on archs wihout io memory. > > On archs like S390 or um this driver cannot build nor work. > Make it depend on HAS_IOMEM to bypass build failures. > > drivers/thermal/rcar_thermal.c:404: undefined reference to `devm_ioremap_resource' > drivers/thermal/rcar_thermal.c:426: undefined reference to `devm_ioremap_resource' > > Signed-off-by: Richard Weinberger <richard@nod.at> Kuninori, are you okay with this patch? thanks, rui > --- > drivers/thermal/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 35c0664..88efa8f 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -136,6 +136,7 @@ config SPEAR_THERMAL > config RCAR_THERMAL > tristate "Renesas R-Car thermal driver" > depends on ARCH_SHMOBILE || COMPILE_TEST > + depends on HAS_IO_MEM > help > Enable this to plug the R-Car thermal sensor driver into the Linux > thermal framework. -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Zhang > On Sat, 2014-01-25 at 23:29 +0100, Richard Weinberger wrote: > > Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST) > > broke build on archs wihout io memory. > > > > On archs like S390 or um this driver cannot build nor work. > > Make it depend on HAS_IOMEM to bypass build failures. > > > > drivers/thermal/rcar_thermal.c:404: undefined reference to `devm_ioremap_resource' > > drivers/thermal/rcar_thermal.c:426: undefined reference to `devm_ioremap_resource' > > > > Signed-off-by: Richard Weinberger <richard@nod.at> > > Kuninori, > > are you okay with this patch? (snip) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > index 35c0664..88efa8f 100644 > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -136,6 +136,7 @@ config SPEAR_THERMAL > > config RCAR_THERMAL > > tristate "Renesas R-Car thermal driver" > > depends on ARCH_SHMOBILE || COMPILE_TEST > > + depends on HAS_IO_MEM > > help > > Enable this to plug the R-Car thermal sensor driver into the Linux > > thermal framework. I guess - HAS_IO_MEM + HAS_IOMEM ${LINUX}/lib/Makefile say obj-$(CONFIG_HAS_IOMEM) += iomap_copy.o devres.o -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 28.02.2014 01:44, schrieb Kuninori Morimoto: >>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig >>> index 35c0664..88efa8f 100644 >>> --- a/drivers/thermal/Kconfig >>> +++ b/drivers/thermal/Kconfig >>> @@ -136,6 +136,7 @@ config SPEAR_THERMAL >>> config RCAR_THERMAL >>> tristate "Renesas R-Car thermal driver" >>> depends on ARCH_SHMOBILE || COMPILE_TEST >>> + depends on HAS_IO_MEM >>> help >>> Enable this to plug the R-Car thermal sensor driver into the Linux >>> thermal framework. > > I guess > > - HAS_IO_MEM > + HAS_IOMEM Yeah, this has been resolved in v2: https://lkml.org/lkml/2014/1/27/59 Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Richard, Zhang > >>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > >>> index 35c0664..88efa8f 100644 > >>> --- a/drivers/thermal/Kconfig > >>> +++ b/drivers/thermal/Kconfig > >>> @@ -136,6 +136,7 @@ config SPEAR_THERMAL > >>> config RCAR_THERMAL > >>> tristate "Renesas R-Car thermal driver" > >>> depends on ARCH_SHMOBILE || COMPILE_TEST > >>> + depends on HAS_IO_MEM > >>> help > >>> Enable this to plug the R-Car thermal sensor driver into the Linux > >>> thermal framework. > > > > I guess > > > > - HAS_IO_MEM > > + HAS_IOMEM > > Yeah, this has been resolved in v2: > https://lkml.org/lkml/2014/1/27/59 Nice ! Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2014-02-28 at 01:30 -0800, Kuninori Morimoto wrote: > Hi Richard, Zhang > > > >>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > >>> index 35c0664..88efa8f 100644 > > >>> --- a/drivers/thermal/Kconfig > > >>> +++ b/drivers/thermal/Kconfig > > >>> @@ -136,6 +136,7 @@ config SPEAR_THERMAL > > >>> config RCAR_THERMAL > > >>> tristate "Renesas R-Car thermal driver" > > >>> depends on ARCH_SHMOBILE || COMPILE_TEST > > >>> + depends on HAS_IO_MEM > > >>> help > > >>> Enable this to plug the R-Car thermal sensor driver into the Linux > > >>> thermal framework. > > > > > > I guess > > > > > > - HAS_IO_MEM > > > + HAS_IOMEM > > > > Yeah, this has been resolved in v2: > > https://lkml.org/lkml/2014/1/27/59 > > Nice ! > > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > applied. thanks, rui -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 35c0664..88efa8f 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -136,6 +136,7 @@ config SPEAR_THERMAL config RCAR_THERMAL tristate "Renesas R-Car thermal driver" depends on ARCH_SHMOBILE || COMPILE_TEST + depends on HAS_IO_MEM help Enable this to plug the R-Car thermal sensor driver into the Linux thermal framework.
Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST) broke build on archs wihout io memory. On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/thermal/rcar_thermal.c:404: undefined reference to `devm_ioremap_resource' drivers/thermal/rcar_thermal.c:426: undefined reference to `devm_ioremap_resource' Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/thermal/Kconfig | 1 + 1 file changed, 1 insertion(+)