| Message ID | 1390812058-9002-1-git-send-email-richard@nod.at (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
Hi Richard, Thank you for the patch. On Monday 27 January 2014 09:40:58 Richard Weinberger wrote: > Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with > COMPILE_TEST) broke build on archs wihout io memory. > > On archs like S390 or um this driver cannot build nor work. > Make it depend on HAS_IOMEM to bypass build failures. > > drivers/thermal/rcar_thermal.c:404: undefined reference to > `devm_ioremap_resource' drivers/thermal/rcar_thermal.c:426: undefined > reference to `devm_ioremap_resource' > > Signed-off-by: Richard Weinberger <richard@nod.at> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I'm not the driver maintainer so I won't take this patch in my tree. Could you please keep an eye on it to make sure it gets picked by the maintainers ? > --- > drivers/thermal/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 35c0664..88efa8f 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -136,6 +136,7 @@ config SPEAR_THERMAL > config RCAR_THERMAL > tristate "Renesas R-Car thermal driver" > depends on ARCH_SHMOBILE || COMPILE_TEST > + depends on HAS_IOMEM > help > Enable this to plug the R-Car thermal sensor driver into the Linux > thermal framework.
Am 27.01.2014 12:32, schrieb Laurent Pinchart: > Hi Richard, > > Thank you for the patch. > > On Monday 27 January 2014 09:40:58 Richard Weinberger wrote: >> Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with >> COMPILE_TEST) broke build on archs wihout io memory. >> >> On archs like S390 or um this driver cannot build nor work. >> Make it depend on HAS_IOMEM to bypass build failures. >> >> drivers/thermal/rcar_thermal.c:404: undefined reference to >> `devm_ioremap_resource' drivers/thermal/rcar_thermal.c:426: undefined >> reference to `devm_ioremap_resource' >> >> Signed-off-by: Richard Weinberger <richard@nod.at> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > I'm not the driver maintainer so I won't take this patch in my tree. Could you > please keep an eye on it to make sure it gets picked by the maintainers ? Ping? Thanks, //richard >> --- >> drivers/thermal/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig >> index 35c0664..88efa8f 100644 >> --- a/drivers/thermal/Kconfig >> +++ b/drivers/thermal/Kconfig >> @@ -136,6 +136,7 @@ config SPEAR_THERMAL >> config RCAR_THERMAL >> tristate "Renesas R-Car thermal driver" >> depends on ARCH_SHMOBILE || COMPILE_TEST >> + depends on HAS_IOMEM >> help >> Enable this to plug the R-Car thermal sensor driver into the Linux >> thermal framework. > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 35c0664..88efa8f 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -136,6 +136,7 @@ config SPEAR_THERMAL config RCAR_THERMAL tristate "Renesas R-Car thermal driver" depends on ARCH_SHMOBILE || COMPILE_TEST + depends on HAS_IOMEM help Enable this to plug the R-Car thermal sensor driver into the Linux thermal framework.
Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST) broke build on archs wihout io memory. On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/thermal/rcar_thermal.c:404: undefined reference to `devm_ioremap_resource' drivers/thermal/rcar_thermal.c:426: undefined reference to `devm_ioremap_resource' Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/thermal/Kconfig | 1 + 1 file changed, 1 insertion(+)