| Message ID | 1390829189-25073-1-git-send-email-ezequiel.garcia@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jan 27, 2014 at 10:26:29AM -0300, Ezequiel Garcia wrote: > As NAND support is not enabled by default, it's hard to see > why we'd want to have UBI support. Let's remove it. I'd rather add support for the nand. thx, Jason. > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > --- > arch/arm/configs/dove_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/configs/dove_defconfig b/arch/arm/configs/dove_defconfig > index 1101054..7242b11 100644 > --- a/arch/arm/configs/dove_defconfig > +++ b/arch/arm/configs/dove_defconfig > @@ -48,7 +48,6 @@ CONFIG_MTD_CFI_INTELEXT=y > CONFIG_MTD_CFI_STAA=y > CONFIG_MTD_PHYSMAP=y > CONFIG_MTD_M25P80=y > -CONFIG_MTD_UBI=y > CONFIG_BLK_DEV_LOOP=y > CONFIG_BLK_DEV_RAM=y > CONFIG_BLK_DEV_RAM_COUNT=1 > -- > 1.8.1.5 >
On Mon, Jan 27, 2014 at 10:00:40AM -0500, Jason Cooper wrote: > On Mon, Jan 27, 2014 at 10:26:29AM -0300, Ezequiel Garcia wrote: > > As NAND support is not enabled by default, it's hard to see > > why we'd want to have UBI support. Let's remove it. > > I'd rather add support for the nand. > Well, there isn't any Dove board (that we currently support) with a NAND device. Would you still want to add it? In that case, we should consider adding UBIFS as well. Having CONFIG_UBI by itself doesn't make any sense.
On Mon, Jan 27, 2014 at 12:14:30PM -0300, Ezequiel Garcia wrote: > On Mon, Jan 27, 2014 at 10:00:40AM -0500, Jason Cooper wrote: > > On Mon, Jan 27, 2014 at 10:26:29AM -0300, Ezequiel Garcia wrote: > > > As NAND support is not enabled by default, it's hard to see > > > why we'd want to have UBI support. Let's remove it. > > > > I'd rather add support for the nand. > > > > Well, there isn't any Dove board (that we currently support) with a NAND > device. Would you still want to add it? sh*t. you're right. My memory is failing me. I'll queue this up. thx, Jason.
On Mon, Jan 27, 2014 at 10:26:29AM -0300, Ezequiel Garcia wrote: > As NAND support is not enabled by default, it's hard to see > why we'd want to have UBI support. Let's remove it. > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > --- > arch/arm/configs/dove_defconfig | 1 - > 1 file changed, 1 deletion(-) Added to mvebu/defconfig thx, Jason.
diff --git a/arch/arm/configs/dove_defconfig b/arch/arm/configs/dove_defconfig index 1101054..7242b11 100644 --- a/arch/arm/configs/dove_defconfig +++ b/arch/arm/configs/dove_defconfig @@ -48,7 +48,6 @@ CONFIG_MTD_CFI_INTELEXT=y CONFIG_MTD_CFI_STAA=y CONFIG_MTD_PHYSMAP=y CONFIG_MTD_M25P80=y -CONFIG_MTD_UBI=y CONFIG_BLK_DEV_LOOP=y CONFIG_BLK_DEV_RAM=y CONFIG_BLK_DEV_RAM_COUNT=1
As NAND support is not enabled by default, it's hard to see why we'd want to have UBI support. Let's remove it. Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> --- arch/arm/configs/dove_defconfig | 1 - 1 file changed, 1 deletion(-)