| Message ID | 8e4231b7a55802f58a14dd07ac5cd8b0babb1dce.1391274628.git.moinejf@free.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 01-02-2014 20:48, Jean-Francois Moine wrote: > This patch adds the DT documentation of the NXP TDA998x CODEC. > Signed-off-by: Jean-Francois Moine <moinejf@free.fr> > --- > Documentation/devicetree/bindings/drm/i2c/tda998x.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > diff --git a/Documentation/devicetree/bindings/drm/i2c/tda998x.txt b/Documentation/devicetree/bindings/drm/i2c/tda998x.txt > index d7df01c..aa0d81b 100644 > --- a/Documentation/devicetree/bindings/drm/i2c/tda998x.txt > +++ b/Documentation/devicetree/bindings/drm/i2c/tda998x.txt [...] > @@ -24,4 +35,10 @@ Example: > interrupts = <27 2>; /* falling edge */ > pinctrl-0 = <&pmx_camera>; > pinctrl-names = "default"; > + hdmi_codec: codec { This line is indented too far to the right. > + compatible = "nxp,tda998x-codec"; > + audio-ports = <0x03>, <0x04>; > + audio-port-names = "i2s", "spdif"; > + #sound-dai-cells = <1>; > + }; > }; WBR, Sergei
On Sat, Feb 01, 2014 at 05:48:49PM +0100, Jean-Francois Moine wrote:
> + - compatible: must be "nxp,tda998x-codec".
It's not clear to me why there's a separate compatible here - as far as
I can see this can only appear as part of one of these devices and
there's no addressing or other information that'd account for chip
variation so I'd not expect to need to bind this independently of the
parent.
On Tue, 4 Feb 2014 18:12:13 +0000 Mark Brown <broonie@kernel.org> wrote: > On Sat, Feb 01, 2014 at 05:48:49PM +0100, Jean-Francois Moine wrote: > > > + - compatible: must be "nxp,tda998x-codec". > > It's not clear to me why there's a separate compatible here - as far as > I can see this can only appear as part of one of these devices and > there's no addressing or other information that'd account for chip > variation so I'd not expect to need to bind this independently of the > parent. If there is no 'compatible', the CODEC module is not loaded, and, when the module is in the core, no CODEC device can be created from the DT.
On Tue, Feb 04, 2014 at 08:02:39PM +0100, Jean-Francois Moine wrote: > Mark Brown <broonie@kernel.org> wrote: > > On Sat, Feb 01, 2014 at 05:48:49PM +0100, Jean-Francois Moine wrote: > > > + - compatible: must be "nxp,tda998x-codec". > > It's not clear to me why there's a separate compatible here - as far as > > I can see this can only appear as part of one of these devices and > > there's no addressing or other information that'd account for chip > > variation so I'd not expect to need to bind this independently of the > > parent. > If there is no 'compatible', the CODEC module is not loaded, and, when > the module is in the core, no CODEC device can be created from the DT. You're confusing implementation details with device tree specification here. We can easily handle loading a subdriver without having to put anything in the device tree, just create a platform device like we do with MFDs.
diff --git a/Documentation/devicetree/bindings/drm/i2c/tda998x.txt b/Documentation/devicetree/bindings/drm/i2c/tda998x.txt index d7df01c..aa0d81b 100644 --- a/Documentation/devicetree/bindings/drm/i2c/tda998x.txt +++ b/Documentation/devicetree/bindings/drm/i2c/tda998x.txt @@ -15,6 +15,17 @@ Optional properties: - video-ports: 24 bits value which defines how the video controller output is wired to the TDA998x input - default: <0x230145> +Optional subnodes: + + - codec: audio CODEC + +Required codec subnode properties: + - compatible: must be "nxp,tda998x-codec". + - audio-ports: one or two values corresponding to entries in + the audio-port-names property. + - audio-port-names: must contain "i2s", "spdif" entries + matching entries in the audio-ports property. + Example: tda998x: hdmi-encoder { @@ -24,4 +35,10 @@ Example: interrupts = <27 2>; /* falling edge */ pinctrl-0 = <&pmx_camera>; pinctrl-names = "default"; + hdmi_codec: codec { + compatible = "nxp,tda998x-codec"; + audio-ports = <0x03>, <0x04>; + audio-port-names = "i2s", "spdif"; + #sound-dai-cells = <1>; + }; };
This patch adds the DT documentation of the NXP TDA998x CODEC. Signed-off-by: Jean-Francois Moine <moinejf@free.fr> --- Documentation/devicetree/bindings/drm/i2c/tda998x.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)