| Message ID | 20140205222301.14fbb441@spike (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1647138df66c695eb16f4a6bce7f088f817ab26d |
| Headers | show |
On Wed, Feb 05, 2014 at 10:23:01PM +0100, Christian Engelmayer wrote: > Remove unused devdata pointer 'orion_spi' in function orion_spi_write_read(). > > Detected by Coverity: CID 1077860. > > Signed-off-by: Christian Engelmayer <cengelma@gmx.at> I'll apply this but please follow the patch submission process in SubmittingPatches, in particular please always CC maintainers on patches.
> I'll apply this but please follow the patch submission process in > SubmittingPatches, in particular please always CC maintainers on > patches. Thanks. For trivial patches like this I tend to rely on get_maintainer.pl which clearly pointed me to You. I'll put more investigation into it again next time.
On Wed, Feb 05, 2014 at 10:54:21PM +0100, Christian Engelmayer wrote: > > I'll apply this but please follow the patch submission process in > > SubmittingPatches, in particular please always CC maintainers on > > patches. > Thanks. For trivial patches like this I tend to rely on > get_maintainer.pl which clearly pointed me to You. I'll put more > investigation into it again next time. It should've listed the maintainer as broonie@kernel.org rather at linaro.org which was where you sent this - IIRC you posted some other stuff recently which missed my comaintainer on that subsystem. Checking right now I can't get it to give my Linaro address at all for that file, odd. It could find that via signoffs but it seems to have squashed those into the maintainer section.
On Wed, 5 Feb 2014 22:12:26 +0000, Mark Brown <broonie@kernel.org> wrote: > On Wed, Feb 05, 2014 at 10:54:21PM +0100, Christian Engelmayer wrote: > > > I'll apply this but please follow the patch submission process in > > > SubmittingPatches, in particular please always CC maintainers on > > > patches. > > > Thanks. For trivial patches like this I tend to rely on > > get_maintainer.pl which clearly pointed me to You. I'll put more > > investigation into it again next time. > > It should've listed the maintainer as broonie@kernel.org rather at > linaro.org which was where you sent this - IIRC you posted some other > stuff recently which missed my comaintainer on that subsystem. Checking > right now I can't get it to give my Linaro address at all for that file, > odd. It could find that via signoffs but it seems to have squashed > those into the maintainer section. You are right, I already recently used Your linaro address and the referenced commit that led me to addressing You and just CC the list was signed-off-by broonie@linaro.org. Interestingly I had both Your linaro/kernel.org addresses in my MUA's address book - prefering linaro. So get_maintainer.pl in this case chose Mark Brown, but isn't to blame for the wrong address. Again, my apologies for the noise.
diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c index 7f2121f..75871d4 100644 --- a/drivers/spi/spi-orion.c +++ b/drivers/spi/spi-orion.c @@ -260,11 +260,9 @@ orion_spi_write_read_16bit(struct spi_device *spi, static unsigned int orion_spi_write_read(struct spi_device *spi, struct spi_transfer *xfer) { - struct orion_spi *orion_spi; unsigned int count; int word_len; - orion_spi = spi_master_get_devdata(spi->master); word_len = spi->bits_per_word; count = xfer->len;
Remove unused devdata pointer 'orion_spi' in function orion_spi_write_read(). Detected by Coverity: CID 1077860. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> --- drivers/spi/spi-orion.c | 2 -- 1 file changed, 2 deletions(-)