| Message ID | 1391971686-9517-2-git-send-email-richard@nod.at (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, 2014-02-09 at 19:47 +0100, Richard Weinberger wrote: > The symbol is an orphan, get rid of it. > > Signed-off-by: Richard Weinberger <richard@nod.at> This symbol first popped up as a dependency in v3.6, through commit 3d4eb9dfa3e8 ("usb: gadget: mv: Add USB 3.0 device driver for Marvell PXA2128 chip."). The Kconfig symbol itself was never added. > diff --git a/drivers/video/mmp/hw/Kconfig b/drivers/video/mmp/hw/Kconfig > index 02f109a..57b03e2 100644 > --- a/drivers/video/mmp/hw/Kconfig > +++ b/drivers/video/mmp/hw/Kconfig > @@ -2,7 +2,7 @@ if MMP_DISP > > config MMP_DISP_CONTROLLER > bool "mmp display controller hw support" > - depends on CPU_PXA910 || CPU_MMP2 || CPU_MMP3 || CPU_PXA988 > + depends on CPU_PXA910 || CPU_MMP2 || CPU_PXA988 > default n > help > Marvell MMP display hw controller support You should remove the reference to MMP3 in the help text (not displayed here) too, I'd guess. Aside from that: Acked-by: Paul Bolle <pebolle@tiscali.nl> Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Feb 09, 2014 at 07:47:39PM +0100, Richard Weinberger wrote: > The symbol is an orphan, get rid of it. > > Signed-off-by: Richard Weinberger <richard@nod.at> > Acked-by: Paul Bolle <pebolle@tiscali.nl> > > --- > drivers/usb/phy/Kconfig | 1 - > drivers/video/mmp/Kconfig | 2 +- > drivers/video/mmp/hw/Kconfig | 2 +- > 3 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig > index 7d1451d..b9b1c52 100644 > --- a/drivers/usb/phy/Kconfig > +++ b/drivers/usb/phy/Kconfig > @@ -61,7 +61,6 @@ config KEYSTONE_USB_PHY > > config MV_U3D_PHY > bool "Marvell USB 3.0 PHY controller Driver" > - depends on CPU_MMP3 > select USB_PHY > help > Enable this to support Marvell USB 3.0 phy controller for Marvell Do this and the driver breaks the build so it needs to depend on something: drivers/usb/phy/phy-mv-u3d-usb.c: In function ‘mv_u3d_phy_read’: drivers/usb/phy/phy-mv-u3d-usb.c:42:2: error: implicit declaration of function ‘writel_relaxed’ [-Werror=implicit-function-declaration] Sorry, I can't take this as-is. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2014-02-11 at 13:30 -0800, Greg Kroah-Hartman wrote: > On Sun, Feb 09, 2014 at 07:47:39PM +0100, Richard Weinberger wrote: > > The symbol is an orphan, get rid of it. > > > > Signed-off-by: Richard Weinberger <richard@nod.at> > > Acked-by: Paul Bolle <pebolle@tiscali.nl> > > > > --- > > drivers/usb/phy/Kconfig | 1 - > > drivers/video/mmp/Kconfig | 2 +- > > drivers/video/mmp/hw/Kconfig | 2 +- > > 3 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig > > index 7d1451d..b9b1c52 100644 > > --- a/drivers/usb/phy/Kconfig > > +++ b/drivers/usb/phy/Kconfig > > @@ -61,7 +61,6 @@ config KEYSTONE_USB_PHY > > > > config MV_U3D_PHY > > bool "Marvell USB 3.0 PHY controller Driver" > > - depends on CPU_MMP3 > > select USB_PHY > > help > > Enable this to support Marvell USB 3.0 phy controller for Marvell > > Do this and the driver breaks the build so it needs to depend on > something: > > drivers/usb/phy/phy-mv-u3d-usb.c: In function ‘mv_u3d_phy_read’: > drivers/usb/phy/phy-mv-u3d-usb.c:42:2: error: implicit declaration of function ‘writel_relaxed’ [-Werror=implicit-function-declaration] This sort of proves that a driver that depends on an unknown Kconfig symbol gets no build coverage (and will bit rot). > Sorry, I can't take this as-is. My mistake, I should have spotted this when looking a Richard's patch. Some background (which I quickly dug up): config MV_U3D_PHY got added in v3.7 through commit a67e76ac904c ("usb: phy: mv_u3d: Add usb phy driver for mv_u3d"). It then depended on USB_MV_U3D. And that symbol depended on CPU_MMP3 at that time. Ie, MV_U3D_PHY was unbuildable when it was added. In commit 60630c2eabd4 ("usb: gadget: mv_u3d: drop ARCH dependency") MV_U3D_PHY was made depended directly on CPU_MMP3. That kept it unbuildable, of course. Richard, assuming you agree with the above short history of MV_U3D_PHY, would you mind sending a v2 that removes this unbuildable driver? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Cc Yu Xu <yuxu@marvell.com> On Tue, Feb 11, 2014 at 11:01 PM, Paul Bolle <pebolle@tiscali.nl> wrote: > On Tue, 2014-02-11 at 13:30 -0800, Greg Kroah-Hartman wrote: >> On Sun, Feb 09, 2014 at 07:47:39PM +0100, Richard Weinberger wrote: >> > The symbol is an orphan, get rid of it. >> > >> > Signed-off-by: Richard Weinberger <richard@nod.at> >> > Acked-by: Paul Bolle <pebolle@tiscali.nl> >> > >> > --- >> > drivers/usb/phy/Kconfig | 1 - >> > drivers/video/mmp/Kconfig | 2 +- >> > drivers/video/mmp/hw/Kconfig | 2 +- >> > 3 files changed, 2 insertions(+), 3 deletions(-) >> > >> > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig >> > index 7d1451d..b9b1c52 100644 >> > --- a/drivers/usb/phy/Kconfig >> > +++ b/drivers/usb/phy/Kconfig >> > @@ -61,7 +61,6 @@ config KEYSTONE_USB_PHY >> > >> > config MV_U3D_PHY >> > bool "Marvell USB 3.0 PHY controller Driver" >> > - depends on CPU_MMP3 >> > select USB_PHY >> > help >> > Enable this to support Marvell USB 3.0 phy controller for Marvell >> >> Do this and the driver breaks the build so it needs to depend on >> something: >> >> drivers/usb/phy/phy-mv-u3d-usb.c: In function ‘mv_u3d_phy_read’: >> drivers/usb/phy/phy-mv-u3d-usb.c:42:2: error: implicit declaration of function ‘writel_relaxed’ [-Werror=implicit-function-declaration] > > This sort of proves that a driver that depends on an unknown Kconfig > symbol gets no build coverage (and will bit rot). > >> Sorry, I can't take this as-is. > > My mistake, I should have spotted this when looking a Richard's patch. > > Some background (which I quickly dug up): config MV_U3D_PHY got added in > v3.7 through commit a67e76ac904c ("usb: phy: mv_u3d: Add usb phy driver > for mv_u3d"). It then depended on USB_MV_U3D. And that symbol depended > on CPU_MMP3 at that time. Ie, MV_U3D_PHY was unbuildable when it was > added. > > In commit 60630c2eabd4 ("usb: gadget: mv_u3d: drop ARCH dependency") > MV_U3D_PHY was made depended directly on CPU_MMP3. That kept it > unbuildable, of course. > > Richard, assuming you agree with the above short history of MV_U3D_PHY, > would you mind sending a v2 that removes this unbuildable driver? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index 7d1451d..b9b1c52 100644 --- a/drivers/usb/phy/Kconfig +++ b/drivers/usb/phy/Kconfig @@ -61,7 +61,6 @@ config KEYSTONE_USB_PHY config MV_U3D_PHY bool "Marvell USB 3.0 PHY controller Driver" - depends on CPU_MMP3 select USB_PHY help Enable this to support Marvell USB 3.0 phy controller for Marvell diff --git a/drivers/video/mmp/Kconfig b/drivers/video/mmp/Kconfig index e9ea39e..969925d 100644 --- a/drivers/video/mmp/Kconfig +++ b/drivers/video/mmp/Kconfig @@ -1,6 +1,6 @@ menuconfig MMP_DISP tristate "Marvell MMP Display Subsystem support" - depends on CPU_PXA910 || CPU_MMP2 || CPU_MMP3 || CPU_PXA988 + depends on CPU_PXA910 || CPU_MMP2 || CPU_PXA988 help Marvell Display Subsystem support. diff --git a/drivers/video/mmp/hw/Kconfig b/drivers/video/mmp/hw/Kconfig index 02f109a..57b03e2 100644 --- a/drivers/video/mmp/hw/Kconfig +++ b/drivers/video/mmp/hw/Kconfig @@ -2,7 +2,7 @@ if MMP_DISP config MMP_DISP_CONTROLLER bool "mmp display controller hw support" - depends on CPU_PXA910 || CPU_MMP2 || CPU_MMP3 || CPU_PXA988 + depends on CPU_PXA910 || CPU_MMP2 || CPU_PXA988 default n help Marvell MMP display hw controller support
The symbol is an orphan, get rid of it. Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/usb/phy/Kconfig | 1 - drivers/video/mmp/Kconfig | 2 +- drivers/video/mmp/hw/Kconfig | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-)