| Message ID | 20140208190223.45d1dcf8@spike (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 77c398f58c1fe57224c17f6d4360c7f74cc0e418 |
| Headers | show |
On Sunday, February 09, 2014 3:02 AM, Christian Engelmayer wrote: > > Remove unused devdata pointer 'spi100k' in function omap1_spi100k_txrx_pio(). > > Detected by Coverity: CID 1077869. > > Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Reviewed-by: Jingoo Han <jg1.han@samsung.com> Best regards, Jingoo Han > --- > Applies against v3.14-rc1 as well as branch for-next in tree > git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git > --- > drivers/spi/spi-omap-100k.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c > index 0d32054..8eaf0cd 100644 > --- a/drivers/spi/spi-omap-100k.c > +++ b/drivers/spi/spi-omap-100k.c > @@ -204,12 +204,10 @@ static void omap1_spi100k_force_cs(struct omap1_spi100k *spi100k, int enable) > static unsigned > omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer) > { > - struct omap1_spi100k *spi100k; > struct omap1_spi100k_cs *cs = spi->controller_state; > unsigned int count, c; > int word_len; > > - spi100k = spi_master_get_devdata(spi->master); > count = xfer->len; > c = count; > word_len = cs->word_len; > -- > 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Feb 08 2014, Christian Engelmayer <cengelma@gmx.at> wrote: > Remove unused devdata pointer 'spi100k' in function omap1_spi100k_txrx_pio(). > > Detected by Coverity: CID 1077869. > > Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Acked-by: Michal Nazarewicz <mina86@mina86.com> > --- > Applies against v3.14-rc1 as well as branch for-next in tree > git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git > --- > drivers/spi/spi-omap-100k.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c > index 0d32054..8eaf0cd 100644 > --- a/drivers/spi/spi-omap-100k.c > +++ b/drivers/spi/spi-omap-100k.c > @@ -204,12 +204,10 @@ static void omap1_spi100k_force_cs(struct omap1_spi100k *spi100k, int enable) > static unsigned > omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer) > { > - struct omap1_spi100k *spi100k; > struct omap1_spi100k_cs *cs = spi->controller_state; > unsigned int count, c; > int word_len; > > - spi100k = spi_master_get_devdata(spi->master); > count = xfer->len; > c = count; > word_len = cs->word_len; > -- > 1.8.3.2
On Sat, Feb 08, 2014 at 07:02:23PM +0100, Christian Engelmayer wrote: > Remove unused devdata pointer 'spi100k' in function omap1_spi100k_txrx_pio(). > > Detected by Coverity: CID 1077869. Applied, thanks.
diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c index 0d32054..8eaf0cd 100644 --- a/drivers/spi/spi-omap-100k.c +++ b/drivers/spi/spi-omap-100k.c @@ -204,12 +204,10 @@ static void omap1_spi100k_force_cs(struct omap1_spi100k *spi100k, int enable) static unsigned omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer) { - struct omap1_spi100k *spi100k; struct omap1_spi100k_cs *cs = spi->controller_state; unsigned int count, c; int word_len; - spi100k = spi_master_get_devdata(spi->master); count = xfer->len; c = count; word_len = cs->word_len;
Remove unused devdata pointer 'spi100k' in function omap1_spi100k_txrx_pio(). Detected by Coverity: CID 1077869. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> --- Applies against v3.14-rc1 as well as branch for-next in tree git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git --- drivers/spi/spi-omap-100k.c | 2 -- 1 file changed, 2 deletions(-)