| Message ID | 1391767923.4937.110.camel@mars (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On 07/02/14 12:12, Christoph Fritz wrote: > Yes, your patch fixes the issues for sys_clkout2. Thanks! If you want, > you can add my: > Tested-by: Christoph Fritz <chf.fritz@googlemail.com> > > Below is my clock fix for dss: > > From b90a62128068e1b6b0ba2a11c5cc0c8e587cf301 Mon Sep 17 00:00:00 2001 > From: Christoph Fritz <chf.fritz@googlemail.com> > Date: Fri, 7 Feb 2014 10:51:15 +0100 > Subject: [PATCH] ARM: dts: omap36xx: fix dpll4_m4_ck tree > > OMAP36xx has different hardware implementation for the dpll4_m4_ck tree > compared to other OMAP3 variants. Reflect this properly in the dts file. I rebased the DSS DT branch on top of v3.14-rc1, and I'm trying to get beagle-xM working. Pinmuxing was wrong, but after fixing that, the clk_set_rate for dss fclk failed. I applied Tero's and your patches, but now when starting omapdss I see: [ 19.704193] omap clock: module associated with clock dss1_alwon_fck_3430es2 didn't enable in 1000 00 tries I wonder if I'm still missing some patch? Tomi
On Fri, 2014-02-07 at 15:49 +0200, Tomi Valkeinen wrote: > On 07/02/14 12:12, Christoph Fritz wrote: > > > Yes, your patch fixes the issues for sys_clkout2. Thanks! If you want, > > you can add my: > > Tested-by: Christoph Fritz <chf.fritz@googlemail.com> > > > > Below is my clock fix for dss: > > > > From b90a62128068e1b6b0ba2a11c5cc0c8e587cf301 Mon Sep 17 00:00:00 2001 > > From: Christoph Fritz <chf.fritz@googlemail.com> > > Date: Fri, 7 Feb 2014 10:51:15 +0100 > > Subject: [PATCH] ARM: dts: omap36xx: fix dpll4_m4_ck tree > > > > OMAP36xx has different hardware implementation for the dpll4_m4_ck tree > > compared to other OMAP3 variants. Reflect this properly in the dts file. > > I rebased the DSS DT branch on top of v3.14-rc1, and I'm trying to get > beagle-xM working. Pinmuxing was wrong, but after fixing that, the > clk_set_rate for dss fclk failed. I applied Tero's and your patches, but > now when starting omapdss I see: > > [ 19.704193] omap clock: module associated with clock > dss1_alwon_fck_3430es2 didn't enable in 1000 > 00 tries > > I wonder if I'm still missing some patch? Is beagle-xM using DSI? Because here the LILLY-A83X board is not. The clock registers are all fine now as before the dt clock conversion patches. I suppose you are using current linus tree. I tested 'next' but didn't get DSS working. I guessed that it would have something to do with early DSS DT integration issues. I'll rebase my current dt board support patchset for LILLY-A83X to current linus tree and investigate DSS further. Thanks -- Christoph -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/02/14 22:54, Christoph Fritz wrote: >> I wonder if I'm still missing some patch? > > Is beagle-xM using DSI? Because here the LILLY-A83X board is not. The > clock registers are all fine now as before the dt clock conversion > patches. No, Beagle xM doesn't use DSI, plain DPI. Tomi
diff --git a/arch/arm/boot/dts/omap36xx-clocks.dtsi b/arch/arm/boot/dts/omap36xx-clocks.dtsi index 24869cb..8ac8926 100644 --- a/arch/arm/boot/dts/omap36xx-clocks.dtsi +++ b/arch/arm/boot/dts/omap36xx-clocks.dtsi @@ -74,6 +74,14 @@ clock-div = <2>; }; +&dpll4_m4_ck { + clock-div = <15>; +}; + +&dss1_alwon_fck_3430es2 { + clocks = <&dpll4_m4_ck>; +}; + &cm_clockdomains { dpll4_clkdm: dpll4_clkdm { compatible = "ti,clockdomain"; diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi index 7e8dee9..5e1bcd0 100644 --- a/arch/arm/boot/dts/omap36xx.dtsi +++ b/arch/arm/boot/dts/omap36xx.dtsi @@ -52,7 +52,7 @@ }; }; -/include/ "omap36xx-clocks.dtsi" /include/ "omap34xx-omap36xx-clocks.dtsi" /include/ "omap36xx-omap3430es2plus-clocks.dtsi" /include/ "omap36xx-am35xx-omap3430es2plus-clocks.dtsi" +/include/ "omap36xx-clocks.dtsi"