diff mbox

spi: sc18is602: Move checking chip_select for SC18IS602 to sc18is602_setup

Message ID 1392123257.1351.9.camel@phoenix (mailing list archive)
State Accepted
Commit c5c67e31bc1b96658169b5b553b9be42e2ca6368
Headers show

Commit Message

Axel Lin Feb. 11, 2014, 12:54 p.m. UTC 
So it will be checked when spi device is added onto the spi bus.
spi_add_device() calls spi_setup() which then calls spi->master->setup().
No need to check it every time sc18is602_transfer_one() is called.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/spi/spi-sc18is602.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

Comments

Guenter Roeck Feb. 11, 2014, 4:14 p.m. UTC | #1 
On Tue, Feb 11, 2014 at 08:54:17PM +0800, Axel Lin wrote:
> So it will be checked when spi device is added onto the spi bus.
> spi_add_device() calls spi_setup() which then calls spi->master->setup().
> No need to check it every time sc18is602_transfer_one() is called.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Guenter Roeck <linux@roeck-us.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown Feb. 11, 2014, 5:04 p.m. UTC | #2 
On Tue, Feb 11, 2014 at 08:54:17PM +0800, Axel Lin wrote:
> So it will be checked when spi device is added onto the spi bus.
> spi_add_device() calls spi_setup() which then calls spi->master->setup().
> No need to check it every time sc18is602_transfer_one() is called.

Applied, thanks.
diff mbox

Patch

diff --git a/drivers/spi/spi-sc18is602.c b/drivers/spi/spi-sc18is602.c
index b3ac776..7fba10b 100644
--- a/drivers/spi/spi-sc18is602.c
+++ b/drivers/spi/spi-sc18is602.c
@@ -205,12 +205,6 @@  static int sc18is602_transfer_one(struct spi_master *master,
 	struct spi_transfer *t;
 	int status = 0;
 
-	/* SC18IS602 does not support CS2 */
-	if (hw->id == sc18is602 && spi->chip_select == 2) {
-		status = -ENXIO;
-		goto error;
-	}
-
 	hw->tlen = 0;
 	list_for_each_entry(t, &m->transfers, transfer_list) {
 		u32 hz = t->speed_hz ? : spi->max_speed_hz;
@@ -238,13 +232,23 @@  static int sc18is602_transfer_one(struct spi_master *master,
 		if (t->delay_usecs)
 			udelay(t->delay_usecs);
 	}
-error:
 	m->status = status;
 	spi_finalize_current_message(master);
 
 	return status;
 }
 
+static int sc18is602_setup(struct spi_device *spi)
+{
+	struct sc18is602 *hw = spi_master_get_devdata(spi->master);
+
+	/* SC18IS602 does not support CS2 */
+	if (hw->id == sc18is602 && spi->chip_select == 2)
+		return -ENXIO;
+
+	return 0;
+}
+
 static int sc18is602_probe(struct i2c_client *client,
 			   const struct i2c_device_id *id)
 {
@@ -298,6 +302,7 @@  static int sc18is602_probe(struct i2c_client *client,
 	master->bus_num = client->adapter->nr;
 	master->mode_bits = SPI_CPHA | SPI_CPOL | SPI_LSB_FIRST;
 	master->bits_per_word_mask = SPI_BPW_MASK(8);
+	master->setup = sc18is602_setup;
 	master->transfer_one_message = sc18is602_transfer_one;
 	master->dev.of_node = np;