diff mbox

[v2,4/4] Documentation: dt: OMAP: Update Overo/Tobi

Message ID 1392287116-4548-5-git-send-email-florian.vaussard@epfl.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Florian Vaussard Feb. 13, 2014, 10:25 a.m. UTC
Update the compatible string for Overo/Tobi to reflect the latest
changes.

Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
---
 Documentation/devicetree/bindings/arm/omap/omap.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nishanth Menon Feb. 13, 2014, 2:43 p.m. UTC | #1
On 02/13/2014 04:25 AM, Florian Vaussard wrote:
> Update the compatible string for Overo/Tobi to reflect the latest
> changes.
> 
> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
> ---
>  Documentation/devicetree/bindings/arm/omap/omap.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt
> index 34dc40c..af9b4a0 100644
> --- a/Documentation/devicetree/bindings/arm/omap/omap.txt
> +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt
> @@ -91,7 +91,7 @@ Boards:
>    compatible = "ti,omap3-beagle", "ti,omap3"
>  
>  - OMAP3 Tobi with Overo : Commercial expansion board with daughter board
> -  compatible = "ti,omap3-tobi", "ti,omap3-overo", "ti,omap3"
> +  compatible = "gumstix,omap3-overo-tobi", "gumstix,omap3-overo", "ti,omap3"
omap3-overo-storm-tobi.dts is not covered here, so, I wonder as the
number of boards supported keep increasing, is'nt it better we drop
the board information from omap.txt?

>  
>  - OMAP4 SDP : Software Development Board
>    compatible = "ti,omap4-sdp", "ti,omap4430"
>
Florian Vaussard Feb. 14, 2014, 7:58 a.m. UTC | #2
Hi,

On 02/13/2014 03:43 PM, Nishanth Menon wrote:
> On 02/13/2014 04:25 AM, Florian Vaussard wrote:
>> Update the compatible string for Overo/Tobi to reflect the latest
>> changes.
>>
>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
>> ---
>>  Documentation/devicetree/bindings/arm/omap/omap.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt
>> index 34dc40c..af9b4a0 100644
>> --- a/Documentation/devicetree/bindings/arm/omap/omap.txt
>> +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt
>> @@ -91,7 +91,7 @@ Boards:
>>    compatible = "ti,omap3-beagle", "ti,omap3"
>>  
>>  - OMAP3 Tobi with Overo : Commercial expansion board with daughter board
>> -  compatible = "ti,omap3-tobi", "ti,omap3-overo", "ti,omap3"
>> +  compatible = "gumstix,omap3-overo-tobi", "gumstix,omap3-overo", "ti,omap3"
> omap3-overo-storm-tobi.dts is not covered here, so, I wonder as the
> number of boards supported keep increasing, is'nt it better we drop
> the board information from omap.txt?
> 

I am not opposed to this. We will just have checkpatch warnings due to
undocumented compatible strings.

Regards,
Florian
Nishanth Menon Feb. 14, 2014, 8:14 a.m. UTC | #3
On 02/14/2014 01:58 AM, Florian Vaussard wrote:
> Hi,
> 
> On 02/13/2014 03:43 PM, Nishanth Menon wrote:
>> On 02/13/2014 04:25 AM, Florian Vaussard wrote:
>>> Update the compatible string for Overo/Tobi to reflect the latest
>>> changes.
>>>
>>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
>>> ---
>>>  Documentation/devicetree/bindings/arm/omap/omap.txt | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt
>>> index 34dc40c..af9b4a0 100644
>>> --- a/Documentation/devicetree/bindings/arm/omap/omap.txt
>>> +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt
>>> @@ -91,7 +91,7 @@ Boards:
>>>    compatible = "ti,omap3-beagle", "ti,omap3"
>>>  
>>>  - OMAP3 Tobi with Overo : Commercial expansion board with daughter board
>>> -  compatible = "ti,omap3-tobi", "ti,omap3-overo", "ti,omap3"
>>> +  compatible = "gumstix,omap3-overo-tobi", "gumstix,omap3-overo", "ti,omap3"
>> omap3-overo-storm-tobi.dts is not covered here, so, I wonder as the
>> number of boards supported keep increasing, is'nt it better we drop
>> the board information from omap.txt?
>>
> 
> I am not opposed to this. We will just have checkpatch warnings due to
> undocumented compatible strings.

Aaah, I seemed to have missed bff5da43 commit, thanks for pointing me
at it - unrelated to this patch, I think the board cleanups is a
little overdue :(

Acked-by: Nishanth Menon <nm@ti.com>
Tony Lindgren Feb. 14, 2014, 4:39 p.m. UTC | #4
* Nishanth Menon <nm@ti.com> [140214 00:17]:
> On 02/14/2014 01:58 AM, Florian Vaussard wrote:
> > Hi,
> > 
> > On 02/13/2014 03:43 PM, Nishanth Menon wrote:
> >> On 02/13/2014 04:25 AM, Florian Vaussard wrote:
> >>> Update the compatible string for Overo/Tobi to reflect the latest
> >>> changes.
> >>>
> >>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
> >>> ---
> >>>  Documentation/devicetree/bindings/arm/omap/omap.txt | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt
> >>> index 34dc40c..af9b4a0 100644
> >>> --- a/Documentation/devicetree/bindings/arm/omap/omap.txt
> >>> +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt
> >>> @@ -91,7 +91,7 @@ Boards:
> >>>    compatible = "ti,omap3-beagle", "ti,omap3"
> >>>  
> >>>  - OMAP3 Tobi with Overo : Commercial expansion board with daughter board
> >>> -  compatible = "ti,omap3-tobi", "ti,omap3-overo", "ti,omap3"
> >>> +  compatible = "gumstix,omap3-overo-tobi", "gumstix,omap3-overo", "ti,omap3"
> >> omap3-overo-storm-tobi.dts is not covered here, so, I wonder as the
> >> number of boards supported keep increasing, is'nt it better we drop
> >> the board information from omap.txt?
> >>
> > 
> > I am not opposed to this. We will just have checkpatch warnings due to
> > undocumented compatible strings.
> 
> Aaah, I seemed to have missed bff5da43 commit, thanks for pointing me
> at it - unrelated to this patch, I think the board cleanups is a
> little overdue :(
> 
> Acked-by: Nishanth Menon <nm@ti.com>

OK thanks picking up this too.

Tony
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt
index 34dc40c..af9b4a0 100644
--- a/Documentation/devicetree/bindings/arm/omap/omap.txt
+++ b/Documentation/devicetree/bindings/arm/omap/omap.txt
@@ -91,7 +91,7 @@  Boards:
   compatible = "ti,omap3-beagle", "ti,omap3"
 
 - OMAP3 Tobi with Overo : Commercial expansion board with daughter board
-  compatible = "ti,omap3-tobi", "ti,omap3-overo", "ti,omap3"
+  compatible = "gumstix,omap3-overo-tobi", "gumstix,omap3-overo", "ti,omap3"
 
 - OMAP4 SDP : Software Development Board
   compatible = "ti,omap4-sdp", "ti,omap4430"