| Message ID | 1391846481-31491-12-git-send-email-ak@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/08/2014 12:01 AM, Andi Kleen wrote: > LTO gcc puts a lot of data into $TMPDIR, essentially another copy > of the object directory to pass the repartitioned object files > to the code generation processes. > > TMPDIR defaults to /tmp With /tmp as tmpfs it's easy to drive systems to > out of memory, because they will compete with the already high anonymous > memory consumption of the wpa LTO pass. > > When LTO is set always set TMPDIR to the object directory. This could > be slightly slower, but is far safer and eliminates another parameter > the LTO user would need to set manually. > > I made it conditional on LTO for now. I think this really ought to use ?= so it doesn't override a TMPDIR explicitly set by the user. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Makefile b/Makefile index 606ef7c..d1189ea 100644 --- a/Makefile +++ b/Makefile @@ -407,6 +407,14 @@ export KBUILD_AFLAGS_MODULE KBUILD_CFLAGS_MODULE KBUILD_LDFLAGS_MODULE export KBUILD_AFLAGS_KERNEL KBUILD_CFLAGS_KERNEL export KBUILD_ARFLAGS +ifdef CONFIG_LTO +# LTO gcc creates a lot of files in TMPDIR, and with /tmp as tmpfs +# it's easy to drive the machine OOM. Use the object directory +# instead +TMPDIR := ${objtree} +export TMPDIR +endif + # When compiling out-of-tree modules, put MODVERDIR in the module # tree rather than in the kernel tree. The kernel tree might # even be read-only.
LTO gcc puts a lot of data into $TMPDIR, essentially another copy of the object directory to pass the repartitioned object files to the code generation processes. TMPDIR defaults to /tmp With /tmp as tmpfs it's easy to drive systems to out of memory, because they will compete with the already high anonymous memory consumption of the wpa LTO pass. When LTO is set always set TMPDIR to the object directory. This could be slightly slower, but is far safer and eliminates another parameter the LTO user would need to set manually. I made it conditional on LTO for now. Signed-off-by: Andi Kleen <ak@linux.intel.com> --- Makefile | 8 ++++++++ 1 file changed, 8 insertions(+)