| Message ID | 1391591048-19433-1-git-send-email-nm@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Nishanth Menon <nm@ti.com> [140205 01:06]: > omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref > for every call that takes place. This is an can be done only if a change > is detected. > > Signed-off-by: Nishanth Menon <nm@ti.com> Would like to see acks on this too before applying. Tony > --- > arch/arm/mach-omap2/dpll3xxx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c > index 3185ced..d9bcbf7 100644 > --- a/arch/arm/mach-omap2/dpll3xxx.c > +++ b/arch/arm/mach-omap2/dpll3xxx.c > @@ -525,7 +525,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate, > * stuff is inherited for free > */ > > - if (!ret) > + if (!ret && clk_get_parent(hw->clk) != new_parent) > __clk_reparent(hw->clk, new_parent); > > return 0; > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/14/2014 01:13 AM, Tony Lindgren wrote: > * Nishanth Menon <nm@ti.com> [140205 01:06]: >> omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref >> for every call that takes place. This is an can be done only if a change >> is detected. >> >> Signed-off-by: Nishanth Menon <nm@ti.com> > > Would like to see acks on this too before applying. Looks good to me, ack. -Tero > > Tony > >> --- >> arch/arm/mach-omap2/dpll3xxx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c >> index 3185ced..d9bcbf7 100644 >> --- a/arch/arm/mach-omap2/dpll3xxx.c >> +++ b/arch/arm/mach-omap2/dpll3xxx.c >> @@ -525,7 +525,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate, >> * stuff is inherited for free >> */ >> >> - if (!ret) >> + if (!ret && clk_get_parent(hw->clk) != new_parent) >> __clk_reparent(hw->clk, new_parent); >> >> return 0; >> -- >> 1.7.9.5 >> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 5 Feb 2014, Nishanth Menon wrote: > omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref > for every call that takes place. This is an can be done only if a change > is detected. > > Signed-off-by: Nishanth Menon <nm@ti.com> Queued for v3.15 with Tero's ack unless the patch is updated to indicate that it's more than an optimization. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c index 3185ced..d9bcbf7 100644 --- a/arch/arm/mach-omap2/dpll3xxx.c +++ b/arch/arm/mach-omap2/dpll3xxx.c @@ -525,7 +525,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate, * stuff is inherited for free */ - if (!ret) + if (!ret && clk_get_parent(hw->clk) != new_parent) __clk_reparent(hw->clk, new_parent); return 0;
omap3_noncore_dpll_set_rate forces a reparent to the same clk_ref for every call that takes place. This is an can be done only if a change is detected. Signed-off-by: Nishanth Menon <nm@ti.com> --- arch/arm/mach-omap2/dpll3xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)