| Message ID | 1392306839-10736-1-git-send-email-fabio.estevam@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Feb 13, 2014 at 01:53:58PM -0200, Fabio Estevam wrote: > GPIO4_10 is the GPIO used to turn on the regulator that powers up the codec. > > Add a hog entry for it. I'm going to be strict on hog pin use. It does not sound like a true hog pin. Is it possible to have a pinctrl state for that regulator setting this pin up? Shawn > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > index 0d816d3..a802265 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > @@ -303,6 +303,7 @@ > MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000 > MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x80000000 > MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x80000000 > + MX6QDL_PAD_KEY_COL2__GPIO4_IO10 0x80000000 > >; > }; > > -- > 1.8.1.2 > >
On Sun, Feb 16, 2014 at 11:05 PM, Shawn Guo <shawn.guo@linaro.org> wrote: > On Thu, Feb 13, 2014 at 01:53:58PM -0200, Fabio Estevam wrote: >> GPIO4_10 is the GPIO used to turn on the regulator that powers up the codec. >> >> Add a hog entry for it. > > I'm going to be strict on hog pin use. It does not sound like a true > hog pin. Is it possible to have a pinctrl state for that regulator > setting this pin up? Could you please explain when a pin should or should not be placed into the hog group? Regards, Fabio Estevam
On Sun, Feb 16, 2014 at 11:11:40PM -0300, Fabio Estevam wrote: > On Sun, Feb 16, 2014 at 11:05 PM, Shawn Guo <shawn.guo@linaro.org> wrote: > > On Thu, Feb 13, 2014 at 01:53:58PM -0200, Fabio Estevam wrote: > >> GPIO4_10 is the GPIO used to turn on the regulator that powers up the codec. > >> > >> Add a hog entry for it. > > > > I'm going to be strict on hog pin use. It does not sound like a true > > hog pin. Is it possible to have a pinctrl state for that regulator > > setting this pin up? > > Could you please explain when a pin should or should not be placed > into the hog group? The hog group is for those pins that do not belong to any particular client device. IOW, we should only put a pin into hog group when it can not be put into any client device's pinctrl state. Shawn
diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi index 0d816d3..a802265 100644 --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi @@ -303,6 +303,7 @@ MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000 MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x80000000 MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x80000000 + MX6QDL_PAD_KEY_COL2__GPIO4_IO10 0x80000000 >; };
GPIO4_10 is the GPIO used to turn on the regulator that powers up the codec. Add a hog entry for it. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 1 + 1 file changed, 1 insertion(+)