diff mbox

ARM: dts: imx6sl-evk: Keep VGEN1 regulator always enabled

Message ID 1392752404-524-1-git-send-email-fabio.estevam@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam Feb. 18, 2014, 7:40 p.m. UTC 
On imx6sl-evk board the VGEN1 regulator powers up the NVCC_1.2V domain of the
imx6sl SoC, so we need to keep it always powered.

This problem has been observed by the fact that a GPIO connected to an LED could
not work when the PMIC driver was enabled.

Keeping VGEN1 regulator always enabled fixes the problem.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx6sl-evk.dts | 2 ++
 1 file changed, 2 insertions(+)

Comments

Shawn Guo Feb. 19, 2014, 1:19 a.m. UTC | #1 
On Tue, Feb 18, 2014 at 04:40:04PM -0300, Fabio Estevam wrote:
> On imx6sl-evk board the VGEN1 regulator powers up the NVCC_1.2V domain of the
> imx6sl SoC, so we need to keep it always powered.
> 
> This problem has been observed by the fact that a GPIO connected to an LED could
> not work when the PMIC driver was enabled.
> 
> Keeping VGEN1 regulator always enabled fixes the problem.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Applied, thanks.
Shawn Guo Feb. 19, 2014, 6:03 a.m. UTC | #2 
On Wed, Feb 19, 2014 at 09:19:59AM +0800, Shawn Guo wrote:
> On Tue, Feb 18, 2014 at 04:40:04PM -0300, Fabio Estevam wrote:
> > On imx6sl-evk board the VGEN1 regulator powers up the NVCC_1.2V domain of the
> > imx6sl SoC, so we need to keep it always powered.
> > 
> > This problem has been observed by the fact that a GPIO connected to an LED could
> > not work when the PMIC driver was enabled.
> > 
> > Keeping VGEN1 regulator always enabled fixes the problem.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Applied, thanks.

Since Mark is questioning this is a correct fix, I'm dropping it for
now.

Shawn
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx6sl-evk.dts b/arch/arm/boot/dts/imx6sl-evk.dts
index 889422c..2ae933b 100644
--- a/arch/arm/boot/dts/imx6sl-evk.dts
+++ b/arch/arm/boot/dts/imx6sl-evk.dts
@@ -195,6 +195,8 @@ 
 			vgen1_reg: vgen1 {
 				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <1550000>;
+				regulator-boot-on;
+				regulator-always-on;
 			};
 
 			vgen2_reg: vgen2 {