| Message ID | 1392925376-20562-1-git-send-email-sakari.ailus@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/20/2014 08:42 PM, Sakari Ailus wrote: > Timestamp buffer flags are constant at the moment. Document them so that 1) > they're always valid and 2) not changed by the drivers. This leaves room to > extend the functionality later on if needed. > > Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > --- > since v5: > - Clarify timestamp source flag behaviour. > > Documentation/DocBook/media/v4l/io.xml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/DocBook/media/v4l/io.xml b/Documentation/DocBook/media/v4l/io.xml > index 22b87bc..a69e12a 100644 > --- a/Documentation/DocBook/media/v4l/io.xml > +++ b/Documentation/DocBook/media/v4l/io.xml > @@ -653,6 +653,16 @@ plane, are stored in struct <structname>v4l2_plane</structname> instead. > In that case, struct <structname>v4l2_buffer</structname> contains an array of > plane structures.</para> > > + <para>Dequeued video buffers come with timestamps. The driver > + decides at which part of the frame and with which clock the > + timestamp is taken. Please see flags in the masks > + <constant>V4L2_BUF_FLAG_TIMESTAMP_MASK</constant> and > + <constant>V4L2_BUF_FLAG_TSTAMP_SRC_MASK</constant> in <xref > + linkend="buffer-flags">. These flags are always valid and constant > + across all buffers during the whole video stream. Changes in these > + flags may take place as a side effect of &VIDIOC-S-INPUT; or > + &VIDIOC-S-OUTPUT; however.</para> > + > <table frame="none" pgwide="1" id="v4l2-buffer"> > <title>struct <structname>v4l2_buffer</structname></title> > <tgroup cols="4"> > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 20, 2014 at 09:25:47PM +0100, Hans Verkuil wrote: > On 02/20/2014 08:42 PM, Sakari Ailus wrote: > > Timestamp buffer flags are constant at the moment. Document them so that 1) > > they're always valid and 2) not changed by the drivers. This leaves room to > > extend the functionality later on if needed. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi> > > Acked-by: Hans Verkuil <hans.verkuil@cisco.com> Thanks! :-)
diff --git a/Documentation/DocBook/media/v4l/io.xml b/Documentation/DocBook/media/v4l/io.xml index 22b87bc..a69e12a 100644 --- a/Documentation/DocBook/media/v4l/io.xml +++ b/Documentation/DocBook/media/v4l/io.xml @@ -653,6 +653,16 @@ plane, are stored in struct <structname>v4l2_plane</structname> instead. In that case, struct <structname>v4l2_buffer</structname> contains an array of plane structures.</para> + <para>Dequeued video buffers come with timestamps. The driver + decides at which part of the frame and with which clock the + timestamp is taken. Please see flags in the masks + <constant>V4L2_BUF_FLAG_TIMESTAMP_MASK</constant> and + <constant>V4L2_BUF_FLAG_TSTAMP_SRC_MASK</constant> in <xref + linkend="buffer-flags">. These flags are always valid and constant + across all buffers during the whole video stream. Changes in these + flags may take place as a side effect of &VIDIOC-S-INPUT; or + &VIDIOC-S-OUTPUT; however.</para> + <table frame="none" pgwide="1" id="v4l2-buffer"> <title>struct <structname>v4l2_buffer</structname></title> <tgroup cols="4">
Timestamp buffer flags are constant at the moment. Document them so that 1) they're always valid and 2) not changed by the drivers. This leaves room to extend the functionality later on if needed. Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi> --- since v5: - Clarify timestamp source flag behaviour. Documentation/DocBook/media/v4l/io.xml | 10 ++++++++++ 1 file changed, 10 insertions(+)