diff mbox

[v2,2/2] phy: Select PHY_EXYNOS_DP_VIDEO by default for ARCH_EXYNOS

Message ID 1392997802-29050-2-git-send-email-s.nawrocki@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics Feb. 21, 2014, 3:50 p.m. UTC 
Instead of requiring user to figure out when PHY_EXYNOS_DP_VIDEO needs
to be selected select it by default for Exynos SoCs. Also enable it
when COMPILE_TEST is selected. If required the display port PHY driver
can be then disabled or compiled in as module.

Cc: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
---
Changes since first version:
 - use ARCH_EXYNOS instead of "ARCH_EXYNOS4 || ARCH_EXYNOS5"
 - add dependency on COMPILE_TEST
---
 drivers/phy/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

Comments

Arnd Bergmann Feb. 21, 2014, 3:59 p.m. UTC | #1 
On Friday 21 February 2014 16:50:02 Sylwester Nawrocki wrote:
>  config PHY_EXYNOS_DP_VIDEO
>         tristate "EXYNOS SoC series Display Port PHY driver"
>         depends on OF
> +       depends on ARCH_EXYNOS || COMPILE_TEST
> +       default y
>         select GENERIC_PHY
>         help
> 

That would turn them on automatically if you enable COMPILE_TEST, which
is probably not what you want.

How about "default ARCH_EXYNOS"?

	Arnd
Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics Feb. 21, 2014, 4:25 p.m. UTC | #2 
On 21/02/14 16:59, Arnd Bergmann wrote:
> On Friday 21 February 2014 16:50:02 Sylwester Nawrocki wrote:
>>  config PHY_EXYNOS_DP_VIDEO
>>         tristate "EXYNOS SoC series Display Port PHY driver"
>>         depends on OF
>> +       depends on ARCH_EXYNOS || COMPILE_TEST
>> +       default y
>>         select GENERIC_PHY
>>         help
>>
> 
> That would turn them on automatically if you enable COMPILE_TEST, which
> is probably not what you want.
> 
> How about "default ARCH_EXYNOS"?

Hmm, good point, I will modify it that way.

For patch 1/2 I guess it should be:

"default ARCH_S5PV210 || ARCH_EXYNOS"

or rather

"default y if ARCH_S5PV210 || ARCH_EXYNOS" ?

Thanks,
Sylwester
Arnd Bergmann Feb. 21, 2014, 4:41 p.m. UTC | #3 
On Friday 21 February 2014 17:25:04 Sylwester Nawrocki wrote:
> 
> Hmm, good point, I will modify it that way.
> 
> For patch 1/2 I guess it should be:
> 
> "default ARCH_S5PV210 || ARCH_EXYNOS"
> 
> or rather
> 
> "default y if ARCH_S5PV210 || ARCH_EXYNOS" ?

Right. I'd probably use the first syntax, but it doesn't really matter.

	Arnd
Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics Feb. 21, 2014, 4:50 p.m. UTC | #4 
On 21/02/14 17:41, Arnd Bergmann wrote:
> On Friday 21 February 2014 17:25:04 Sylwester Nawrocki wrote:
>> > 
>> > Hmm, good point, I will modify it that way.
>> > 
>> > For patch 1/2 I guess it should be:
>> > 
>> > "default ARCH_S5PV210 || ARCH_EXYNOS"
>> > 
>> > or rather
>> > 
>> > "default y if ARCH_S5PV210 || ARCH_EXYNOS" ?
>
> Right. I'd probably use the first syntax, but it doesn't really matter.

Oops, I've already sent patch using the second one, as it seemed
more common.

Thanks,
Sylwester
Arnd Bergmann Feb. 21, 2014, 5:54 p.m. UTC | #5 
On Friday 21 February 2014 17:50:44 Sylwester Nawrocki wrote:
> On 21/02/14 17:41, Arnd Bergmann wrote:
> > On Friday 21 February 2014 17:25:04 Sylwester Nawrocki wrote:
> >> > 
> >> > Hmm, good point, I will modify it that way.
> >> > 
> >> > For patch 1/2 I guess it should be:
> >> > 
> >> > "default ARCH_S5PV210 || ARCH_EXYNOS"
> >> > 
> >> > or rather
> >> > 
> >> > "default y if ARCH_S5PV210 || ARCH_EXYNOS" ?
> >
> > Right. I'd probably use the first syntax, but it doesn't really matter.
> 
> Oops, I've already sent patch using the second one, as it seemed
> more common.

As I said, it doesn't matter.

	Arnd
diff mbox

Patch

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index ebd455c..4218c99 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -57,6 +57,8 @@  config TWL4030_USB
 config PHY_EXYNOS_DP_VIDEO
 	tristate "EXYNOS SoC series Display Port PHY driver"
 	depends on OF
+	depends on ARCH_EXYNOS || COMPILE_TEST
+	default y
 	select GENERIC_PHY
 	help
 	  Support for Display Port PHY found on Samsung EXYNOS SoCs.