diff mbox

[v2,2/5] vmbus: add missing breaks

Message ID 1393237516-28545-3-git-send-email-kraxel@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Gerd Hoffman Feb. 24, 2014, 10:25 a.m. UTC
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 drivers/hv/vmbus_drv.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Dan Carpenter Feb. 24, 2014, 10:42 a.m. UTC | #1
I'm sorry, I know it sucks to not get credit for fixes, but please just
fold this into [patch 1/5].  We really should have a tag for this kind
of thing.

Would something like this work?
Additional-Fixes: Gerd Hoffmann <kraxel@redhat.com>

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Gerd Hoffman Feb. 24, 2014, 10:55 a.m. UTC | #2
On Mo, 2014-02-24 at 13:42 +0300, Dan Carpenter wrote:
> I'm sorry, I know it sucks to not get credit for fixes, but please just
> fold this into [patch 1/5].  We really should have a tag for this kind
> of thing.

It's not because of the credits, but because Greg picked up #1 into one
of his branches already (cover letter explains this).  I'll happily
submit a v3 with 1+2 squashed together if that doesn't ruin the patch
workflow.  Greg?

cheers,
  Gerd


--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dan Carpenter Feb. 24, 2014, 11:07 a.m. UTC | #3
On Mon, Feb 24, 2014 at 11:55:43AM +0100, Gerd Hoffmann wrote:
> On Mo, 2014-02-24 at 13:42 +0300, Dan Carpenter wrote:
> > I'm sorry, I know it sucks to not get credit for fixes, but please just
> > fold this into [patch 1/5].  We really should have a tag for this kind
> > of thing.
> 
> It's not because of the credits, but because Greg picked up #1 into one
> of his branches already (cover letter explains this).  I'll happily
> submit a v3 with 1+2 squashed together if that doesn't ruin the patch
> workflow.  Greg?
> 

Ah.  My bad.  My tree is out of date.  No we don't modify staging
history.  Once a patch has been applied it is forever.

Why are you resending #1 if it's already been applied.

I haven't recieved the cover letter...  Probably it explains that.
Never mind.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index b37c91b..2352ae48 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -899,10 +899,12 @@  static acpi_status vmbus_walk_resources(struct acpi_resource *res, void *ctx)
 	switch (res->type) {
 	case ACPI_RESOURCE_TYPE_IRQ:
 		irq = res->data.irq.interrupts[0];
+		break;
 
 	case ACPI_RESOURCE_TYPE_ADDRESS64:
 		hyperv_mmio_start = res->data.address64.minimum;
 		hyperv_mmio_size = res->data.address64.address_length;
+		break;
 	}
 
 	return AE_OK;