| Message ID | 1393331320-18147-3-git-send-email-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> -----Original Message----- > From: Gerd Hoffmann [mailto:kraxel@redhat.com] > Sent: Tuesday, February 25, 2014 7:29 AM > To: linux-fbdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; gregkh@linuxfoundation.org; KY Srinivasan; > Abhishek Gupta (LIS); Haiyang Zhang; jasowang@redhat.com; > tomi.valkeinen@ti.com; devel@linuxdriverproject.org; Gerd Hoffmann; Jean- > Christophe Plagniol-Villard > Subject: [PATCH v4 2/2] hyperv-fb: kick off efifb early > > Remove firmware framebuffer before initializing hyperv-fb. Needed > on gen2 virtual machines. Letting register_framebuffer handle the > switchover results in efifb still being active while hyperv graphics are > initialized, which in turn can make the linux kernel hang. > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > drivers/video/hyperv_fb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/hyperv_fb.c b/drivers/video/hyperv_fb.c index > b7b3dd0..1b11886 100644 > --- a/drivers/video/hyperv_fb.c > +++ b/drivers/video/hyperv_fb.c > @@ -683,6 +683,7 @@ static int hvfb_getmem(struct fb_info *info) > info->apertures->ranges[0].base = pci_resource_start(pdev, 0); > info->apertures->ranges[0].size = pci_resource_len(pdev, 0); > } > + remove_conflicting_framebuffers(info->apertures, > KBUILD_MODNAME, > +false); Thanks for the updates. I'm concerned about, after removing efifb, if synthvid_send_config(hdev) fails, then there will be no video driver available. Is there a way to bring the generic driver back if synthvid_send_config(hdev) fails? If no way to recover the generic driver, please limit the early remove_conflicting_framebuffers() to Gen2 VM only. Thanks, - Haiyang -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, > > diff --git a/drivers/video/hyperv_fb.c b/drivers/video/hyperv_fb.c index > > b7b3dd0..1b11886 100644 > > --- a/drivers/video/hyperv_fb.c > > +++ b/drivers/video/hyperv_fb.c > > @@ -683,6 +683,7 @@ static int hvfb_getmem(struct fb_info *info) > > info->apertures->ranges[0].base = pci_resource_start(pdev, 0); > > info->apertures->ranges[0].size = pci_resource_len(pdev, 0); > > } > > + remove_conflicting_framebuffers(info->apertures, > > KBUILD_MODNAME, > > +false); > > Thanks for the updates. I'm concerned about, after removing efifb, > if synthvid_send_config(hdev) fails, then there will be no video driver > available. That may happen, yes. > Is there a way to bring the generic driver back if > synthvid_send_config(hdev) fails? Not that I know of. > If no way to recover the generic driver, please limit the early > remove_conflicting_framebuffers() to Gen2 VM only. I'll send updated patches once they are tested. cheers, Gerd -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/hyperv_fb.c b/drivers/video/hyperv_fb.c index b7b3dd0..1b11886 100644 --- a/drivers/video/hyperv_fb.c +++ b/drivers/video/hyperv_fb.c @@ -683,6 +683,7 @@ static int hvfb_getmem(struct fb_info *info) info->apertures->ranges[0].base = pci_resource_start(pdev, 0); info->apertures->ranges[0].size = pci_resource_len(pdev, 0); } + remove_conflicting_framebuffers(info->apertures, KBUILD_MODNAME, false); info->fix.smem_start = par->mem.start; info->fix.smem_len = screen_fb_size;
Remove firmware framebuffer before initializing hyperv-fb. Needed on gen2 virtual machines. Letting register_framebuffer handle the switchover results in efifb still being active while hyperv graphics are initialized, which in turn can make the linux kernel hang. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- drivers/video/hyperv_fb.c | 1 + 1 file changed, 1 insertion(+)