| Message ID | 1393343227-13092-1-git-send-email-ajax@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <ajax@redhat.com> wrote: > From: Peter Jones <pjones@redhat.com> > > Some systems, such as EFI-based Apple systems, won't necessarily have an > i8042 to initialize. We shouldn't be printing an error message in this > case, since not detecting the chip is the correct behavior. > > v2: Downgrade to pr_notice instead of pr_err. > > Signed-off-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Josh Boyer <jwboyer@fedoraproject.org> > --- > drivers/input/serio/i8042.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c > index 020053f..05c6285 100644 > --- a/drivers/input/serio/i8042.c > +++ b/drivers/input/serio/i8042.c > @@ -855,7 +855,7 @@ static int __init i8042_check_aux(void) > static int i8042_controller_check(void) > { > if (i8042_flush()) { > - pr_err("No controller found\n"); > + pr_notice("No controller found\n"); > return -ENODEV; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2014-02-25 at 11:06 -0500, Josh Boyer wrote: > On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <ajax@redhat.com> wrote: > > From: Peter Jones <pjones@redhat.com> > > > > Some systems, such as EFI-based Apple systems, won't necessarily have an > > i8042 to initialize. We shouldn't be printing an error message in this > > case, since not detecting the chip is the correct behavior. > > > > v2: Downgrade to pr_notice instead of pr_err. > > > > Signed-off-by: Adam Jackson <ajax@redhat.com> > > Reviewed-by: Josh Boyer <jwboyer@fedoraproject.org> Ping? This patch or something like it has been pending since 2008 [1], would be nice to see it merged before it's old enough to start first grade. [1] - https://lkml.org/lkml/2008/9/29/248 - ajax -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 3, 2014 at 9:53 AM, Adam Jackson <ajax@redhat.com> wrote: > On Tue, 2014-02-25 at 11:06 -0500, Josh Boyer wrote: >> On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <ajax@redhat.com> wrote: >> > From: Peter Jones <pjones@redhat.com> >> > >> > Some systems, such as EFI-based Apple systems, won't necessarily have an >> > i8042 to initialize. We shouldn't be printing an error message in this >> > case, since not detecting the chip is the correct behavior. >> > >> > v2: Downgrade to pr_notice instead of pr_err. >> > >> > Signed-off-by: Adam Jackson <ajax@redhat.com> >> >> Reviewed-by: Josh Boyer <jwboyer@fedoraproject.org> > > Ping? This patch or something like it has been pending since 2008 [1], > would be nice to see it merged before it's old enough to start first > grade. > > [1] - https://lkml.org/lkml/2008/9/29/248 > Hey Ajax, regarding the input stuff, adding the maintainers always help. So adding Dmitry in CC. BTW, the patch looks good enough: Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index 020053f..05c6285 100644 --- a/drivers/input/serio/i8042.c +++ b/drivers/input/serio/i8042.c @@ -855,7 +855,7 @@ static int __init i8042_check_aux(void) static int i8042_controller_check(void) { if (i8042_flush()) { - pr_err("No controller found\n"); + pr_notice("No controller found\n"); return -ENODEV; }