| Message ID | 1232301715-20292-2-git-send-email-corentincj@iksaif.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Arg .. don't know what I did, but I clearly messed up with git-send-email. Isn't git send-email --compose --to linux-acpi@vger.kernel.org --cc lenb@kernel.org *patch the right command line ? It seems the intro email was lost in the process: > Hi Len, > Here are some patch for asus platform drivers. > The last one is the most interesting, it adds > input layer support for reporting hotkeys. -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Len Brown, Intel Open Source Technology Center On Sun, 18 Jan 2009, Corentin Chary wrote: > Arg .. don't know what I did, but I clearly messed up with git-send-email. > > Isn't git send-email --compose --to linux-acpi@vger.kernel.org --cc > lenb@kernel.org *patch the right command line ? > > It seems the intro email was lost in the process: > > > Hi Len, > > Here are some patch for asus platform drivers. > > The last one is the most interesting, it adds > > input layer support for reporting hotkeys. yes, it is correct, and I received the intro message. I use this. git send-email --from "Len Brown <lenb@kernel.org>" --compose --to linux-acpi@vger.kernel.org --suppress-from --no-chain-reply-to patch-release Note that you can assume i'm on linux-acpi, so you don't have to cc me. The intro message is helpful, however, so I know if you think the patches are for testing or you think they're ready for release. cheers, -Len -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Len Brown, Intel Open Source Technology Center > > On Sun, 18 Jan 2009, Corentin Chary wrote: > >> Arg .. don't know what I did, but I clearly messed up with git-send-email. >> >> Isn't git send-email --compose --to linux-acpi@vger.kernel.org --cc >> lenb@kernel.org *patch the right command line ? >> >> It seems the intro email was lost in the process: >> >> > Hi Len, >> > Here are some patch for asus platform drivers. >> > The last one is the most interesting, it adds >> > input layer support for reporting hotkeys. > > > yes, it is correct, and I received the intro message. > I use this. > > git send-email --from "Len Brown <lenb@kernel.org>" --compose --to > linux-acpi@vger.kernel.org --suppress-from --no-chain-reply-to > patch-release > > Note that you can assume i'm on linux-acpi, so you don't > have to cc me. The intro message is helpful, however, > so I know if you think the patches are for testing > or you think they're ready for release. > > cheers, > -Len Thanks for the tips. As I said in another mail you can forget this series and some forgoten patch in the mailling list from Mathiew. I now have a working git tree http://git.iksaif.net/?p=acpi4asus.git;a=summary and I just send another series regrouping all this patches. git is really a great tool =).
diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c index 9d93cb9..66d611b 100644 --- a/drivers/platform/x86/eeepc-laptop.c +++ b/drivers/platform/x86/eeepc-laptop.c @@ -737,13 +737,21 @@ static void eeepc_backlight_exit(void) { if (eeepc_backlight_device) backlight_device_unregister(eeepc_backlight_device); - if (ehotk->inputdev) - input_unregister_device(ehotk->inputdev); + eeepc_backlight_device = NULL; +} + +static void eeepc_rfkill_exit(void) +{ if (ehotk->eeepc_wlan_rfkill) rfkill_unregister(ehotk->eeepc_wlan_rfkill); if (ehotk->eeepc_bluetooth_rfkill) rfkill_unregister(ehotk->eeepc_bluetooth_rfkill); - eeepc_backlight_device = NULL; +} + +static void eeepc_input_exit(void) +{ + if (ehotk->inputdev) + input_unregister_device(ehotk->inputdev); } static void eeepc_hwmon_exit(void) @@ -762,6 +770,8 @@ static void eeepc_hwmon_exit(void) static void __exit eeepc_laptop_exit(void) { eeepc_backlight_exit(); + eeepc_rfkill_exit(); + eeepc_input_exit(); eeepc_hwmon_exit(); acpi_bus_unregister_driver(&eeepc_hotk_driver); sysfs_remove_group(&platform_device->dev.kobj, @@ -865,6 +875,8 @@ fail_platform_driver: fail_hwmon: eeepc_backlight_exit(); fail_backlight: + eeepc_input_exit(); + eeepc_rfkill_exit(); return result; }
eeepc_backlight_exit() was doing rfkill and input stuff, which is a nonsense. This patch add two specific exit functions, one for input and one for rfkill. Signed-off-by: Corentin Chary <corentincj@iksaif.net> --- drivers/platform/x86/eeepc-laptop.c | 18 +++++++++++++++--- 1 files changed, 15 insertions(+), 3 deletions(-)