| Message ID | 1393832008-22174-6-git-send-email-archit@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Archit, > From: Archit Taneja [mailto:archit@ti.com] > Sent: Monday, March 03, 2014 8:33 AM > > The minimum width and height for VPE input/output was kept as 128 > pixels. VPE doesn't have a constraint on the image height, it requires > the image width to be atleast 16 bytes. "16 bytes" - shouldn't it be pixels? (also "at least" :) ) I can correct it when applying the patch if the above is the case. > Change the minimum supported dimensions to 32x32. This allows us to de- > interlace qcif content. A smaller image size than 32x32 didn't make > much sense, so stopped at this. > > Signed-off-by: Archit Taneja <archit@ti.com> Best wishes,
Hi, On Monday 03 March 2014 05:44 PM, Kamil Debski wrote: > Hi Archit, > >> From: Archit Taneja [mailto:archit@ti.com] >> Sent: Monday, March 03, 2014 8:33 AM >> >> The minimum width and height for VPE input/output was kept as 128 >> pixels. VPE doesn't have a constraint on the image height, it requires >> the image width to be atleast 16 bytes. > > "16 bytes" - shouldn't it be pixels? (also "at least" :) ) > I can correct it when applying the patch if the above is the case. VPDMA IP requires the line stride of the input/output images to be at least 16 bytes in total. This can safely result in a minimum width of 16 pixels(NV12 has the least bpp with 1 byte per pixel). But we don't really have any need to support such small image resolutions. So I picked up 32x32 as the minimum size, and tested VPE with that. Thanks, Archit -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 915029b..3a610a6 100644 --- a/drivers/media/platform/ti-vpe/vpe.c +++ b/drivers/media/platform/ti-vpe/vpe.c @@ -49,8 +49,8 @@ #define VPE_MODULE_NAME "vpe" /* minimum and maximum frame sizes */ -#define MIN_W 128 -#define MIN_H 128 +#define MIN_W 32 +#define MIN_H 32 #define MAX_W 1920 #define MAX_H 1080
The minimum width and height for VPE input/output was kept as 128 pixels. VPE doesn't have a constraint on the image height, it requires the image width to be atleast 16 bytes. Change the minimum supported dimensions to 32x32. This allows us to de-interlace qcif content. A smaller image size than 32x32 didn't make much sense, so stopped at this. Signed-off-by: Archit Taneja <archit@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)