diff mbox

[2/2] drm: Remove the minor master list

Message ID 1392817242-15889-2-git-send-email-thellstrom@vmware.com (mailing list archive)
State New, archived
Headers show

Commit Message

Thomas Hellstrom Feb. 19, 2014, 1:40 p.m. UTC
It doesn't appear to be used anywhere.

Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
---
 drivers/gpu/drm/drm_stub.c |    5 -----
 include/drm/drmP.h         |    2 --
 2 files changed, 7 deletions(-)

Comments

David Herrmann March 5, 2014, 2:46 p.m. UTC | #1
Hi

On Wed, Feb 19, 2014 at 2:40 PM, Thomas Hellstrom <thellstrom@vmware.com> wrote:
> It doesn't appear to be used anywhere.

Looks good.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David

> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
> ---
>  drivers/gpu/drm/drm_stub.c |    5 -----
>  include/drm/drmP.h         |    2 --
>  2 files changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
> index 98a33c580..4f17c79 100644
> --- a/drivers/gpu/drm/drm_stub.c
> +++ b/drivers/gpu/drm/drm_stub.c
> @@ -152,8 +152,6 @@ struct drm_master *drm_master_create(struct drm_minor *minor)
>         INIT_LIST_HEAD(&master->magicfree);
>         master->minor = minor;
>
> -       list_add_tail(&master->head, &minor->master_list);
> -
>         return master;
>  }
>
> @@ -171,8 +169,6 @@ static void drm_master_destroy(struct kref *kref)
>         struct drm_device *dev = master->minor->dev;
>         struct drm_map_list *r_list, *list_temp;
>
> -       list_del(&master->head);
> -
>         if (dev->driver->master_destroy)
>                 dev->driver->master_destroy(dev, master);
>
> @@ -296,7 +292,6 @@ static int drm_get_minor(struct drm_device *dev, struct drm_minor **minor,
>         new_minor->device = MKDEV(DRM_MAJOR, minor_id);
>         new_minor->dev = dev;
>         new_minor->index = minor_id;
> -       INIT_LIST_HEAD(&new_minor->master_list);
>
>         idr_replace(&drm_minors_idr, new_minor, minor_id);
>
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> index ff68e26..56c519f 100644
> --- a/include/drm/drmP.h
> +++ b/include/drm/drmP.h
> @@ -718,7 +718,6 @@ struct drm_master {
>
>         struct kref refcount; /* refcount for this master */
>
> -       struct list_head head; /**< each minor contains a list of masters */
>         struct drm_minor *minor; /**< link back to minor we are a master for */
>
>         char *unique;                   /**< Unique identifier: e.g., busid */
> @@ -1050,7 +1049,6 @@ struct drm_minor {
>         struct mutex debugfs_lock; /* Protects debugfs_list. */
>
>         struct drm_master *master; /* currently active master for this node */
> -       struct list_head master_list;
>         struct drm_mode_group mode_group;
>  };
>
> --
> 1.7.10.4
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
index 98a33c580..4f17c79 100644
--- a/drivers/gpu/drm/drm_stub.c
+++ b/drivers/gpu/drm/drm_stub.c
@@ -152,8 +152,6 @@  struct drm_master *drm_master_create(struct drm_minor *minor)
 	INIT_LIST_HEAD(&master->magicfree);
 	master->minor = minor;
 
-	list_add_tail(&master->head, &minor->master_list);
-
 	return master;
 }
 
@@ -171,8 +169,6 @@  static void drm_master_destroy(struct kref *kref)
 	struct drm_device *dev = master->minor->dev;
 	struct drm_map_list *r_list, *list_temp;
 
-	list_del(&master->head);
-
 	if (dev->driver->master_destroy)
 		dev->driver->master_destroy(dev, master);
 
@@ -296,7 +292,6 @@  static int drm_get_minor(struct drm_device *dev, struct drm_minor **minor,
 	new_minor->device = MKDEV(DRM_MAJOR, minor_id);
 	new_minor->dev = dev;
 	new_minor->index = minor_id;
-	INIT_LIST_HEAD(&new_minor->master_list);
 
 	idr_replace(&drm_minors_idr, new_minor, minor_id);
 
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index ff68e26..56c519f 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -718,7 +718,6 @@  struct drm_master {
 
 	struct kref refcount; /* refcount for this master */
 
-	struct list_head head; /**< each minor contains a list of masters */
 	struct drm_minor *minor; /**< link back to minor we are a master for */
 
 	char *unique;			/**< Unique identifier: e.g., busid */
@@ -1050,7 +1049,6 @@  struct drm_minor {
 	struct mutex debugfs_lock; /* Protects debugfs_list. */
 
 	struct drm_master *master; /* currently active master for this node */
-	struct list_head master_list;
 	struct drm_mode_group mode_group;
 };