diff mbox

spi/qspi: Fix return from mmap path

Message ID 1394443753-25773-1-git-send-email-sourav.poddar@ti.com (mailing list archive)
State Accepted
Commit 9304f51e5f3e1365860968bce168d904f3e31bd3
Headers show

Commit Message

Poddar, Sourav March 10, 2014, 9:29 a.m. UTC
mmap resource requirement is only for memory mapped operations.
If the user does not populate mmap resource, dont call return,
instead we go on for normal spi mode operations.

Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
 drivers/spi/spi-ti-qspi.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Poddar, Sourav March 10, 2014, 9:49 a.m. UTC | #1
+ Mark's kernel.org email
On Monday 10 March 2014 02:59 PM, Sourav Poddar wrote:
> mmap resource requirement is only for memory mapped operations.
> If the user does not populate mmap resource, dont call return,
> instead we go on for normal spi mode operations.
>
> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com>
> ---
>   drivers/spi/spi-ti-qspi.c |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
> index 49ddfc7..6c211d1 100644
> --- a/drivers/spi/spi-ti-qspi.c
> +++ b/drivers/spi/spi-ti-qspi.c
> @@ -461,7 +461,6 @@ static int ti_qspi_probe(struct platform_device *pdev)
>   		if (res_mmap == NULL) {
>   			dev_err(&pdev->dev,
>   				"memory mapped resource not required\n");
> -			return -ENODEV;
>   		}
>   	}
>

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown March 10, 2014, 10:15 a.m. UTC | #2
On Mon, Mar 10, 2014 at 03:19:21PM +0530, sourav wrote:
> + Mark's kernel.org email
> On Monday 10 March 2014 02:59 PM, Sourav Poddar wrote:

None of the tools can apply patches that have been quoted...
Poddar, Sourav March 10, 2014, 10:20 a.m. UTC | #3
On Monday 10 March 2014 03:45 PM, Mark Brown wrote:
> On Mon, Mar 10, 2014 at 03:19:21PM +0530, sourav wrote:
>> + Mark's kernel.org email
>> On Monday 10 March 2014 02:59 PM, Sourav Poddar wrote:
> None of the tools can apply patches that have been quoted...
I am not sure whats happening. I will send you the new version.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown March 10, 2014, 10:28 a.m. UTC | #4
On Mon, Mar 10, 2014 at 03:50:42PM +0530, sourav wrote:
> On Monday 10 March 2014 03:45 PM, Mark Brown wrote:
> >On Mon, Mar 10, 2014 at 03:19:21PM +0530, sourav wrote:
> >>+ Mark's kernel.org email
> >>On Monday 10 March 2014 02:59 PM, Sourav Poddar wrote:

> >None of the tools can apply patches that have been quoted...

> I am not sure whats happening. I will send you the new version.

What I'm saying is that if you got the address wrong CCing me into a
reply isn't going to help much since the quoting mangles the patch.
diff mbox

Patch

diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index 49ddfc7..6c211d1 100644
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -461,7 +461,6 @@  static int ti_qspi_probe(struct platform_device *pdev)
 		if (res_mmap == NULL) {
 			dev_err(&pdev->dev,
 				"memory mapped resource not required\n");
-			return -ENODEV;
 		}
 	}