| Message ID | 1393922513-31824-1-git-send-email-lars@metafoo.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 58d4d3c976b33784a1443c446a3d7203bf2153f0 |
| Delegated to: | Mark Brown |
| Headers | show |
On Tue, Mar 04, 2014 at 09:41:53AM +0100, Lars-Peter Clausen wrote: > The si476x is a MFD device and the CODEC driver is using the regmap struct of > the parent device, hence automatic IO setup will not work and we need to > manually call snd_soc_codec_set_cache_io(). The issue was introduced commit > d6173df35f ("ASoC: si476x: Remove custom register I/O implementation") Applied, thanks. Please if you're listing which commit is being fixed do it using a Fixes tag - it makes it easier to apply.
diff --git a/sound/soc/codecs/si476x.c b/sound/soc/codecs/si476x.c index 52e7cb0..fa2b8e0 100644 --- a/sound/soc/codecs/si476x.c +++ b/sound/soc/codecs/si476x.c @@ -210,7 +210,7 @@ out: static int si476x_codec_probe(struct snd_soc_codec *codec) { codec->control_data = dev_get_regmap(codec->dev->parent, NULL); - return 0; + return snd_soc_codec_set_cache_io(codec, 0, 0, SND_SOC_REGMAP); } static struct snd_soc_dai_ops si476x_dai_ops = {
The si476x is a MFD device and the CODEC driver is using the regmap struct of the parent device, hence automatic IO setup will not work and we need to manually call snd_soc_codec_set_cache_io(). The issue was introduced commit d6173df35f ("ASoC: si476x: Remove custom register I/O implementation") Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> --- sound/soc/codecs/si476x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)