diff mbox

[v3,resend] spi: hs-spi: Improve bindings

Message ID 1394530851-20244-1-git-send-email-geert@linux-m68k.org (mailing list archive)
State Accepted
Headers show

Commit Message

Geert Uytterhoeven March 11, 2014, 9:40 a.m. UTC 
From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>

  - Add future-proof "renesas,hspi-<soctype>" compatible values,
  - Add missing "interrupt-parent", "#address-cells", and "#size-cells"
    properties,
  - Add reference to pinctrl documentation,
  - Add example bindings.

Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
---
Mark: Can you please ack and take this, so Simon can apply the patches that
      use these bindings? Thx!

v3:
  - Split in two patches: bindings and dtsi updates
v2:
  - Add Tested-by
  - List full example compatible properties with soctypes instead of just
    the soctypes, so checkpatch can validate DTSes.

 Documentation/devicetree/bindings/spi/sh-hspi.txt |   28 ++++++++++++++++++---
 1 file changed, 25 insertions(+), 3 deletions(-)

Comments

Mark Brown March 11, 2014, 9:49 a.m. UTC | #1 
On Tue, Mar 11, 2014 at 10:40:51AM +0100, Geert Uytterhoeven wrote:

> Mark: Can you please ack and take this, so Simon can apply the patches that
>       use these bindings? Thx!

Why would I ack it and not apply it?
Geert Uytterhoeven March 11, 2014, 9:56 a.m. UTC | #2 
On Tue, Mar 11, 2014 at 10:49 AM, Mark Brown <broonie@kernel.org> wrote:
> On Tue, Mar 11, 2014 at 10:40:51AM +0100, Geert Uytterhoeven wrote:
>> Mark: Can you please ack and take this, so Simon can apply the patches that
>>       use these bindings? Thx!
>
> Why would I ack it and not apply it?

Sorry, bad wording on my side.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown March 11, 2014, 10:42 a.m. UTC | #3 
On Tue, Mar 11, 2014 at 10:40:51AM +0100, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> 
>   - Add future-proof "renesas,hspi-<soctype>" compatible values,
>   - Add missing "interrupt-parent", "#address-cells", and "#size-cells"
>     properties,
>   - Add reference to pinctrl documentation,
>   - Add example bindings.

Applied, thanks.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/spi/sh-hspi.txt b/Documentation/devicetree/bindings/spi/sh-hspi.txt
index 30b57b1c8a13..319bad4af875 100644
--- a/Documentation/devicetree/bindings/spi/sh-hspi.txt
+++ b/Documentation/devicetree/bindings/spi/sh-hspi.txt
@@ -1,7 +1,29 @@ 
 Renesas HSPI.
 
 Required properties:
-- compatible : 	"renesas,hspi"
-- reg : Offset and length of the register set for the device
-- interrupts : interrupt line used by HSPI
+- compatible       : "renesas,hspi-<soctype>", "renesas,hspi" as fallback.
+		     Examples with soctypes are:
+		       - "renesas,hspi-r8a7778" (R-Car M1)
+		       - "renesas,hspi-r8a7779" (R-Car H1)
+- reg              : Offset and length of the register set for the device
+- interrupt-parent : The phandle for the interrupt controller that
+		     services interrupts for this device
+- interrupts       : Interrupt specifier
+- #address-cells   : Must be <1>
+- #size-cells      : Must be <0>
+
+Pinctrl properties might be needed, too.  See
+Documentation/devicetree/bindings/pinctrl/renesas,*.
+
+Example:
+
+	hspi0: spi@fffc7000 {
+		compatible = "renesas,hspi-r8a7778", "renesas,hspi";
+		reg = <0xfffc7000 0x18>;
+		interrupt-parent = <&gic>;
+		interrupts = <0 63 IRQ_TYPE_LEVEL_HIGH>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+	};