| Message ID | 1394526833-24805-11-git-send-email-archit@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 03/11/14 09:33, Archit Taneja wrote: > The bus_info parameter in v4l2_capabilities expects a 'platform_' prefix. This > wasn't done in the driver and hence was breaking compliance. Update the bus_info > parameter accordingly. > > Signed-off-by: Archit Taneja <archit@ti.com> Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com> > --- > drivers/media/platform/ti-vpe/vpe.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c > index 46b9d44..5591d04 100644 > --- a/drivers/media/platform/ti-vpe/vpe.c > +++ b/drivers/media/platform/ti-vpe/vpe.c > @@ -1346,7 +1346,8 @@ static int vpe_querycap(struct file *file, void *priv, > { > strncpy(cap->driver, VPE_MODULE_NAME, sizeof(cap->driver) - 1); > strncpy(cap->card, VPE_MODULE_NAME, sizeof(cap->card) - 1); > - strlcpy(cap->bus_info, VPE_MODULE_NAME, sizeof(cap->bus_info)); > + snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s", > + VPE_MODULE_NAME); > cap->device_caps = V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMING; > cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS; > return 0; > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 46b9d44..5591d04 100644 --- a/drivers/media/platform/ti-vpe/vpe.c +++ b/drivers/media/platform/ti-vpe/vpe.c @@ -1346,7 +1346,8 @@ static int vpe_querycap(struct file *file, void *priv, { strncpy(cap->driver, VPE_MODULE_NAME, sizeof(cap->driver) - 1); strncpy(cap->card, VPE_MODULE_NAME, sizeof(cap->card) - 1); - strlcpy(cap->bus_info, VPE_MODULE_NAME, sizeof(cap->bus_info)); + snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s", + VPE_MODULE_NAME); cap->device_caps = V4L2_CAP_VIDEO_M2M_MPLANE | V4L2_CAP_STREAMING; cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS; return 0;
The bus_info parameter in v4l2_capabilities expects a 'platform_' prefix. This wasn't done in the driver and hence was breaking compliance. Update the bus_info parameter accordingly. Signed-off-by: Archit Taneja <archit@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)