diff mbox

[RFC,09/12] drm/gma500: Remove dead code

Message ID 1392969328-23133-10-git-send-email-thierry.reding@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Thierry Reding Feb. 21, 2014, 7:55 a.m. UTC 
From: Thierry Reding <treding@nvidia.com>

The gma500 driver sets DRIVER_GEM unconditionally, so testing for the
absence of the feature will always fail.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/gma500/gem.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Patrik Jakobsson March 11, 2014, 5:07 p.m. UTC | #1 
On Fri, Feb 21, 2014 at 8:55 AM, Thierry Reding
<thierry.reding@gmail.com> wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The gma500 driver sets DRIVER_GEM unconditionally, so testing for the
> absence of the feature will always fail.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Queued for -next

Thanks
Patrik

> ---
>  drivers/gpu/drm/gma500/gem.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
> index d8426bc31b09..424dda95fbc6 100644
> --- a/drivers/gpu/drm/gma500/gem.c
> +++ b/drivers/gpu/drm/gma500/gem.c
> @@ -62,9 +62,6 @@ int psb_gem_dumb_map_gtt(struct drm_file *file, struct drm_device *dev,
>         int ret = 0;
>         struct drm_gem_object *obj;
>
> -       if (!drm_core_check_feature(dev, DRIVER_GEM))
> -               return -ENODEV;
> -
>         mutex_lock(&dev->struct_mutex);
>
>         /* GEM does all our handle to object mapping */
> --
> 1.8.4.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
index d8426bc31b09..424dda95fbc6 100644
--- a/drivers/gpu/drm/gma500/gem.c
+++ b/drivers/gpu/drm/gma500/gem.c
@@ -62,9 +62,6 @@  int psb_gem_dumb_map_gtt(struct drm_file *file, struct drm_device *dev,
 	int ret = 0;
 	struct drm_gem_object *obj;
 
-	if (!drm_core_check_feature(dev, DRIVER_GEM))
-		return -ENODEV;
-
 	mutex_lock(&dev->struct_mutex);
 
 	/* GEM does all our handle to object mapping */